Skip to content

[config](inverted index)Make inverted_index_ram_dir enable by default(#35094) - #39120

Merged
yiguolei merged 1 commit into
apache:branch-2.1from
qidaye:pick_enable_ram_dir_2.1
Aug 8, 2024
Merged

[config](inverted index)Make inverted_index_ram_dir enable by default(#35094)#39120
yiguolei merged 1 commit into
apache:branch-2.1from
qidaye:pick_enable_ram_dir_2.1

Conversation

@qidaye

@qidayeqidaye commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

bp #35094

@qidaye@luennng
[config](inverted index)Make inverted_index_ram_dir enable by default (…
1da6ff4
…apache#35094)
`inverted_index_ram_dir_enable` can reduce disk IO in writing index time.
We turn it on by default.
Co-authored-by: Luennng <luennng@gmail.com>
@doris-robot

doris-robot commented Aug 8, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye

qidaye commented Aug 8, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang approved these changes Aug 8, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2024
@github-actions

github-actionsBot commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Aug 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.39% (9267/25463)
Line Coverage: 27.85% (75714/271875)
Region Coverage: 26.69% (38921/145847)
Branch Coverage: 23.41% (19755/84382)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1da6ff41f96dada3d91e3a296f5512dbc52d0def_1da6ff41f96dada3d91e3a296f5512dbc52d0def/report/index.html

@yiguolei
yiguolei merged commit 8678fce into apache:branch-2.1Aug 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qidaye@doris-robot@xiaokang@yiguolei