Skip to content

[Feature] Add QueryDetail to store query statistics. - #3744

Merged
chaoyli merged 8 commits into
apache:masterfrom
chaoyli:master
Jun 15, 2020
Merged

[Feature] Add QueryDetail to store query statistics.#3744
chaoyli merged 8 commits into
apache:masterfrom
chaoyli:master

Conversation

@chaoyli

@chaoylichaoyli commented Jun 1, 2020

Copy link
Copy Markdown
Contributor
  1. Store the query statistics in memory.
  2. Supporting RESTFUL interface to get the statistics.

@chaoylichaoyli self-assigned this Jun 1, 2020
@chaoylichaoyli linked an issue Jun 1, 2020 that may be closed by this pull request
[Proposal] Add query monitor detail in FE. #3689
Closed
xy720
xy720 reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/ConnectProcessor.java
xy720
xy720 reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/SessionVariable.java Outdated
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetail.java
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java Outdated
kangkaisen
kangkaisen reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java
@kangkaisen

kangkaisen commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

@chaoyli Hi, you should add the doc for new http api.

morningman
morningman reviewed Jun 1, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/http/rest/ProfileAction.java
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetail.java Outdated
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
@chaoylichaoyli closed this Jun 3, 2020
@chaoylichaoyli reopened this Jun 9, 2020
morningman
morningman requested changes Jun 10, 2020
View reviewed changes
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetail.java
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated
morningman
morningman reviewed Jun 11, 2020
View reviewed changes
Comment threadbe/src/service/http_service.cpp Outdated
morningman
morningman requested changes Jun 14, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please DO NOT modify multiple unrelated modules in one PR. If you need to make changes, please submit multiple PRs, or specify the changes you made in the comment.

In this PR, you try to modify:

  1. Some configuration defaults
  2. Units of monitoring indicators
  3. Delete some default logs
  4. QueryDetails related changes

There 4 changes seems unrelated.

Comment threaddocs/zh-CN/administrator-guide/http-actions/connection-action.md Outdated
Comment threaddocs/zh-CN/administrator-guide/http-actions/connection-action.md Outdated
Comment threaddocs/zh-CN/administrator-guide/http-actions/connection-action.md Outdated
Comment threaddocs/zh-CN/administrator-guide/http-actions/query-detail-action.md Outdated
Comment threaddocs/zh-CN/administrator-guide/http-actions/query-detail-action.md Outdated
Comment threadfe/src/main/java/org/apache/doris/common/Log4jConfig.java
Comment threadfe/src/main/java/org/apache/doris/PaloFe.java
Comment threadfe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
morningman
morningman approved these changes Jun 15, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added approved Indicates a PR has been approved by one committer. area/metrics Issues or PRs related to the metrics kind/improvement labels Jun 15, 2020
@morningmanmorningman added the api-review Categorizes an issue or PR as actively needing an API review. label Jun 15, 2020
@chaoyli
chaoyli merged commit 6c4d7c6 into apache:masterJun 15, 2020
@morningmanmorningman mentioned this pull request Jun 16, 2020
Merged
baidu-doris pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jun 17, 2020
@chaoyli
[Feature] Add QueryDetail to store query statistics. (apache#3744)
39fa777
1. Store the query statistics in memory.
2. Supporting RESTFUL interface to get the statistics.
hubgeter pushed a commit to hubgeter/doris that referenced this pull request Mar 12, 2025
@BiteTheDDDDt
[Bug](runtime-filter) fix missing rf when target not exist on backend…
c70b1eb
… where the producer is located apache#47108 (apache#3744)
Sometimes the consumer of a certain rf does not exist on the BE where
the producer of a certain rf is located. At this time, the send to
remote operation of the rf will cause problems and the rf will be lost.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kangkaisenkangkaisenkangkaisen left review comments
@xy720xy720xy720 left review comments
@morningmanmorningmanmorningman approved these changes

Assignees

@chaoylichaoyli

Labels

api-reviewCategorizes an issue or PR as actively needing an API review.approvedIndicates a PR has been approved by one committer.area/metricsIssues or PRs related to the metricskind/improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal] Add query monitor detail in FE.

4 participants

@chaoyli@kangkaisen@morningman@xy720