Skip to content

[Bug](runtime-filter) fix missing rf when target not exist on backend where the producer is… - #47108

Merged
BiteTheDDDDt merged 5 commits into
apache:masterfrom
BiteTheDDDDt:fix_0116
Jan 20, 2025
Merged

[Bug](runtime-filter) fix missing rf when target not exist on backend where the producer is…#47108
BiteTheDDDDt merged 5 commits into
apache:masterfrom
BiteTheDDDDt:fix_0116

Conversation

@BiteTheDDDDt

@BiteTheDDDDtBiteTheDDDDt commented Jan 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

… located

What problem does this PR solve?

Sometimes the consumer of a certain rf does not exist on the BE where the producer of a certain rf is located. At this time, the send to remote operation of the rf will cause problems and the rf will be lost.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt

BiteTheDDDDt commented Jan 16, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@BiteTheDDDDt

BiteTheDDDDt commented Jan 16, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

BiteTheDDDDt commented Jan 16, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

1 similar comment
@BiteTheDDDDt

BiteTheDDDDt commented Jan 16, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@wm1581066wm1581066 added the usercase Important user case type label label Jan 16, 2025
@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

4 similar comments
@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt
fix missing rf when target not exist on backend where the producer is…
b36b197
… located
fix
update
fix
update
update
fix
update case
enlarge timeout
update
@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

HappenLee
HappenLee previously approved these changes Jan 17, 2025
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
@github-actions

github-actionsBot commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
@BiteTheDDDDt

BiteTheDDDDt commented Jan 17, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

BiteTheDDDDt commented Jan 20, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 20, 2025
@github-actions

github-actionsBot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

HappenLee
HappenLee approved these changes Jan 20, 2025
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt
BiteTheDDDDt merged commit fe610ff into apache:masterJan 20, 2025
github-actionsBot pushed a commit that referenced this pull request Jan 20, 2025
@BiteTheDDDDtYour Name
[Bug](runtime-filter) fix missing rf when target not exist on backend…
8dbbfd9
… where the producer is… (#47108)
… located
### What problem does this PR solve?
Sometimes the consumer of a certain rf does not exist on the BE where
the producer of a certain rf is located. At this time, the send to
remote operation of the rf will cause problems and the rf will be lost.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actionsgithub-actionsBot mentioned this pull request Jan 20, 2025
Merged
BiteTheDDDDt added a commit that referenced this pull request Jan 21, 2025
@github-actions@BiteTheDDDDt
branch-3.0: [Bug](runtime-filter) fix missing rf when target not exis…
b0d5f91
…t on backend where the producer is… #47108 (#47247)
Cherry-picked from #47108
Co-authored-by: Pxl <xl@selectdb.com>
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@BiteTheDDDDt
[Bug](runtime-filter) fix missing rf when target not exist on backend…
6f99716
… where the producer is… (apache#47108)
… located
Sometimes the consumer of a certain rf does not exist on the BE where
the producer of a certain rf is located. At this time, the send to
remote operation of the rf will cause problems and the rf will be lost.
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@BiteTheDDDDt@lzyy2024
[Bug](runtime-filter) fix missing rf when target not exist on backend…
0012ff8
… where the producer is… (apache#47108)
… located
### What problem does this PR solve?
Sometimes the consumer of a certain rf does not exist on the BE where
the producer of a certain rf is located. At this time, the send to
remote operation of the rf will cause problems and the rf will be lost.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
hubgeter pushed a commit to hubgeter/doris that referenced this pull request Mar 12, 2025
@BiteTheDDDDt
[Bug](runtime-filter) fix missing rf when target not exist on backend…
c70b1eb
… where the producer is located apache#47108 (apache#3744)
Sometimes the consumer of a certain rf does not exist on the BE where
the producer of a certain rf is located. At this time, the send to
remote operation of the rf will cause problems and the rf will be lost.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLeeHappenLeeHappenLee approved these changes
@Gabriel39Gabriel39Gabriel39 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt@HappenLee@Gabriel39@gavinchou@wm1581066