[Fix](Variant) check storage type before apply `get_row_ranges_by_dict` by eldenmoon · Pull Request #38413 · apache/doris

eldenmoon · 2024-07-26T08:21:56Z

storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type
serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes

Proposed changes

Issue Number: close #xxx

1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type 2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes

doris-robot · 2024-07-26T08:22:01Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

eldenmoon · 2024-07-26T08:22:45Z

run buildall

github-actions · 2024-07-26T08:28:21Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-07-26T09:02:35Z

TPC-H: Total hot run time: 39221 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9a9222886ff418d92d83fee00a602b461790832, data reload: false
------ Round 1 ----------------------------------
q1	17643	4345	4285	4285
q2	2010	208	195	195
q3	10434	1221	1076	1076
q4	10132	666	771	666
q5	7537	2695	2640	2640
q6	224	137	143	137
q7	959	600	600	600
q8	9221	1919	1902	1902
q9	8704	6567	6542	6542
q10	8903	3784	3745	3745
q11	456	249	247	247
q12	444	230	228	228
q13	17836	2997	3048	2997
q14	273	245	242	242
q15	516	482	493	482
q16	503	384	385	384
q17	964	690	715	690
q18	7980	7445	7379	7379
q19	3678	1027	1005	1005
q20	687	331	327	327
q21	5095	3170	3888	3170
q22	359	293	282	282
Total cold run time: 114558 ms
Total hot run time: 39221 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4421	4276	4257	4257
q2	372	271	271	271
q3	2997	2814	2848	2814
q4	1999	1680	1760	1680
q5	5553	5678	5528	5528
q6	228	147	135	135
q7	2162	1811	1825	1811
q8	3280	3423	3406	3406
q9	8853	8791	8872	8791
q10	4170	3999	3867	3867
q11	608	482	485	482
q12	802	636	641	636
q13	17177	3233	3200	3200
q14	322	287	283	283
q15	541	501	481	481
q16	502	436	452	436
q17	1849	1522	1516	1516
q18	8028	8047	7840	7840
q19	1807	1632	1714	1632
q20	2292	1948	1944	1944
q21	5300	5196	4972	4972
q22	617	521	534	521
Total cold run time: 73880 ms
Total hot run time: 56503 ms

doris-robot · 2024-07-26T09:13:45Z

TPC-DS: Total hot run time: 173703 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9a9222886ff418d92d83fee00a602b461790832, data reload: false
query1	1954	377	377	377
query2	7522	1971	1866	1866
query3	6636	203	216	203
query4	24816	17646	17390	17390
query5	3695	478	490	478
query6	263	160	166	160
query7	4600	296	286	286
query8	242	184	189	184
query9	8891	2457	2446	2446
query10	455	299	285	285
query11	11150	10007	10118	10007
query12	126	86	93	86
query13	1626	373	371	371
query14	10629	7697	7718	7697
query15	246	163	171	163
query16	7923	468	455	455
query17	1583	545	548	545
query18	2085	281	275	275
query19	230	145	141	141
query20	93	85	84	84
query21	232	99	96	96
query22	4217	3995	3948	3948
query23	34120	33599	33788	33599
query24	10305	2924	2908	2908
query25	581	392	389	389
query26	695	159	152	152
query27	2231	275	279	275
query28	6192	2062	2074	2062
query29	801	440	419	419
query30	250	152	152	152
query31	973	775	747	747
query32	97	53	60	53
query33	679	354	340	340
query34	879	484	484	484
query35	856	767	746	746
query36	1112	963	988	963
query37	143	79	86	79
query38	2946	2925	2811	2811
query39	898	869	812	812
query40	192	114	110	110
query41	45	46	43	43
query42	112	96	92	92
query43	506	477	461	461
query44	1076	714	712	712
query45	205	181	174	174
query46	1082	718	741	718
query47	1832	1738	1724	1724
query48	371	301	282	282
query49	829	409	418	409
query50	792	402	404	402
query51	6790	6735	6657	6657
query52	95	97	87	87
query53	262	180	177	177
query54	851	442	436	436
query55	76	71	72	71
query56	301	264	277	264
query57	1158	1038	1082	1038
query58	253	278	287	278
query59	2890	2657	2782	2657
query60	308	281	277	277
query61	96	94	96	94
query62	811	639	633	633
query63	209	172	176	172
query64	9159	2310	1697	1697
query65	3187	3108	3113	3108
query66	755	350	346	346
query67	15464	14854	14704	14704
query68	4824	547	549	547
query69	735	438	311	311
query70	1102	1035	1107	1035
query71	462	285	272	272
query72	7204	6067	6033	6033
query73	799	330	328	328
query74	6111	5649	5665	5649
query75	3643	2692	2641	2641
query76	3343	959	968	959
query77	634	295	308	295
query78	9642	9123	9354	9123
query79	3951	513	513	513
query80	1277	498	483	483
query81	579	223	222	222
query82	784	145	135	135
query83	208	180	184	180
query84	281	82	82	82
query85	1331	327	317	317
query86	376	300	271	271
query87	3210	3059	3053	3053
query88	4177	2472	2469	2469
query89	423	285	292	285
query90	1704	202	197	197
query91	198	103	100	100
query92	58	50	49	49
query93	5032	546	529	529
query94	666	297	295	295
query95	358	262	260	260
query96	608	269	279	269
query97	3178	3035	2988	2988
query98	209	208	199	199
query99	1737	1267	1257	1257
Total cold run time: 281523 ms
Total hot run time: 173703 ms

doris-robot · 2024-07-26T09:19:19Z

ClickBench: Total hot run time: 31.07 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a9a9222886ff418d92d83fee00a602b461790832, data reload: false
query1	0.04	0.03	0.03
query2	0.09	0.04	0.03
query3	0.23	0.05	0.05
query4	1.66	0.08	0.07
query5	0.49	0.50	0.47
query6	1.14	0.75	0.72
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.55	0.50	0.49
query10	0.53	0.54	0.54
query11	0.14	0.11	0.12
query12	0.15	0.13	0.13
query13	0.60	0.58	0.59
query14	0.77	0.79	0.78
query15	0.85	0.83	0.81
query16	0.38	0.38	0.37
query17	1.01	1.04	0.97
query18	0.23	0.22	0.22
query19	1.76	1.70	1.73
query20	0.01	0.01	0.01
query21	15.39	0.75	0.64
query22	3.52	7.54	2.22
query23	18.31	1.42	1.29
query24	2.17	0.23	0.23
query25	0.15	0.08	0.09
query26	0.31	0.21	0.22
query27	0.46	0.24	0.23
query28	13.31	1.04	1.01
query29	12.54	3.30	3.32
query30	0.26	0.06	0.06
query31	2.87	0.39	0.39
query32	3.26	0.48	0.48
query33	2.92	2.95	2.95
query34	17.11	4.38	4.40
query35	4.45	4.43	4.44
query36	0.67	0.47	0.47
query37	0.19	0.16	0.15
query38	0.15	0.16	0.16
query39	0.05	0.04	0.03
query40	0.16	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.03	0.03
Total cold run time: 109.16 s
Total hot run time: 31.07 s

eldenmoon · 2024-07-29T02:34:46Z

run buildall

github-actions · 2024-07-29T02:35:54Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T02:38:51Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T02:42:49Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T02:44:01Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T02:44:18Z

clang-tidy review says "All clean, LGTM! 👍"

eldenmoon · 2024-07-29T02:44:40Z

run buildall

github-actions · 2024-07-29T02:45:03Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T03:27:46Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T03:30:00Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-07-29T11:22:19Z

PR approved by anyone and no changes requested.

amorynan

LGTM

eldenmoon · 2024-07-30T02:39:02Z

run performance

eldenmoon · 2024-07-30T02:39:24Z

run buildall

doris-robot · 2024-07-30T04:01:07Z

TPC-H: Total hot run time: 42059 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13f1a64e633d70a3f4a3d66001f8acaeb182537d, data reload: false
------ Round 1 ----------------------------------
q1	17685	4126	4157	4126
q2	2027	217	219	217
q3	10417	1301	1336	1301
q4	10168	871	941	871
q5	7644	2981	3017	2981
q6	224	140	142	140
q7	1060	625	619	619
q8	9453	1947	1998	1947
q9	8604	6645	6635	6635
q10	8808	3816	3884	3816
q11	428	262	255	255
q12	436	238	234	234
q13	17773	2959	2962	2959
q14	274	239	240	239
q15	532	487	489	487
q16	532	394	392	392
q17	972	939	934	934
q18	8092	7289	7264	7264
q19	1466	1231	1216	1216
q20	581	330	358	330
q21	5352	4840	4813	4813
q22	354	285	283	283
Total cold run time: 112882 ms
Total hot run time: 42059 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4078	4040	4038	4038
q2	328	222	220	220
q3	2982	3013	3145	3013
q4	2022	2069	2000	2000
q5	5681	5521	5488	5488
q6	218	132	134	132
q7	2148	1750	1845	1750
q8	3342	3414	3382	3382
q9	8722	8706	8814	8706
q10	3959	4063	4175	4063
q11	549	445	452	445
q12	768	617	594	594
q13	16093	3144	3140	3140
q14	310	274	269	269
q15	537	496	486	486
q16	478	455	434	434
q17	1759	1735	1727	1727
q18	8282	7742	7692	7692
q19	1774	1760	1723	1723
q20	2044	1893	1815	1815
q21	5731	5562	5423	5423
q22	519	462	482	462
Total cold run time: 72324 ms
Total hot run time: 57002 ms

doris-robot · 2024-07-30T04:01:07Z

TPC-H: Total hot run time: 41593 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 13f1a64e633d70a3f4a3d66001f8acaeb182537d, data reload: false
------ Round 1 ----------------------------------
q1	17636	4145	4069	4069
q2	2027	209	210	209
q3	10446	1346	1353	1346
q4	10180	820	883	820
q5	7677	2962	3000	2962
q6	223	138	135	135
q7	1043	630	611	611
q8	9445	1829	1953	1829
q9	8634	6650	6661	6650
q10	8797	3835	3866	3835
q11	432	255	248	248
q12	425	229	229	229
q13	17773	2932	2923	2923
q14	268	245	245	245
q15	521	484	475	475
q16	525	398	392	392
q17	982	942	887	887
q18	8170	7381	7225	7225
q19	1436	1228	1215	1215
q20	572	336	333	333
q21	5303	4674	4846	4674
q22	365	281	284	281
Total cold run time: 112880 ms
Total hot run time: 41593 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4044	4039	4019	4019
q2	327	225	219	219
q3	2996	3020	3152	3020
q4	2004	2046	1972	1972
q5	5630	5489	5433	5433
q6	230	132	130	130
q7	2156	1781	1860	1781
q8	3318	3413	3377	3377
q9	8667	8706	8812	8706
q10	3954	4073	3974	3974
q11	547	443	446	443
q12	773	574	616	574
q13	16170	3133	3133	3133
q14	309	275	271	271
q15	535	488	499	488
q16	465	425	423	423
q17	1767	1740	1725	1725
q18	8212	7795	7633	7633
q19	1761	1719	1727	1719
q20	2040	1881	1839	1839
q21	5833	5558	5311	5311
q22	508	455	472	455
Total cold run time: 72246 ms
Total hot run time: 56645 ms

doris-robot · 2024-07-30T04:11:46Z

TPC-DS: Total hot run time: 170426 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13f1a64e633d70a3f4a3d66001f8acaeb182537d, data reload: false
query1	917	370	374	370
query2	6504	1735	1760	1735
query3	6681	211	224	211
query4	20511	17457	17313	17313
query5	3696	506	528	506
query6	274	176	167	167
query7	4594	303	295	295
query8	258	202	192	192
query9	8518	2428	2420	2420
query10	460	269	268	268
query11	10506	10102	10093	10093
query12	123	93	92	92
query13	1643	380	380	380
query14	9701	8246	7730	7730
query15	201	159	164	159
query16	6875	445	474	445
query17	951	572	565	565
query18	1920	287	291	287
query19	198	146	156	146
query20	91	87	86	86
query21	207	104	100	100
query22	4077	3977	3963	3963
query23	33888	33723	33450	33450
query24	9373	3156	3076	3076
query25	649	401	427	401
query26	1137	148	164	148
query27	2857	287	287	287
query28	7419	2041	2029	2029
query29	960	431	427	427
query30	228	151	161	151
query31	978	762	772	762
query32	101	57	54	54
query33	671	329	326	326
query34	934	487	485	485
query35	854	774	766	766
query36	1062	883	904	883
query37	163	79	83	79
query38	2970	2839	2847	2839
query39	870	847	806	806
query40	272	110	109	109
query41	43	43	43	43
query42	121	99	98	98
query43	464	409	428	409
query44	1174	738	722	722
query45	227	179	178	178
query46	1110	804	776	776
query47	1819	1716	1754	1716
query48	367	287	288	287
query49	908	427	404	404
query50	915	436	427	427
query51	6756	6570	6696	6570
query52	107	86	87	86
query53	261	186	180	180
query54	618	449	450	449
query55	75	75	76	75
query56	288	251	254	251
query57	1123	1055	1051	1051
query58	259	282	294	282
query59	2667	2450	2462	2450
query60	291	273	290	273
query61	96	121	94	94
query62	888	667	663	663
query63	216	181	179	179
query64	4767	1898	1875	1875
query65	3135	3060	3078	3060
query66	966	340	326	326
query67	15328	15037	14794	14794
query68	4367	555	623	555
query69	442	314	291	291
query70	1106	1057	1075	1057
query71	363	268	272	268
query72	7147	2709	2507	2507
query73	772	331	333	331
query74	6039	5595	5640	5595
query75	3398	2720	2715	2715
query76	2047	1373	1417	1373
query77	445	307	305	305
query78	9541	8850	8883	8850
query79	1494	532	522	522
query80	2078	503	503	503
query81	564	227	224	224
query82	1046	129	124	124
query83	282	166	169	166
query84	270	82	77	77
query85	1176	313	310	310
query86	417	304	283	283
query87	3236	3053	3080	3053
query88	2983	2482	2450	2450
query89	389	287	289	287
query90	1733	185	188	185
query91	131	100	104	100
query92	59	49	51	49
query93	1413	627	617	617
query94	795	287	271	271
query95	379	272	273	272
query96	599	279	279	279
query97	3245	3013	3043	3013
query98	226	202	203	202
query99	1676	1308	1273	1273
Total cold run time: 259139 ms
Total hot run time: 170426 ms

doris-robot · 2024-07-30T04:11:54Z

TPC-DS: Total hot run time: 171368 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 13f1a64e633d70a3f4a3d66001f8acaeb182537d, data reload: false
query1	909	387	373	373
query2	6489	1747	1685	1685
query3	6637	224	226	224
query4	19975	17385	17271	17271
query5	3689	525	537	525
query6	323	214	176	176
query7	4609	302	303	302
query8	261	233	207	207
query9	8525	2454	2447	2447
query10	417	274	270	270
query11	10448	10054	9947	9947
query12	123	95	90	90
query13	1635	380	375	375
query14	9694	8584	7898	7898
query15	201	166	161	161
query16	6811	492	449	449
query17	960	584	554	554
query18	1918	297	287	287
query19	193	153	148	148
query20	95	87	87	87
query21	208	108	114	108
query22	4121	3975	4006	3975
query23	33950	33654	33497	33497
query24	10418	3141	3108	3108
query25	702	450	437	437
query26	1697	163	160	160
query27	3121	294	295	294
query28	7351	2064	2025	2025
query29	1293	467	464	464
query30	247	162	152	152
query31	973	796	796	796
query32	104	63	57	57
query33	676	359	355	355
query34	946	523	524	523
query35	941	776	770	770
query36	1059	904	905	904
query37	292	87	87	87
query38	2932	2823	2781	2781
query39	877	838	816	816
query40	262	121	119	119
query41	49	49	46	46
query42	129	101	102	101
query43	471	424	474	424
query44	1199	741	735	735
query45	214	179	183	179
query46	1113	840	831	831
query47	1780	1702	1691	1691
query48	370	296	299	296
query49	949	445	436	436
query50	936	458	456	456
query51	6820	6802	6666	6666
query52	99	91	98	91
query53	263	188	194	188
query54	641	470	468	468
query55	77	77	79	77
query56	284	281	259	259
query57	1138	1034	1044	1034
query58	270	269	286	269
query59	2599	2382	2380	2380
query60	313	279	295	279
query61	110	101	129	101
query62	880	689	656	656
query63	229	184	195	184
query64	5641	1977	1915	1915
query65	3182	3126	3109	3109
query66	1312	335	328	328
query67	15119	14585	14680	14585
query68	5253	592	610	592
query69	685	379	345	345
query70	1146	1092	1060	1060
query71	474	294	285	285
query72	7789	2689	2505	2505
query73	911	341	339	339
query74	5987	5699	5584	5584
query75	3655	2762	2783	2762
query76	3395	1425	1422	1422
query77	553	323	311	311
query78	9495	8955	8907	8907
query79	1393	554	554	554
query80	762	529	533	529
query81	556	229	223	223
query82	434	138	134	134
query83	201	174	170	170
query84	276	82	88	82
query85	968	322	312	312
query86	435	298	301	298
query87	3306	3103	3052	3052
query88	3724	2501	2496	2496
query89	387	306	297	297
query90	1873	209	204	204
query91	129	106	105	105
query92	63	56	51	51
query93	1693	649	651	649
query94	758	312	299	299
query95	394	289	287	287
query96	619	286	284	284
query97	3215	3044	3050	3044
query98	285	208	192	192
query99	1640	1309	1306	1306
Total cold run time: 264723 ms
Total hot run time: 171368 ms

doris-robot · 2024-07-30T04:17:17Z

ClickBench: Total hot run time: 30 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 13f1a64e633d70a3f4a3d66001f8acaeb182537d, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.04
query4	1.70	0.06	0.06
query5	0.49	0.49	0.49
query6	1.16	0.71	0.71
query7	0.02	0.02	0.02
query8	0.05	0.04	0.05
query9	0.57	0.53	0.51
query10	0.55	0.55	0.56
query11	0.17	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.60
query14	0.77	0.81	0.83
query15	0.90	0.85	0.87
query16	0.36	0.36	0.35
query17	0.97	0.98	1.01
query18	0.22	0.21	0.22
query19	1.89	1.81	1.74
query20	0.01	0.01	0.01
query21	15.39	0.76	0.64
query22	4.00	8.26	1.36
query23	17.95	1.33	1.36
query24	2.26	0.22	0.22
query25	0.18	0.08	0.08
query26	0.31	0.21	0.21
query27	0.46	0.23	0.24
query28	13.15	0.99	0.97
query29	12.58	3.25	3.23
query30	0.26	0.06	0.05
query31	2.88	0.40	0.41
query32	3.25	0.48	0.47
query33	2.91	2.95	2.95
query34	15.45	4.29	4.24
query35	4.27	4.27	4.29
query36	0.68	0.49	0.49
query37	0.19	0.16	0.16
query38	0.16	0.15	0.16
query39	0.04	0.03	0.04
query40	0.16	0.13	0.13
query41	0.10	0.04	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 107.64 s
Total hot run time: 30 s

doris-robot · 2024-07-30T04:17:22Z

ClickBench: Total hot run time: 30.12 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 13f1a64e633d70a3f4a3d66001f8acaeb182537d, data reload: false
query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.05
query4	1.68	0.07	0.07
query5	0.47	0.48	0.48
query6	1.13	0.71	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.57	0.51	0.51
query10	0.55	0.57	0.58
query11	0.16	0.12	0.12
query12	0.15	0.13	0.12
query13	0.62	0.60	0.60
query14	0.80	0.80	0.80
query15	0.91	0.87	0.86
query16	0.36	0.36	0.36
query17	1.02	0.99	0.96
query18	0.22	0.22	0.22
query19	1.83	1.75	1.76
query20	0.01	0.01	0.01
query21	15.39	0.77	0.66
query22	3.58	6.14	1.35
query23	18.09	1.35	1.33
query24	2.23	0.21	0.21
query25	0.18	0.09	0.08
query26	0.32	0.22	0.22
query27	0.45	0.25	0.24
query28	13.16	1.00	0.99
query29	12.58	3.28	3.26
query30	0.25	0.06	0.05
query31	2.88	0.41	0.40
query32	3.24	0.49	0.48
query33	2.98	2.95	2.96
query34	15.42	4.24	4.27
query35	4.31	4.29	4.28
query36	0.68	0.48	0.49
query37	0.20	0.17	0.15
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.16	0.13	0.14
query41	0.10	0.04	0.04
query42	0.06	0.06	0.05
query43	0.04	0.05	0.04
Total cold run time: 107.39 s
Total hot run time: 30.12 s

…t` (apache#38413) 1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type 2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes

#38318 #38364 #38291 #38213 #38413

… empty (apache#38413) serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes backport apache#38413

… empty (#41438) serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes backport #38413

…t` (apache#38413) 1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type 2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes

eldenmoon added dev/2.1.x dev/3.0.x doing labels Jul 26, 2024

xiaokang reviewed Jul 28, 2024
View reviewed changes

Comment threadbe/src/vec/data_types/data_type_object.cpp
Comment threadbe/src/olap/rowset/segment_v2/segment_iterator.cpp

eldenmoon force-pushed the fix-rqg-0726 branch from 399c964 to 12472c3Compare July 29, 2024 02:32

eldenmoon force-pushed the fix-rqg-0726 branch 4 times, most recently from 4e283cc to 6084257Compare July 29, 2024 02:38

eldenmoon added the meta-change label Jul 29, 2024

eldenmoon force-pushed the fix-rqg-0726 branch from 6084257 to 91846c2Compare July 29, 2024 03:21

fix compability
13f1a64

eldenmoon force-pushed the fix-rqg-0726 branch from 91846c2 to 13f1a64Compare July 29, 2024 03:23

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 29, 2024

github-actionsBot added the reviewed label Jul 29, 2024

amorynan approved these changes Jul 30, 2024
View reviewed changes

eldenmoon merged commit 681583a into apache:masterJul 30, 2024

eldenmoon mentioned this pull request Jul 30, 2024
[Pick](Variant) pick some fix #38512
Merged

eldenmoon mentioned this pull request Jul 30, 2024
[Pick](Variant) pick some fix #38513
Merged

eldenmoon added dev/3.0.1-merged and removed dev/3.0.x doing labels Jul 30, 2024

eldenmoon added a commit that referenced this pull request Jul 30, 2024
[Pick](Variant) pick some fix (#38513)
70c308c
#38318 #38364 #38291 #38213 #38413

xiaokang pushed a commit that referenced this pull request Jul 31, 2024
[Pick](Variant) pick somefix#38413#38364(#38512)
aa9bdd7

xiaokang added dev/2.1.6-merged and removed dev/2.1.x labels Jul 31, 2024

eldenmoon mentioned this pull request Sep 28, 2024
[pick](Serde-2.1) fix variant serde may lost num_rows when subcolumns empty #41438
Merged

eldenmoon added dev/2.1.7-merged and removed dev/2.1.6-merged labels Oct 11, 2024

Uh oh!

Conversation

eldenmoon commented Jul 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Jul 26, 2024

Uh oh!

eldenmoon commented Jul 26, 2024

Uh oh!

github-actionsBot commented Jul 26, 2024

Uh oh!

doris-robot commented Jul 26, 2024

Uh oh!

doris-robot commented Jul 26, 2024

Uh oh!

doris-robot commented Jul 26, 2024

Uh oh!

Uh oh!

Uh oh!

eldenmoon commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

eldenmoon commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

github-actionsBot commented Jul 29, 2024

Uh oh!

amorynan left a comment

Choose a reason for hiding this comment

Uh oh!

eldenmoon commented Jul 30, 2024

Uh oh!

eldenmoon commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

doris-robot commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eldenmoon commented Jul 26, 2024•
edited
Loading