Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.9k
[Fix](Variant) check storage type before apply get_row_ranges_by_dict#38413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -29,6 +29,7 @@ | ||
| #include <utility> | ||
| #include <vector> | ||
| #include "agent/be_exec_version_manager.h" | ||
| #include "vec/columns/column_object.h" | ||
| #include "vec/common/assert_cast.h" | ||
| #include "vec/common/typeid_cast.h" | ||
| @@ -66,7 +67,6 @@ int64_t DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column, | ||
| if (is_nothing(type)) { | ||
| continue; | ||
| } | ||
| PColumnMeta column_meta_pb; | ||
| column_meta_pb.set_name(entry->path.get_path()); | ||
| type->to_pb_column_meta(&column_meta_pb); | ||
| @@ -78,6 +78,10 @@ int64_t DataTypeObject::get_uncompressed_serialized_bytes(const IColumn& column, | ||
| size += type->get_uncompressed_serialized_bytes(entry->data.get_finalized_column(), | ||
| be_exec_version); | ||
| } | ||
| // serialize num of rows, only take effect when subcolumns empty | ||
| if (be_exec_version >= VARIANT_SERDE) { | ||
| size += sizeof(uint32_t); | ||
| } | ||
| return size; | ||
| } | ||
| @@ -121,6 +125,11 @@ char* DataTypeObject::serialize(const IColumn& column, char* buf, int be_exec_ve | ||
| } | ||
| // serialize num of subcolumns | ||
| *reinterpret_cast<uint32_t*>(size_pos) = num_of_columns; | ||
| // serialize num of rows, only take effect when subcolumns empty | ||
| if (be_exec_version >= VARIANT_SERDE) { | ||
| *reinterpret_cast<uint32_t*>(buf) = column_object.rows(); | ||
xiaokang marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| buf += sizeof(uint32_t); | ||
| } | ||
| return buf; | ||
| } | ||
| @@ -155,6 +164,13 @@ const char* DataTypeObject::deserialize(const char* buf, IColumn* column, | ||
| } | ||
| column_object->add_sub_column(key, std::move(sub_column), type); | ||
| } | ||
| size_t num_rows = 0; | ||
| // serialize num of rows, only take effect when subcolumns empty | ||
| if (be_exec_version >= VARIANT_SERDE) { | ||
| num_rows = *reinterpret_cast<const uint32_t*>(buf); | ||
| column_object->set_num_rows(num_rows); | ||
| buf += sizeof(uint32_t); | ||
| } | ||
| column_object->finalize(); | ||
| #ifndef NDEBUG | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !rqg4 -- | ||
| 0 | ||
| -- !rqg4_2 -- | ||
| 500 | ||
| -- !rqg4_3 -- | ||
| 500 | ||
| -- !rqg4_4 -- | ||
| 70 | ||
| -- !rqg4_5 -- | ||
| 70 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !rqg5 -- | ||
| 0 | ||
| -- !rqg5_2 -- | ||
| 50 | ||
| -- !rqg5_3 -- | ||
| 50 | ||
| -- !rqg5_4 -- | ||
| 50 | ||
| -- !rqg5_5 -- | ||
| 50 | ||
| -- !rqg5_6 -- | ||
| 50 | ||
| -- !rqg5_7 -- | ||
| 0 | ||
| -- !rqg5_8 -- | ||
| 0 | ||
| -- !rqg5_9 -- | ||
| 50 | ||
| -- !rqg5_10 -- | ||
| 50 | ||
| -- !rqg5_11 -- | ||
| 50 | ||
| -- !rqg5_12 -- | ||
| 50 | ||
| -- !rqg5_13 -- | ||
| 50 | ||
| -- !rqg5_14 -- | ||
| 50 | ||
| -- !rqg5_15 -- | ||
| 0 | ||
| -- !rqg5_16 -- | ||
| 100 | ||
| -- !rqg5_17 -- | ||
| 100 | ||
| -- !rqg5_18 -- | ||
| 100 | ||
| -- !rqg5_19 -- | ||
| 100 | ||
| -- !rqg5_20 -- | ||
| 100 | ||
| -- !rqg5_21 -- | ||
| 100 | ||
| -- !rqg5_22 -- | ||
| 0 | ||
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.