Uh oh!
There was an error while loading. Please reload this page.
[opt](nereids) reimplement or-to-in rule - #41222
Merged
Merged
Conversation
doris-robot
commented
Sep 24, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
englefly
commented
Sep 24, 2024
ContributorAuthor
run buildall |
englefly
marked this pull request as draft
September 24, 2024 10:07
englefly
commented
Sep 24, 2024
ContributorAuthor
run buildall |
engleflyforce-pushed
the
or-in-nereids
branch
from
September 25, 2024 01:19
a270919 to
8fb3963Compareenglefly
commented
Sep 25, 2024
ContributorAuthor
run buildall |
2 similar comments
englefly
commented
Sep 25, 2024
ContributorAuthor
run buildall |
englefly
commented
Sep 26, 2024
ContributorAuthor
run buildall |
engleflyforce-pushed
the
or-in-nereids
branch
from
September 27, 2024 12:24
81883be to
7095de9Compareenglefly
commented
Sep 27, 2024
ContributorAuthor
run buildall |
englefly
marked this pull request as ready for review
September 27, 2024 12:36
englefly
commented
Sep 27, 2024
ContributorAuthor
run p0 |
starocean999
approved these changes
Sep 29, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
LiBinfeng-01
approved these changes
Sep 29, 2024
dataroaring pushed a commit
that referenced
this pull request
Oct 9, 2024
## Proposed changes make or-to-in rule apply to more patterns Issue Number: close #xxx <!--Describe your changes.-->
cjj2010 pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
## Proposed changes make or-to-in rule apply to more patterns Issue Number: close #xxx <!--Describe your changes.-->
amorynan pushed a commit
to amorynan/doris
that referenced
this pull request
Oct 12, 2024
## Proposed changes make or-to-in rule apply to more patterns Issue Number: close #xxx <!--Describe your changes.-->
englefly added a commit
that referenced
this pull request
Oct 15, 2024
intro by #41222 [bug] OrToIn Rule set state flag in Or expression to avoid repeatedly process the same expression. But SimplifyRange Rule may remove this flag, and hence OrToIn and SimplifyRange Rules go into dead loop. [fix] if the input expression and output expression of SimplifyRange Rule are the same, SimplifyRange will return input expression to keep expression state.
englefly added a commit
to englefly/incubator-doris
that referenced
this pull request
Oct 17, 2024
This reverts commit cfe1506.
englefly added a commit
to englefly/incubator-doris
that referenced
this pull request
Oct 22, 2024
This reverts commit 13df1be.
englefly added a commit
that referenced
this pull request
Oct 22, 2024
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
## Proposed changes make or-to-in rule apply to more patterns Issue Number: close #xxx <!--Describe your changes.-->
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
intro by apache#41222 [bug] OrToIn Rule set state flag in Or expression to avoid repeatedly process the same expression. But SimplifyRange Rule may remove this flag, and hence OrToIn and SimplifyRange Rules go into dead loop. [fix] if the input expression and output expression of SimplifyRange Rule are the same, SimplifyRange will return input expression to keep expression state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
make or-to-in rule apply to more patterns
Issue Number: close #xxx