[opt](nereids) infer in-predicate from or-predicate by englefly · Pull Request #46468 · apache/doris

englefly · 2025-01-06T09:56:50Z

What problem does this PR solve?

previous verion has follow drawbacks

inferred some in-predicates, which cannot be pushed down to storage layer
it is easy to lead dead loop, because other expression rewrite rule may remove its flag in expression's mutableState

in order to solve above issues, we implemented a new version
first, it is a plan node level rule to avoid to be applied to the same expression repeatedly
second, we define replace mode and extract mode. if in replace mode, the original expression should be equivalent to the inferred in-pred, which is used for all plan node's expressions except filter.

for example, orig = "(a=1 and b=1) or (a=2 and c=2)" is equivalent to "a in (1, 2) and (a=1 and b=1) or (a=2 and c=2)".
orig is a filter condition, "a in (1, 2)" can be pushed down to storage layer, and this infer is useful. But if this is orig is an other join condition, this inferrence is useless. So in extract mode, "a in (1, 2)" is inferred, but in replace mode, it is not.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-01-06T09:56:55Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

englefly · 2025-01-06T09:57:01Z

run buildall

doris-robot · 2025-01-06T10:19:03Z

TPC-H: Total hot run time: 32462 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f67c7b303ba2da58f7f5534733f595b8bdc9362b, data reload: false
------ Round 1 ----------------------------------
q1	17586	6882	6051	6051
q2	2049	293	164	164
q3	10442	1237	698	698
q4	10210	845	425	425
q5	7512	2142	1964	1964
q6	200	177	151	151
q7	898	735	608	608
q8	9214	1317	1098	1098
q9	5103	4881	4899	4881
q10	6730	2290	1843	1843
q11	489	275	280	275
q12	352	392	225	225
q13	17764	3627	3048	3048
q14	238	232	218	218
q15	563	505	495	495
q16	629	593	610	593
q17	554	838	323	323
q18	7063	6534	6365	6365
q19	1204	936	528	528
q20	301	321	191	191
q21	2876	2198	2004	2004
q22	359	338	314	314
Total cold run time: 102336 ms
Total hot run time: 32462 ms
----- Round 2, with runtime_filter_mode=off -----
q1	6287	6208	6237	6208
q2	233	322	229	229
q3	2268	2680	2275	2275
q4	1415	1868	1363	1363
q5	4348	4722	4773	4722
q6	188	180	142	142
q7	2044	1982	1871	1871
q8	2610	2735	2626	2626
q9	7192	7171	7186	7171
q10	3039	3340	2796	2796
q11	592	509	486	486
q12	705	758	620	620
q13	3501	3912	3207	3207
q14	304	302	288	288
q15	577	531	518	518
q16	659	711	637	637
q17	1189	1721	1239	1239
q18	7770	7351	7165	7165
q19	754	979	1054	979
q20	1916	1952	1796	1796
q21	5391	5067	4754	4754
q22	624	604	573	573
Total cold run time: 53606 ms
Total hot run time: 51665 ms

doris-robot · 2025-01-06T10:31:09Z

TPC-DS: Total hot run time: 190911 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f67c7b303ba2da58f7f5534733f595b8bdc9362b, data reload: false
query1	984	378	364	364
query2	6518	2286	2349	2286
query3	6707	214	215	214
query4	34058	23937	23458	23458
query5	4379	620	492	492
query6	287	200	175	175
query7	4621	488	309	309
query8	303	248	241	241
query9	9536	2667	2654	2654
query10	486	308	248	248
query11	18098	15433	15269	15269
query12	161	112	113	112
query13	1636	524	390	390
query14	10330	7451	7458	7451
query15	248	204	182	182
query16	8221	590	433	433
query17	1598	783	569	569
query18	2094	409	338	338
query19	206	185	145	145
query20	116	120	109	109
query21	211	124	103	103
query22	4411	4338	4276	4276
query23	34153	33289	34967	33289
query24	7125	2367	2277	2277
query25	477	450	390	390
query26	1120	274	151	151
query27	2033	446	338	338
query28	5100	2454	2423	2423
query29	555	534	419	419
query30	227	177	152	152
query31	1008	884	838	838
query32	80	59	58	58
query33	502	347	328	328
query34	742	824	496	496
query35	788	833	743	743
query36	1025	1059	960	960
query37	124	106	72	72
query38	4229	4120	4238	4120
query39	1504	1431	1430	1430
query40	208	120	98	98
query41	48	45	47	45
query42	118	108	103	103
query43	510	523	473	473
query44	1281	806	795	795
query45	181	179	168	168
query46	858	1029	659	659
query47	1900	1900	1843	1843
query48	368	392	319	319
query49	800	497	387	387
query50	636	660	388	388
query51	7228	7050	6930	6930
query52	104	103	93	93
query53	225	252	184	184
query54	464	488	409	409
query55	89	84	78	78
query56	255	275	255	255
query57	1207	1194	1137	1137
query58	241	228	236	228
query59	2949	3058	2981	2981
query60	273	265	262	262
query61	112	107	113	107
query62	844	808	738	738
query63	240	187	189	187
query64	4377	1018	673	673
query65	3272	3213	3260	3213
query66	857	438	298	298
query67	16034	15725	15508	15508
query68	8393	701	520	520
query69	446	294	256	256
query70	1220	1146	1067	1067
query71	441	286	269	269
query72	6167	3826	3885	3826
query73	658	748	356	356
query74	10367	8995	9160	8995
query75	4209	3158	2665	2665
query76	3740	1171	783	783
query77	772	377	278	278
query78	10285	10096	9647	9647
query79	4045	783	590	590
query80	728	539	441	441
query81	494	272	238	238
query82	581	155	121	121
query83	194	182	153	153
query84	288	97	139	97
query85	773	369	309	309
query86	347	316	305	305
query87	4726	4650	4496	4496
query88	4260	2174	2145	2145
query89	415	328	304	304
query90	1901	249	188	188
query91	136	144	105	105
query92	69	56	59	56
query93	1948	818	528	528
query94	648	395	306	306
query95	334	265	261	261
query96	485	611	274	274
query97	2836	3029	2817	2817
query98	233	203	212	203
query99	1684	1585	1451	1451
Total cold run time: 295503 ms
Total hot run time: 190911 ms

doris-robot · 2025-01-06T10:36:28Z

ClickBench: Total hot run time: 31.09 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f67c7b303ba2da58f7f5534733f595b8bdc9362b, data reload: false
query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.60	0.11	0.10
query5	0.43	0.41	0.41
query6	1.18	0.65	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.58	0.51	0.51
query10	0.56	0.57	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.59
query14	2.70	2.69	2.75
query15	0.90	0.83	0.82
query16	0.38	0.38	0.38
query17	1.07	1.08	1.07
query18	0.23	0.20	0.22
query19	1.88	1.85	1.98
query20	0.02	0.01	0.01
query21	15.39	0.90	0.59
query22	0.75	0.87	0.64
query23	15.25	1.46	0.51
query24	3.62	0.85	0.67
query25	0.10	0.10	0.19
query26	0.42	0.16	0.13
query27	0.06	0.04	0.05
query28	12.75	1.62	1.05
query29	12.58	4.00	3.25
query30	0.25	0.09	0.06
query31	2.82	0.63	0.38
query32	3.23	0.55	0.47
query33	3.08	3.14	3.17
query34	16.91	5.16	4.53
query35	4.56	4.52	4.52
query36	0.76	0.49	0.48
query37	0.10	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 105.87 s
Total hot run time: 31.09 s

englefly · 2025-01-07T06:53:08Z

run buildall

doris-robot · 2025-01-07T08:37:43Z

TPC-H: Total hot run time: 32809 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 46a6653bec41960ffa892436e3bf15f2032cf72c, data reload: false
------ Round 1 ----------------------------------
q1	17584	6140	6054	6054
q2	2046	317	177	177
q3	10404	1277	752	752
q4	10204	879	437	437
q5	7881	2242	2023	2023
q6	205	186	152	152
q7	904	752	610	610
q8	9231	1404	1198	1198
q9	5286	5006	5014	5006
q10	6794	2334	1870	1870
q11	473	286	270	270
q12	346	356	222	222
q13	17754	3661	3011	3011
q14	241	224	215	215
q15	568	528	493	493
q16	637	630	596	596
q17	597	871	345	345
q18	7230	6316	6482	6316
q19	1762	947	534	534
q20	315	325	200	200
q21	2876	2221	2015	2015
q22	362	344	313	313
Total cold run time: 103700 ms
Total hot run time: 32809 ms
----- Round 2, with runtime_filter_mode=off -----
q1	6324	6264	6203	6203
q2	243	328	230	230
q3	2243	2643	2282	2282
q4	1460	1850	1375	1375
q5	4347	4847	4848	4847
q6	181	176	142	142
q7	2049	1937	1781	1781
q8	2630	2849	2731	2731
q9	7312	7318	7364	7318
q10	3088	3364	2871	2871
q11	588	511	489	489
q12	664	727	578	578
q13	3540	3931	3258	3258
q14	275	294	290	290
q15	584	544	503	503
q16	641	694	654	654
q17	1249	1749	1247	1247
q18	7705	7561	7269	7269
q19	784	947	1171	947
q20	1994	2039	1926	1926
q21	5717	5313	4891	4891
q22	653	628	619	619
Total cold run time: 54271 ms
Total hot run time: 52451 ms

doris-robot · 2025-01-07T08:50:05Z

TPC-DS: Total hot run time: 197193 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 46a6653bec41960ffa892436e3bf15f2032cf72c, data reload: false
query1	1313	969	926	926
query2	6474	2392	2297	2297
query3	10996	4585	4635	4585
query4	33178	23902	23997	23902
query5	4716	628	465	465
query6	296	204	192	192
query7	3990	487	305	305
query8	310	247	244	244
query9	9489	2777	2764	2764
query10	481	306	243	243
query11	18304	15594	15232	15232
query12	158	113	98	98
query13	1532	519	382	382
query14	10120	6819	6975	6819
query15	239	215	191	191
query16	7998	591	428	428
query17	1493	743	588	588
query18	2129	427	316	316
query19	205	214	184	184
query20	136	126	118	118
query21	229	134	115	115
query22	4832	4651	4502	4502
query23	35193	33821	34588	33821
query24	7177	2445	2320	2320
query25	517	490	438	438
query26	756	273	154	154
query27	2125	476	339	339
query28	5389	2535	2481	2481
query29	545	542	420	420
query30	216	183	147	147
query31	987	910	858	858
query32	74	55	57	55
query33	483	352	296	296
query34	759	877	518	518
query35	819	874	741	741
query36	1054	1037	942	942
query37	118	105	72	72
query38	4324	4357	4095	4095
query39	1555	1483	1467	1467
query40	211	121	113	113
query41	45	46	44	44
query42	122	105	105	105
query43	527	515	496	496
query44	1423	866	832	832
query45	189	176	166	166
query46	903	1103	664	664
query47	2040	2021	1924	1924
query48	389	413	332	332
query49	710	488	403	403
query50	647	663	414	414
query51	7164	7141	7017	7017
query52	103	97	91	91
query53	225	258	191	191
query54	475	502	412	412
query55	88	76	80	76
query56	251	266	250	250
query57	1248	1225	1197	1197
query58	235	236	229	229
query59	3238	3314	3116	3116
query60	281	275	259	259
query61	110	144	105	105
query62	862	845	763	763
query63	235	191	191	191
query64	3485	1056	643	643
query65	3343	3297	3256	3256
query66	785	416	313	313
query67	16671	15894	15609	15609
query68	8722	708	512	512
query69	474	282	258	258
query70	1216	1145	1146	1145
query71	427	282	265	265
query72	6424	3905	3875	3875
query73	649	764	379	379
query74	10380	9168	8846	8846
query75	3968	3241	2670	2670
query76	3640	1191	785	785
query77	762	352	289	289
query78	10260	10129	9708	9708
query79	3524	796	584	584
query80	739	533	420	420
query81	485	281	237	237
query82	574	150	119	119
query83	186	162	145	145
query84	279	92	86	86
query85	772	350	289	289
query86	351	320	303	303
query87	4777	4457	4396	4396
query88	4112	2197	2187	2187
query89	434	329	303	303
query90	1834	187	185	185
query91	133	139	103	103
query92	67	55	51	51
query93	1231	867	529	529
query94	641	381	281	281
query95	324	264	257	257
query96	478	612	275	275
query97	2901	2968	2801	2801
query98	244	208	197	197
query99	1754	1558	1442	1442
Total cold run time: 299476 ms
Total hot run time: 197193 ms

doris-robot · 2025-01-07T08:55:26Z

ClickBench: Total hot run time: 31.16 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 46a6653bec41960ffa892436e3bf15f2032cf72c, data reload: false
query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.43	0.43	0.43
query6	1.13	0.64	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.61	0.49	0.50
query10	0.56	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.60	0.60
query14	2.84	2.74	2.75
query15	0.89	0.84	0.81
query16	0.38	0.36	0.38
query17	1.07	1.09	1.05
query18	0.22	0.20	0.21
query19	1.94	1.86	1.99
query20	0.02	0.00	0.01
query21	15.38	0.89	0.56
query22	0.76	0.83	0.65
query23	15.30	1.48	0.51
query24	3.25	1.72	0.96
query25	0.27	0.13	0.08
query26	0.27	0.14	0.14
query27	0.06	0.05	0.05
query28	13.48	1.51	1.04
query29	12.63	4.01	3.34
query30	0.26	0.09	0.06
query31	2.83	0.59	0.38
query32	3.23	0.54	0.46
query33	3.18	3.05	3.08
query34	16.78	5.15	4.44
query35	4.48	4.43	4.50
query36	0.83	0.48	0.48
query37	0.10	0.07	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.49 s
Total hot run time: 31.16 s

englefly · 2025-01-08T01:38:22Z

run p0

github-actions · 2025-01-08T03:14:31Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-01-08T03:14:33Z

PR approved by anyone and no changes requested.

englefly · 2025-01-08T06:14:52Z

run buildall

englefly · 2025-01-08T06:30:26Z

run buildall

yujun777

LGTM

doris-robot · 2025-01-08T07:04:52Z

TPC-H: Total hot run time: 32843 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2380de9408d4513bb667056d8cb0e04a29af4da6, data reload: false
------ Round 1 ----------------------------------
q1	17659	6179	6140	6140
q2	2353	325	180	180
q3	10394	1232	768	768
q4	10480	888	459	459
q5	8462	2161	2047	2047
q6	212	186	149	149
q7	886	757	609	609
q8	9236	1362	1214	1214
q9	5171	4847	4866	4847
q10	6800	2326	1845	1845
q11	488	275	261	261
q12	350	375	231	231
q13	17768	3623	3033	3033
q14	239	237	218	218
q15	566	503	495	495
q16	628	635	607	607
q17	569	861	326	326
q18	6958	6340	6418	6340
q19	2027	954	569	569
q20	312	332	201	201
q21	2835	2256	1994	1994
q22	361	337	310	310
Total cold run time: 104754 ms
Total hot run time: 32843 ms
----- Round 2, with runtime_filter_mode=off -----
q1	6345	6225	6221	6221
q2	239	329	230	230
q3	2264	2688	2346	2346
q4	1455	1803	1426	1426
q5	4300	4709	4871	4709
q6	189	174	146	146
q7	2116	2020	1853	1853
q8	2672	2780	2699	2699
q9	7247	7225	7264	7225
q10	3031	3355	2804	2804
q11	582	506	495	495
q12	669	793	659	659
q13	3522	3931	3320	3320
q14	286	297	296	296
q15	564	515	522	515
q16	642	707	642	642
q17	1239	1757	1244	1244
q18	7734	7594	7308	7308
q19	876	1192	1134	1134
q20	2056	2026	1869	1869
q21	5693	5195	4937	4937
q22	639	632	599	599
Total cold run time: 54360 ms
Total hot run time: 52677 ms

doris-robot · 2025-01-08T07:17:04Z

TPC-DS: Total hot run time: 194895 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2380de9408d4513bb667056d8cb0e04a29af4da6, data reload: false
query1	1300	954	918	918
query2	6397	2296	2237	2237
query3	10940	4592	4585	4585
query4	32846	23670	23171	23171
query5	4250	589	445	445
query6	300	201	189	189
query7	3972	483	306	306
query8	296	252	232	232
query9	9497	2743	2743	2743
query10	472	295	246	246
query11	17810	15228	14981	14981
query12	155	104	103	103
query13	1550	530	391	391
query14	9848	7043	7118	7043
query15	250	208	192	192
query16	8092	613	457	457
query17	1568	779	611	611
query18	2153	416	326	326
query19	199	194	161	161
query20	124	125	114	114
query21	203	116	105	105
query22	4493	4478	4437	4437
query23	34631	33686	33448	33448
query24	6462	2306	2290	2290
query25	507	447	377	377
query26	729	270	145	145
query27	2031	490	329	329
query28	5308	2508	2524	2508
query29	654	556	437	437
query30	213	181	146	146
query31	953	878	826	826
query32	78	66	57	57
query33	476	348	302	302
query34	767	863	520	520
query35	809	832	723	723
query36	999	1010	943	943
query37	118	100	79	79
query38	4244	4112	4077	4077
query39	1513	1440	1476	1440
query40	199	109	101	101
query41	46	43	46	43
query42	125	108	99	99
query43	520	521	501	501
query44	1376	874	860	860
query45	195	164	172	164
query46	881	1051	662	662
query47	1960	1907	1882	1882
query48	388	408	332	332
query49	712	485	388	388
query50	637	657	404	404
query51	7042	7078	6838	6838
query52	104	95	93	93
query53	226	249	179	179
query54	484	485	414	414
query55	83	87	86	86
query56	265	267	257	257
query57	1242	1210	1132	1132
query58	242	226	235	226
query59	3365	3399	3306	3306
query60	283	267	271	267
query61	108	114	122	114
query62	894	801	748	748
query63	227	189	194	189
query64	3248	1028	657	657
query65	3314	3200	3230	3200
query66	780	410	346	346
query67	16370	15908	15545	15545
query68	8789	702	512	512
query69	482	288	243	243
query70	1181	1121	1144	1121
query71	427	294	258	258
query72	6543	3855	3908	3855
query73	658	750	362	362
query74	9940	9164	8709	8709
query75	3960	3112	2648	2648
query76	3618	1180	767	767
query77	780	364	280	280
query78	10062	9984	9377	9377
query79	3611	802	582	582
query80	724	519	477	477
query81	481	264	218	218
query82	636	155	122	122
query83	188	155	138	138
query84	280	99	73	73
query85	780	352	295	295
query86	347	302	303	302
query87	4518	4330	4402	4330
query88	4300	2159	2144	2144
query89	414	327	285	285
query90	1812	184	183	183
query91	134	132	105	105
query92	64	55	52	52
query93	1228	841	530	530
query94	648	391	278	278
query95	335	252	251	251
query96	482	608	280	280
query97	2852	2974	2826	2826
query98	226	199	198	198
query99	1625	1492	1421	1421
Total cold run time: 294648 ms
Total hot run time: 194895 ms

doris-robot · 2025-01-08T07:22:25Z

ClickBench: Total hot run time: 32.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2380de9408d4513bb667056d8cb0e04a29af4da6, data reload: false
query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.42	0.41	0.41
query6	1.17	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.51	0.51
query10	0.56	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.58	0.60
query14	2.85	2.88	2.71
query15	0.89	0.85	0.84
query16	0.39	0.39	0.38
query17	1.07	1.03	1.03
query18	0.22	0.20	0.20
query19	1.98	1.88	1.98
query20	0.02	0.01	0.02
query21	15.39	0.92	0.58
query22	0.76	0.84	0.75
query23	15.12	1.42	0.57
query24	2.92	1.58	1.81
query25	0.18	0.19	0.18
query26	0.21	0.15	0.14
query27	0.08	0.05	0.04
query28	14.37	1.46	1.04
query29	12.60	3.83	3.21
query30	0.25	0.09	0.07
query31	2.84	0.58	0.38
query32	3.23	0.55	0.46
query33	3.15	3.10	3.13
query34	16.95	5.11	4.55
query35	4.49	4.48	4.49
query36	0.83	0.49	0.49
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.91 s
Total hot run time: 32.15 s

englefly · 2025-01-08T09:51:21Z

run p0

englefly · 2025-01-08T09:51:28Z

run cloud_p0

englefly · 2025-01-08T13:39:26Z

run p0

englefly · 2025-01-08T14:56:27Z

run p0

englefly · 2025-01-09T02:21:59Z

run p0

englefly · 2025-01-09T02:25:46Z

run buildall

doris-robot · 2025-01-09T03:05:59Z

TPC-H: Total hot run time: 33323 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7d4457ae9114f2c913c9d984935a0b21b2036b59, data reload: false
------ Round 1 ----------------------------------
q1	17598	6239	6095	6095
q2	2054	305	165	165
q3	10690	1291	755	755
q4	10442	866	440	440
q5	8246	2206	1982	1982
q6	210	184	149	149
q7	904	751	617	617
q8	10806	1356	1186	1186
q9	5225	4853	4841	4841
q10	6796	2321	1880	1880
q11	480	283	262	262
q12	351	372	229	229
q13	18896	4031	3323	3323
q14	256	248	237	237
q15	578	512	524	512
q16	659	644	622	622
q17	574	867	341	341
q18	8534	7024	6489	6489
q19	4820	1108	642	642
q20	302	316	191	191
q21	2937	2300	2056	2056
q22	376	348	309	309
Total cold run time: 111734 ms
Total hot run time: 33323 ms
----- Round 2, with runtime_filter_mode=off -----
q1	6497	6259	6247	6247
q2	237	326	234	234
q3	2249	2627	2336	2336
q4	1413	1784	1350	1350
q5	4501	4983	4973	4973
q6	182	175	142	142
q7	2088	1960	1835	1835
q8	2657	2808	2650	2650
q9	7370	7247	7126	7126
q10	3053	3400	2857	2857
q11	581	515	494	494
q12	700	764	622	622
q13	3524	3964	3206	3206
q14	292	322	281	281
q15	594	514	508	508
q16	681	694	651	651
q17	1206	1746	1255	1255
q18	7724	7600	7412	7412
q19	820	1167	1080	1080
q20	1996	2001	1910	1910
q21	5615	5191	5076	5076
q22	634	623	597	597
Total cold run time: 54614 ms
Total hot run time: 52842 ms

doris-robot · 2025-01-09T03:18:10Z

TPC-DS: Total hot run time: 194787 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7d4457ae9114f2c913c9d984935a0b21b2036b59, data reload: false
query1	1330	938	919	919
query2	6390	2340	2349	2340
query3	10959	4686	4662	4662
query4	33189	23553	23233	23233
query5	4399	610	457	457
query6	290	211	190	190
query7	3983	495	301	301
query8	306	268	241	241
query9	9687	2648	2657	2648
query10	485	320	247	247
query11	17844	15475	15096	15096
query12	159	111	108	108
query13	1653	521	402	402
query14	10616	7546	6749	6749
query15	235	208	199	199
query16	7776	647	473	473
query17	1602	808	604	604
query18	2068	465	325	325
query19	214	196	159	159
query20	128	113	113	113
query21	196	126	108	108
query22	4518	4430	4439	4430
query23	34045	33105	33093	33093
query24	6273	2299	2272	2272
query25	478	464	400	400
query26	818	279	148	148
query27	2153	472	333	333
query28	5464	2474	2463	2463
query29	555	567	462	462
query30	211	184	148	148
query31	964	887	808	808
query32	64	60	55	55
query33	489	346	315	315
query34	739	824	515	515
query35	842	874	769	769
query36	984	1030	980	980
query37	115	103	79	79
query38	4279	4230	4227	4227
query39	1498	1505	1466	1466
query40	203	115	97	97
query41	46	48	43	43
query42	125	102	106	102
query43	547	533	506	506
query44	1355	825	824	824
query45	185	171	164	164
query46	897	1084	659	659
query47	1883	1908	1828	1828
query48	367	394	320	320
query49	725	472	403	403
query50	683	672	392	392
query51	6999	7004	7054	7004
query52	104	105	99	99
query53	235	253	186	186
query54	511	501	405	405
query55	84	81	82	81
query56	261	270	239	239
query57	1238	1217	1157	1157
query58	237	223	225	223
query59	3205	3245	3381	3245
query60	276	276	263	263
query61	114	109	108	108
query62	862	814	748	748
query63	226	187	193	187
query64	2775	1024	675	675
query65	3349	3229	3322	3229
query66	763	456	312	312
query67	16325	15614	15299	15299
query68	7866	715	515	515
query69	487	278	252	252
query70	1246	1141	1088	1088
query71	439	287	257	257
query72	6217	3855	3984	3855
query73	657	752	360	360
query74	9854	9222	9049	9049
query75	4079	3138	2668	2668
query76	3711	1192	770	770
query77	754	378	268	268
query78	10065	10105	9393	9393
query79	3713	812	583	583
query80	756	567	437	437
query81	490	266	233	233
query82	598	147	120	120
query83	205	171	142	142
query84	279	91	75	75
query85	774	343	318	318
query86	346	308	297	297
query87	4308	4361	4366	4361
query88	3190	2147	2123	2123
query89	449	311	294	294
query90	2002	187	185	185
query91	128	139	106	106
query92	66	58	51	51
query93	2120	847	529	529
query94	665	383	256	256
query95	333	255	255	255
query96	476	606	273	273
query97	2888	2884	2798	2798
query98	222	199	199	199
query99	1731	1508	1342	1342
Total cold run time: 293692 ms
Total hot run time: 194787 ms

doris-robot · 2025-01-09T03:23:31Z

ClickBench: Total hot run time: 31.37 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7d4457ae9114f2c913c9d984935a0b21b2036b59, data reload: false
query1	0.03	0.03	0.05
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.42	0.42	0.41
query6	1.18	0.66	0.66
query7	0.02	0.01	0.01
query8	0.05	0.03	0.03
query9	0.60	0.51	0.49
query10	0.56	0.56	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.12
query13	0.61	0.60	0.59
query14	2.81	2.84	2.76
query15	0.89	0.82	0.82
query16	0.39	0.39	0.37
query17	0.99	1.00	1.02
query18	0.23	0.21	0.21
query19	1.94	1.80	1.97
query20	0.01	0.01	0.01
query21	15.38	0.93	0.58
query22	0.76	0.79	0.71
query23	15.23	1.47	0.51
query24	3.92	1.65	1.16
query25	0.16	0.08	0.19
query26	0.22	0.14	0.13
query27	0.06	0.05	0.05
query28	14.23	1.47	1.04
query29	12.58	3.95	3.26
query30	0.27	0.10	0.06
query31	2.82	0.60	0.38
query32	3.23	0.56	0.46
query33	3.03	3.08	3.17
query34	16.96	5.06	4.49
query35	4.49	4.47	4.42
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.42 s
Total hot run time: 31.37 s

github-actions · 2025-01-09T07:15:40Z

PR approved by at least one committer and no changes requested.

yujun777

LGTM

pick #41222 #46468 #44574 #48034 #50265 #47385

infer in-pred from or
f67c7b3

englefly added 2 commits January 7, 2025 14:29

and one child
a74f3ad

filter condition
46a6653

starocean999 previously approved these changes Jan 8, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 8, 2025

github-actionsBot added the reviewed label Jan 8, 2025

yujun777 reviewed Jan 8, 2025
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/OrToIn.java

remove ExpressionRuleType.OR_TO_IN
2ce1257

englefly dismissed starocean999’s stale review via 2ce1257January 8, 2025 06:14

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jan 8, 2025

yujun777 reviewed Jan 8, 2025
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/OrToIn.java Outdated

dedup
2380de9

ff
7d4457a

yujun777 approved these changes Jan 8, 2025
View reviewed changes

yujun777 self-requested a review January 8, 2025 06:58

starocean999 approved these changes Jan 9, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2025

yujun777 approved these changes Jan 9, 2025
View reviewed changes

englefly merged commit af8a975 into apache:masterJan 9, 2025

englefly deleted the orToInV3 branch January 9, 2025 07:19

morrySnow added the dev/3.1.x label Feb 11, 2025

englefly mentioned this pull request Jun 19, 2025
branch-3.1: [opt](nereids) infer in-predicate from or-predicate (#46468) #51869
Merged

morrySnow added dev/3.1.x and removed dev/3.1.x labels Jun 19, 2025

github-actionsBot added the dev/3.1.x-conflict label Jun 19, 2025

morrySnow pushed a commit that referenced this pull request Jun 20, 2025
branch-3.1: [opt](nereids) infer in-predicate from or-predicate (#51869)
622e21e
pick #41222 #46468 #44574 #48034 #50265 #47385

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jun 20, 2025

Uh oh!

Conversation

englefly commented Jan 6, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jan 6, 2025

Uh oh!

englefly commented Jan 6, 2025

Uh oh!

doris-robot commented Jan 6, 2025

Uh oh!

doris-robot commented Jan 6, 2025

Uh oh!

doris-robot commented Jan 6, 2025

Uh oh!

englefly commented Jan 7, 2025

Uh oh!

doris-robot commented Jan 7, 2025

Uh oh!

doris-robot commented Jan 7, 2025

Uh oh!

doris-robot commented Jan 7, 2025

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

github-actionsBot commented Jan 8, 2025

Uh oh!

github-actionsBot commented Jan 8, 2025

Uh oh!

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

yujun777 left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Jan 8, 2025

Uh oh!

doris-robot commented Jan 8, 2025

Uh oh!

doris-robot commented Jan 8, 2025

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

englefly commented Jan 8, 2025

Uh oh!

englefly commented Jan 9, 2025

Uh oh!

englefly commented Jan 9, 2025

Uh oh!

doris-robot commented Jan 9, 2025

Uh oh!

doris-robot commented Jan 9, 2025

Uh oh!

doris-robot commented Jan 9, 2025

Uh oh!

github-actionsBot commented Jan 9, 2025

Uh oh!

yujun777 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants