Skip to content

[Improvement](shuffle) Reduce memory consumption in data stream sender - #41676

Merged
Gabriel39 merged 2 commits into
apache:masterfrom
Gabriel39:opt_1010
Oct 11, 2024
Merged

[Improvement](shuffle) Reduce memory consumption in data stream sender#41676
Gabriel39 merged 2 commits into
apache:masterfrom
Gabriel39:opt_1010

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Before:
image
image

After:
image

@doris-robot

doris-robot commented Oct 10, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39

Gabriel39 commented Oct 10, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Oct 10, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/runtime/vdata_stream_recvr.cpp Outdated
}

void VDataStreamRecvr::add_block(Block* block, int sender_id, bool use_move) {
void VDataStreamRecvr::add_block(Block* block, int sender_id) {

@github-actionsgithub-actionsBotOct 10, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: method 'add_block' can be made const [readability-make-member-function-const]

Suggested change
voidVDataStreamRecvr::add_block(Block* block, int sender_id) {
voidVDataStreamRecvr::add_block(Block* block, int sender_id) const{

be/src/vec/runtime/vdata_stream_recvr.h:88:

- void add_block(Block* block, int sender_id);+ void add_block(Block* block, int sender_id) const;

@doris-robot

doris-robot commented Oct 10, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.41% (9661/25825)
Line Coverage: 28.69% (80175/279456)
Region Coverage: 28.12% (41447/147402)
Branch Coverage: 24.72% (21107/85390)
Coverage Report: http://coverage.selectdb-in.cc/coverage/656146a35845ffad277388df9735524395cfa526_656146a35845ffad277388df9735524395cfa526/report/index.html

HappenLee
HappenLee previously approved these changes Oct 11, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39

Gabriel39 commented Oct 11, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.40% (9660/25827)
Line Coverage: 28.67% (80136/279497)
Region Coverage: 28.11% (41445/147457)
Branch Coverage: 24.71% (21105/85420)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bd85447159141deb697f2958cef258a369b49b0e_bd85447159141deb697f2958cef258a369b49b0e/report/index.html

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2024
@github-actions

github-actionsBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@Gabriel39
Gabriel39 merged commit af95818 into apache:masterOct 11, 2024
@Gabriel39Gabriel39 mentioned this pull request Oct 12, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 12, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (#41740)
cce5425
Follow-up for #41676
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 14, 2024
@Gabriel39
[Improvement](shuffle) Reduce memory consumption in data stream sender (
227cc8c
apache#41676)
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 14, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
4be7ee5
)
Follow-up for apache#41676
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 14, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
58c9653
)
Follow-up for apache#41676
dataroaring pushed a commit that referenced this pull request Oct 15, 2024
@Gabriel39
[pick](branch-3.0) pick#39982#40576#41555#41592#41676#41740(#4…
54b4fa3
…1808)
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 15, 2024
@Gabriel39
[Improvement](shuffle) Reduce memory consumption in data stream sender (
43bb8b1
apache#41676)
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 15, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
e90a846
)
Follow-up for apache#41676
@Gabriel39Gabriel39 mentioned this pull request Oct 15, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 15, 2024
@Gabriel39
[pick](branch-2.1) pick#41676#41740#41857(#41904)
b185dfc
pick #41676#41740#41857
qzsee pushed a commit to qzsee/incubator-doris that referenced this pull request Oct 16, 2024
@Gabriel39garenshi
[followup](memory) Block should be moved by hash shuffling (apache#41740
272a8ae
)
Follow-up for apache#41676
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Gabriel39@HappenLee
[Improvement](shuffle) Reduce memory consumption in data stream sender (
88f2311
apache#41676)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Gabriel39@HappenLee
[followup](memory) Block should be moved by hash shuffling (apache#41740
85f2246
)
Follow-up for apache#41676
@Gabriel39
Gabriel39 deleted the opt_1010 branch July 30, 2026 06:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt approved these changes
@MryangeMryangeMryange approved these changes
@HappenLeeHappenLeeHappenLee left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gabriel39@doris-robot@BiteTheDDDDt@HappenLee@Mryange