[Enhancement](MS) Add fix tablet data size api for meta service by Yukang-Lian · Pull Request #41782 · apache/doris

Yukang-Lian · 2024-10-14T02:58:47Z

Proposed changes

Issue Number: close #xxx

doris-robot · 2024-10-14T02:58:51Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Yukang-Lian · 2024-10-14T03:01:43Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-21T06:41:12Z

 return {code, std::move(msg)};
 }

+MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str,


warning: function 'fix_tablet_stats' has cognitive complexity of 53 (threshold 50) [readability-function-cognitive-complexity]
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str, ^
Additional context
cloud/src/meta-service/meta_service.cpp:2200: +1, including nesting penalty of 0, nesting level increased to 1
} catch (...) { ^
cloud/src/meta-service/meta_service.cpp:2207: +1, including nesting penalty of 0, nesting level increased to 1
if (instance_id.empty()) { ^
cloud/src/meta-service/meta_service.cpp:2218: +1, including nesting penalty of 0, nesting level increased to 1
if (err != TxnErrorCode::TXN_OK) { ^
cloud/src/meta-service/meta_service.cpp:2236: +1, including nesting penalty of 0, nesting level increased to 1
do { ^
cloud/src/meta-service/meta_service.cpp:2238: +2, including nesting penalty of 1, nesting level increased to 2
if (err != TxnErrorCode::TXN_OK) { ^
cloud/src/meta-service/meta_service.cpp:2244: +2, including nesting penalty of 1, nesting level increased to 2
while (it->has_next()) { ^
cloud/src/meta-service/meta_service.cpp:2251: +3, including nesting penalty of 2, nesting level increased to 3
if (out.size() == 7) { ^
cloud/src/meta-service/meta_service.cpp:2268: +4, including nesting penalty of 3, nesting level increased to 4
if (code != MetaServiceCode::OK) { ^
cloud/src/meta-service/meta_service.cpp:2291: +4, including nesting penalty of 3, nesting level increased to 4
if (!tablet_stat.SerializeToString(&tablet_stat_value)) { ^
cloud/src/meta-service/meta_service.cpp:2324: +4, including nesting penalty of 3, nesting level increased to 4
if (err != TxnErrorCode::TXN_OK) { ^
cloud/src/meta-service/meta_service.cpp:2338: +4, including nesting penalty of 3, nesting level increased to 4
if (tablet_stat_check.DebugString() != tablet_stat.DebugString()) { ^
cloud/src/meta-service/meta_service.cpp:2349: +4, including nesting penalty of 3, nesting level increased to 4
if (err != TxnErrorCode::TXN_OK) { ^
cloud/src/meta-service/meta_service.cpp:2358: +4, including nesting penalty of 3, nesting level increased to 4
if (tablet_stat_data_size_value.size() != sizeof(tablet_stat_data_size_check)) ^
cloud/src/meta-service/meta_service.cpp:2368: +4, including nesting penalty of 3, nesting level increased to 4
ifconstexpr (std::endian::native == std::endian::big) { ^
cloud/src/meta-service/meta_service.cpp:2375: +4, including nesting penalty of 3, nesting level increased to 4
if (tablet_stat_data_size_check != tablet_stat_data_size) { ^
cloud/src/meta-service/meta_service.cpp:2385: +3, including nesting penalty of 2, nesting level increased to 3
if (sub_txn_id % 50 == 0) { ^
cloud/src/meta-service/meta_service.cpp:2387: +4, including nesting penalty of 3, nesting level increased to 4
if (err != TxnErrorCode::TXN_OK) { ^
cloud/src/meta-service/meta_service.cpp:2393: +1, nesting level increased to 4
} else { ^
cloud/src/meta-service/meta_service.cpp:2405: +1, including nesting penalty of 0, nesting level increased to 1
if (err != TxnErrorCode::TXN_OK) { ^
cloud/src/meta-service/meta_service.cpp:2413: +1, nesting level increased to 1
} else { ^

github-actions · 2024-10-21T06:41:12Z

 return {code, std::move(msg)};
 }

+MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str,


warning: function 'fix_tablet_stats' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str, ^
Additional context
cloud/src/meta-service/meta_service.cpp:2190: 231 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str, ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-22T02:18:11Z

 return {code, std::move(msg)};
 }

+MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str,


warning: function 'fix_tablet_stats' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str, ^
Additional context
cloud/src/meta-service/meta_service.cpp:2190: 335 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string cloud_unique_id_str, ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-22T09:33:15Z

@@ -18,10 +18,17 @@
 #include "meta-service/meta_service_tablet_stats.h"


warning: 'meta-service/meta_service_tablet_stats.h' file not found [clang-diagnostic-error]
#include"meta-service/meta_service_tablet_stats.h" ^

github-actions · 2024-10-22T09:33:15Z

@@ -19,6 +19,8 @@

 #include <gen_cpp/cloud.pb.h>


warning: 'gen_cpp/cloud.pb.h' file not found [clang-diagnostic-error]
#include<gen_cpp/cloud.pb.h> ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-28T08:57:58Z

+ return st;
+}
+
+MetaServiceResponseStatus fix_tablet_stats_internal(


warning: function 'fix_tablet_stats_internal' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus fix_tablet_stats_internal( ^
Additional context
cloud/src/meta-service/meta_service_tablet_stats.cpp:196: 104 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus fix_tablet_stats_internal( ^

Yukang-Lian · 2024-10-28T12:03:15Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-28T12:03:56Z

+ return st;
+}
+
+MetaServiceResponseStatus fix_tablet_stats_internal(


warning: function 'fix_tablet_stats_internal' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus fix_tablet_stats_internal( ^
Additional context
cloud/src/meta-service/meta_service_tablet_stats.cpp:196: 126 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus fix_tablet_stats_internal( ^

doris-robot · 2024-10-28T13:49:14Z

TeamCity be ut coverage result:
Function Coverage: 37.46% (9717/25937)
Line Coverage: 28.73% (80613/280543)
Region Coverage: 28.16% (41695/148049)
Branch Coverage: 24.72% (21182/85682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fa2095a202d0e920870fb17172c227dd260acb10_fa2095a202d0e920870fb17172c227dd260acb10/report/index.html

Yukang-Lian · 2024-10-28T14:38:56Z

run cloud_p0

Yukang-Lian · 2024-10-28T15:00:31Z

run buildall

doris-robot · 2024-10-28T15:25:05Z

TeamCity be ut coverage result:
Function Coverage: 37.46% (9715/25937)
Line Coverage: 28.72% (80578/280543)
Region Coverage: 28.14% (41667/148049)
Branch Coverage: 24.71% (21170/85682)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8fa5823d2afc21c28ad6c42fc90a0f918f2c67cc_8fa5823d2afc21c28ad6c42fc90a0f918f2c67cc/report/index.html

Yukang-Lian · 2024-10-29T18:29:18Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-10-29T18:31:51Z

+ return st;
+}
+
+MetaServiceResponseStatus fix_tablet_stats_internal(


warning: function 'fix_tablet_stats_internal' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus fix_tablet_stats_internal( ^
Additional context
cloud/src/meta-service/meta_service_tablet_stats.cpp:196: 125 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus fix_tablet_stats_internal( ^

doris-robot · 2024-10-29T19:07:29Z

TeamCity be ut coverage result:
Function Coverage: 37.48% (9721/25938)
Line Coverage: 28.74% (80644/280620)
Region Coverage: 28.15% (41674/148042)
Branch Coverage: 24.72% (21173/85668)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f125f11a55a7746211f1b72603c055938a9360fe_f125f11a55a7746211f1b72603c055938a9360fe/report/index.html

github-actions · 2024-10-30T07:55:45Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-10-30T07:55:47Z

PR approved by anyone and no changes requested.

Hastyshell

LGTM

…he#41782)

… size api for meta service (#41782)" (#43460) Pick #41782 --------- Co-authored-by: Yukang-Lian <lianyukang@selectdb.com>

…he#41782)

github-actionsBot reviewed Oct 14, 2024
View reviewed changes

Yukang-Lian force-pushed the Add-Api-For-Meta-Service branch from 17f8700 to bd799efCompare October 15, 2024 17:09

github-actionsBot reviewed Oct 15, 2024
View reviewed changes

gavinchou reviewed Oct 16, 2024
View reviewed changes

Comment threadgensrc/proto/cloud.proto Outdated

gavinchou reviewed Oct 16, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp

apache deleted a comment from github-actionsBotOct 16, 2024

gavinchou requested changes Oct 16, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

github-actionsBot reviewed Oct 17, 2024
View reviewed changes

github-actionsBot reviewed Oct 21, 2024
View reviewed changes

gavinchou reviewed Oct 21, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

gavinchou reviewed Oct 21, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

github-actionsBot reviewed Oct 22, 2024
View reviewed changes

gavinchou reviewed Oct 22, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_http.cpp

gavinchou reviewed Oct 22, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

gavinchou reviewed Oct 22, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_tablet_stats.h

gavinchou reviewed Oct 22, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_tablet_stats.cpp Outdated

gavinchou reviewed Oct 22, 2024
View reviewed changes

Comment threadcloud/src/meta-service/meta_service_tablet_stats.cpp Outdated

Yukang-Lian force-pushed the Add-Api-For-Meta-Service branch from 63eb9a8 to a745f7eCompare October 24, 2024 15:01

github-actionsBot reviewed Oct 28, 2024
View reviewed changes

Yukang-Lian force-pushed the Add-Api-For-Meta-Service branch from 2d305ac to fa2095aCompare October 28, 2024 12:00

github-actionsBot reviewed Oct 28, 2024
View reviewed changes

Yukang-Lian added 9 commits October 30, 2024 02:28

12
38cb516

13
2ac8173

14
2fde776

15
4485157

16
327a8bf

17
7b75ba3

18
119a60b

19
c543031

20
f125f11

Yukang-Lian force-pushed the Add-Api-For-Meta-Service branch from a0029ff to f125f11Compare October 29, 2024 18:29

github-actionsBot reviewed Oct 29, 2024
View reviewed changes

gavinchou approved these changes Oct 30, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 30, 2024

github-actionsBot added the reviewed label Oct 30, 2024

Hastyshell approved these changes Oct 30, 2024
View reviewed changes

dataroaring added the dev/3.0.x label Oct 30, 2024

gavinchou merged commit 3c7fe3f into apache:masterOct 30, 2024

github-actionsBot added the cherry-pick-conflict-in-3.0 label Oct 30, 2024

Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Nov 7, 2024
[Enhancement](MS) Add fix tablet data size api for meta service (apac…
ffa6fef
…he#41782)

Yukang-Lian mentioned this pull request Nov 7, 2024
[cherry-pick](branch-3.0) Pick "[Enhancement](MS) Add fix tablet data size api for meta service (#41782)" #43460
Merged

dataroaring pushed a commit that referenced this pull request Nov 11, 2024
[cherry-pick](branch-3.0) Pick "[Enhancement](MS) Add fix tablet data…
78bfa52
… size api for meta service (#41782)" (#43460) Pick #41782 --------- Co-authored-by: Yukang-Lian <lianyukang@selectdb.com>

dataroaring added dev/3.0.3-merged and removed dev/3.0.x cherry-pick-conflict-in-3.0 labels Nov 11, 2024

gavinchou mentioned this pull request Nov 26, 2024
Release Note 3.0.3 #44522
Closed

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[Enhancement](MS) Add fix tablet data size api for meta service (apac…
79d60c6
…he#41782)

		@@ -18,10 +18,17 @@
		#include "meta-service/meta_service_tablet_stats.h"

Uh oh!

Conversation

Yukang-Lian commented Oct 14, 2024

Proposed changes

Uh oh!

doris-robot commented Oct 14, 2024

Uh oh!

Yukang-Lian commented Oct 14, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 21, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 21, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 28, 2024

Choose a reason for hiding this comment

Uh oh!

Yukang-Lian commented Oct 28, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 28, 2024

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Oct 28, 2024

Uh oh!

Yukang-Lian commented Oct 28, 2024

Uh oh!

Yukang-Lian commented Oct 28, 2024

Uh oh!

doris-robot commented Oct 28, 2024

Uh oh!

Yukang-Lian commented Oct 29, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotOct 29, 2024