Skip to content

[cherry-pick](branch-3.0) Pick "[Enhancement](MS) Add fix tablet data size api for meta service (#41782)" - #43460

Merged
dataroaring merged 2 commits into
apache:branch-3.0from
Yukang-Lian:Pick-41782-3.0
Nov 11, 2024
Merged

[cherry-pick](branch-3.0) Pick "[Enhancement](MS) Add fix tablet data size api for meta service (#41782)"#43460
dataroaring merged 2 commits into
apache:branch-3.0from
Yukang-Lian:Pick-41782-3.0

Conversation

@Yukang-Lian

@Yukang-LianYukang-Lian commented Nov 7, 2024

Copy link
Copy Markdown
Collaborator

Pick #41782

@doris-robot

doris-robot commented Nov 7, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Yukang-Lian

Yukang-Lian commented Nov 7, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@Yukang-Lian

Yukang-Lian commented Nov 7, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Nov 7, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/src/meta-service/meta_service_tablet_stats.cpp
@@ -17,13 +17,22 @@

#include "meta-service/meta_service_tablet_stats.h"

@github-actionsgithub-actionsBotNov 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'meta-service/meta_service_tablet_stats.h' file not found [clang-diagnostic-error]

#include"meta-service/meta_service_tablet_stats.h"
^

Comment threadcloud/src/meta-service/meta_service_tablet_stats.cpp
return st;
}

MetaServiceResponseStatus fix_tablet_stats_internal(

@github-actionsgithub-actionsBotNov 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'fix_tablet_stats_internal' exceeds recommended size/complexity thresholds [readability-function-size]

MetaServiceResponseStatus fix_tablet_stats_internal(
^
Additional context

cloud/src/meta-service/meta_service_tablet_stats.cpp:196: 125 lines including whitespace and comments (threshold 80)

MetaServiceResponseStatus fix_tablet_stats_internal(
^

Comment threadcloud/src/meta-service/meta_service_tablet_stats.h
@@ -19,6 +19,8 @@

#include <gen_cpp/cloud.pb.h>

@github-actionsgithub-actionsBotNov 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/cloud.pb.h' file not found [clang-diagnostic-error]

#include<gen_cpp/cloud.pb.h>
^

@Yukang-Lian

Yukang-Lian commented Nov 8, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run cloud_p0

@Yukang-Lian

Yukang-Lian commented Nov 10, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run external

1 similar comment
@Yukang-Lian

Yukang-Lian commented Nov 11, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run external

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit 78bfa52 into apache:branch-3.0Nov 11, 2024
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@gavinchougavinchougavinchou approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yukang-Lian@doris-robot@gavinchou@dataroaring