Skip to content

[Enhancement](log) Make query relative BE log more reasonable - #42900

Merged
zhangstar333 merged 1 commit into
apache:masterfrom
zclllyybb:refactor_log
Nov 5, 2024
Merged

[Enhancement](log) Make query relative BE log more reasonable#42900
zhangstar333 merged 1 commit into
apache:masterfrom
zclllyybb:refactor_log

Conversation

@zclllyybb

@zclllyybbzclllyybb commented Oct 30, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

before we have many info logs which may not useful when a query runs. now we reduced them. keep one info log for each stage below:

  1. query arrive
  2. FE tells to run fragment
  3. query finished

and no others

@doris-robot

doris-robot commented Oct 30, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb

zclllyybb commented Oct 30, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Oct 30, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.95% (9847/25949)
Line Coverage: 29.22% (82000/280631)
Region Coverage: 28.56% (42293/148083)
Branch Coverage: 25.09% (21491/85660)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dd716eb54a537f15a3df2543f6ff802a74a6e2fb_dd716eb54a537f15a3df2543f6ff802a74a6e2fb/report/index.html

HappenLee
HappenLee reviewed Oct 30, 2024
View reviewed changes
Comment threadbe/src/runtime/fragment_mgr.cpp Outdated
@zclllyybb

zclllyybb commented Oct 30, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Oct 30, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.89% (9847/25985)
Line Coverage: 29.17% (81995/281124)
Region Coverage: 28.55% (42330/148285)
Branch Coverage: 25.07% (21506/85780)
Coverage Report: http://coverage.selectdb-in.cc/coverage/14ba2824d1b7080a98692ad8e5d0af63ff7ef81f_14ba2824d1b7080a98692ad8e5d0af63ff7ef81f/report/index.html

HappenLee
HappenLee previously approved these changes Oct 31, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024
@github-actions

github-actionsBot commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 1, 2024
@zclllyybb

zclllyybb commented Nov 1, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 1, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.82% (9821/25971)
Line Coverage: 28.99% (81628/281535)
Region Coverage: 28.27% (42156/149137)
Branch Coverage: 24.85% (21387/86076)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c13c74e6cf9273777a60547b8f9e62cc3cb44503_c13c74e6cf9273777a60547b8f9e62cc3cb44503/report/index.html

@github-actions

github-actionsBot commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb

zclllyybb commented Nov 4, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Nov 4, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.81% (9822/25975)
Line Coverage: 28.99% (81693/281807)
Region Coverage: 28.22% (42111/149199)
Branch Coverage: 24.81% (21368/86140)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3b25838dc13c3446c9e0c676804ecde83dbd63f4_3b25838dc13c3446c9e0c676804ecde83dbd63f4/report/index.html

HappenLee
HappenLee approved these changes Nov 5, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2024
@github-actions

github-actionsBot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@zhangstar333
zhangstar333 merged commit cc7e275 into apache:masterNov 5, 2024
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 5, 2024
@zclllyybb
[Enhancement](log) Make query relative BE log more reasonable (apache…
fd5ef13
…#42900)
Issue Number: close #xxx
before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished
and no others
@zclllyybbzclllyybb mentioned this pull request Nov 5, 2024
Merged
@zclllyybb
zclllyybb deleted the refactor_log branch November 8, 2024 05:10
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 11, 2024
@zclllyybb
[Enhancement](log) Make query relative BE log more reasonable (apache…
605f5be
…#42900)
Issue Number: close #xxx
before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished
and no others
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 11, 2024
@zclllyybb
[Enhancement](log) Make query relative BE log more reasonable (apache…
a35b1ea
…#42900)
Issue Number: close #xxx
before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished
and no others
@zclllyybbzclllyybb mentioned this pull request Nov 11, 2024
Merged
yiguolei pushed a commit that referenced this pull request Nov 12, 2024
@zclllyybb
[branch-2.1](log) Pick all BE execution log reduction (#43267)
24b79fd
pick #42383
pick #42900
yiguolei pushed a commit that referenced this pull request Nov 13, 2024
@zclllyybb
[branch-3.0](log) Pick all BE execution log reduction (#43579)
11a9a48
pick #42383
pick #42900
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zclllyybb@HappenLee
[Enhancement](log) Make query relative BE log more reasonable (apache…
585d82c
…#42900)
## Proposed changes
Issue Number: close #xxx
before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished
and no others
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLeeHappenLeeHappenLee approved these changes
@zhangstar333zhangstar333zhangstar333 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zclllyybb@doris-robot@HappenLee@zhangstar333@yiguolei