Skip to content

[Opt](checker) Add checker for delete bitmaps - #44154

Merged
dataroaring merged 4 commits into
apache:masterfrom
bobhan1:add-checker-for-delete-bitmaps
Dec 3, 2024
Merged

[Opt](checker) Add checker for delete bitmaps#44154
dataroaring merged 4 commits into
apache:masterfrom
bobhan1:add-checker-for-delete-bitmaps

Conversation

@bobhan1

@bobhan1bobhan1 commented Nov 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

  1. check every delete bitmap in MS belongs to a visible rowset
  2. check that [improve](cloud-mow) merge and remove old version of delete bitmap when cumulative compaction is done #40204 works as expected

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 18, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from 0965abb to ff9a306CompareNovember 18, 2024 05:16
@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from ff9a306 to 88e307aCompareNovember 18, 2024 05:31
@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from 88e307a to b0dde93CompareNovember 18, 2024 06:13
@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from b0dde93 to 9249d0bCompareNovember 18, 2024 06:30
@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actionsBot reviewed Nov 18, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/src/recycler/checker.h
github-actions[bot]
github-actionsBot reviewed Nov 18, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/test/recycler_test.cpp Outdated
Comment threadcloud/test/recycler_test.cpp
@bobhan1
bobhan1 marked this pull request as ready for review November 18, 2024 11:24
github-actions[bot]
github-actionsBot reviewed Nov 18, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/test/recycler_test.cpp Outdated
Comment threadcloud/test/recycler_test.cpp
Comment threadcloud/test/recycler_test.cpp
zhannngchen
zhannngchen reviewed Nov 18, 2024
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from c75596d to 9d2bf90CompareNovember 19, 2024 02:28
github-actions[bot]
github-actionsBot reviewed Nov 19, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/test/recycler_test.cpp
github-actions[bot]
github-actionsBot reviewed Nov 19, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/test/recycler_test.cpp
github-actions[bot]
github-actionsBot reviewed Nov 19, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadcloud/test/recycler_test.cpp
Comment threadcloud/test/recycler_test.cpp
Comment threadcloud/test/recycler_test.cpp
@bobhan1

bobhan1 commented Nov 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from e909939 to e7e8bbbCompareNovember 21, 2024 02:09
@dataroaring

dataroaring commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

run buildall

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from e7e8bbb to 546799cCompareNovember 22, 2024 07:11
@bobhan1

bobhan1 commented Nov 22, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@bobhan1
bobhan1force-pushed the add-checker-for-delete-bitmaps branch from ead8ef3 to 47c6cb4CompareNovember 25, 2024 08:24
@bobhan1

bobhan1 commented Nov 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@dataroaring
dataroaringforce-pushed the add-checker-for-delete-bitmaps branch from 6c8adaa to 116a997CompareDecember 3, 2024 02:51
@dataroaring

dataroaring commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

run buildall

zhannngchen
zhannngchen approved these changes Dec 3, 2024
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions

github-actionsBot commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Dec 3, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 7a68d8f into apache:masterDec 3, 2024
github-actionsBot pushed a commit that referenced this pull request Dec 3, 2024
@bobhan1Your Name
[Opt](checker) Add checker for delete bitmaps (#44154)
29c967f
1. check every delete bitmap in MS belongs to a visible rowset
2. check that #40204 works as
expected
@github-actionsgithub-actionsBot mentioned this pull request Dec 3, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 4, 2024
@github-actions@bobhan1
branch-3.0: [Opt](checker) Add checker for delete bitmaps#44154(#44952
052b7f9
)
Cherry-picked from #44154
Co-authored-by: bobhan1 <baohan@selectdb.com>
@mymeiyimymeiyi mentioned this pull request Jun 12, 2025
Merged
16 tasks
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@bobhan1@HappenLee
[Opt](checker) Add checker for delete bitmaps (apache#44154)
43039d1
1. check every delete bitmap in MS belongs to a visible rowset
2. check that apache#40204 works as
expected
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobhan1@doris-robot@dataroaring@zhannngchen