[fix](mow) remove checker code for enable_delete_bitmap_merge_on_compaction by mymeiyi · Pull Request #51676 · apache/doris

mymeiyi · 2025-06-12T10:12:18Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

related to #51479
remove checker code added by #44154

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-06-12T10:12:24Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

mymeiyi · 2025-06-12T10:14:13Z

run buildall

dataroaring · 2025-06-18T13:23:23Z

run buildall

hello-stephen · 2025-06-18T13:47:11Z

Cloud UT Coverage Report

Increment line coverage 88.73% (126/142) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.16% (1116/1342)
Line Coverage	66.73% (19218/28799)
Region Coverage	66.45% (9541/14358)
Branch Coverage	56.44% (5185/9186)

doris-robot · 2025-06-18T14:31:28Z

TPC-H: Total hot run time: 34028 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68f7ca41103f00e951e5a9ab198d96a1ce0df067, data reload: false
------ Round 1 ----------------------------------
q1	17645	5163	4979	4979
q2	1946	279	194	194
q3	10299	1329	744	744
q4	10224	1038	539	539
q5	7549	2425	2344	2344
q6	186	167	131	131
q7	918	742	621	621
q8	9325	1286	1148	1148
q9	6882	5178	5121	5121
q10	6951	2397	1953	1953
q11	483	296	273	273
q12	345	351	215	215
q13	17788	3704	3060	3060
q14	228	232	209	209
q15	554	495	499	495
q16	424	445	375	375
q17	626	870	378	378
q18	8031	7142	7097	7097
q19	1603	953	546	546
q20	351	344	229	229
q21	4217	3312	2445	2445
q22	1062	1010	932	932
Total cold run time: 107637 ms
Total hot run time: 34028 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5141	5013	5024	5013
q2	241	322	228	228
q3	2166	2674	2287	2287
q4	1363	1768	1411	1411
q5	4243	4175	4458	4175
q6	213	169	127	127
q7	2024	1924	1749	1749
q8	2648	2606	2508	2508
q9	7222	7188	7158	7158
q10	3070	3263	2863	2863
q11	608	502	490	490
q12	694	772	637	637
q13	3547	3891	3288	3288
q14	276	293	286	286
q15	565	506	508	506
q16	437	493	460	460
q17	1144	1599	1323	1323
q18	7777	7629	7520	7520
q19	798	864	1050	864
q20	1973	2045	1936	1936
q21	4908	4615	4378	4378
q22	1043	1044	992	992
Total cold run time: 52101 ms
Total hot run time: 50199 ms

doris-robot · 2025-06-18T14:43:04Z

TPC-DS: Total hot run time: 186488 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68f7ca41103f00e951e5a9ab198d96a1ce0df067, data reload: false
query1	1009	399	394	394
query2	6561	1818	1843	1818
query3	6772	232	225	225
query4	26216	23892	23264	23264
query5	4345	625	470	470
query6	304	219	205	205
query7	4626	494	286	286
query8	280	230	226	226
query9	8622	2636	2634	2634
query10	496	348	274	274
query11	15346	15118	14860	14860
query12	155	109	103	103
query13	1665	536	419	419
query14	8712	6209	6218	6209
query15	210	206	172	172
query16	7312	631	513	513
query17	1218	747	588	588
query18	1985	410	319	319
query19	198	193	165	165
query20	126	131	113	113
query21	218	135	110	110
query22	4235	4197	4036	4036
query23	34062	33181	33445	33181
query24	8447	2386	2403	2386
query25	551	459	391	391
query26	1234	273	153	153
query27	2751	504	352	352
query28	4323	2130	2114	2114
query29	786	546	439	439
query30	288	221	198	198
query31	926	863	748	748
query32	75	66	67	66
query33	554	380	308	308
query34	806	864	526	526
query35	798	805	745	745
query36	950	985	891	891
query37	112	100	88	88
query38	4238	4130	4079	4079
query39	1450	1431	1389	1389
query40	236	120	110	110
query41	65	62	60	60
query42	130	115	121	115
query43	503	504	485	485
query44	1306	828	837	828
query45	183	170	165	165
query46	845	1046	639	639
query47	1754	1785	1722	1722
query48	403	425	308	308
query49	749	486	401	401
query50	642	668	418	418
query51	4141	4216	4174	4174
query52	109	105	99	99
query53	221	254	184	184
query54	588	591	500	500
query55	86	90	84	84
query56	314	311	282	282
query57	1187	1183	1145	1145
query58	262	265	255	255
query59	2624	2707	2555	2555
query60	325	322	310	310
query61	129	126	131	126
query62	802	716	652	652
query63	222	190	184	184
query64	4369	1008	698	698
query65	4280	4188	4202	4188
query66	1149	416	364	364
query67	16028	15737	15609	15609
query68	9178	906	538	538
query69	470	303	267	267
query70	1212	1154	1071	1071
query71	465	320	309	309
query72	5618	4724	4756	4724
query73	738	628	365	365
query74	9094	9093	8697	8697
query75	4228	3181	2733	2733
query76	3612	1206	759	759
query77	941	377	299	299
query78	10121	10445	9354	9354
query79	2179	890	594	594
query80	735	511	447	447
query81	482	261	230	230
query82	429	127	96	96
query83	289	262	241	241
query84	294	106	93	93
query85	794	361	320	320
query86	336	297	285	285
query87	4400	4424	4424	4424
query88	3372	2297	2357	2297
query89	392	338	290	290
query90	1928	212	208	208
query91	139	146	113	113
query92	77	60	58	58
query93	1345	964	601	601
query94	685	406	287	287
query95	373	301	284	284
query96	498	563	276	276
query97	2734	2769	2643	2643
query98	240	212	270	212
query99	1458	1407	1256	1256
Total cold run time: 275470 ms
Total hot run time: 186488 ms

doris-robot · 2025-06-18T14:48:18Z

ClickBench: Total hot run time: 29.59 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68f7ca41103f00e951e5a9ab198d96a1ce0df067, data reload: false
query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.45	0.43	0.42
query6	1.17	0.66	0.67
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.57	0.53	0.51
query10	0.58	0.58	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.61
query14	0.81	0.83	0.81
query15	0.89	0.86	0.91
query16	0.38	0.39	0.38
query17	1.08	1.04	1.06
query18	0.23	0.22	0.21
query19	1.96	1.84	1.79
query20	0.02	0.01	0.01
query21	15.43	0.91	0.53
query22	0.76	1.12	0.63
query23	15.07	1.39	0.62
query24	6.87	1.02	0.99
query25	0.51	0.21	0.07
query26	0.60	0.17	0.14
query27	0.07	0.05	0.05
query28	9.52	0.88	0.45
query29	12.57	4.02	3.30
query30	0.25	0.09	0.07
query31	2.83	0.61	0.39
query32	3.22	0.56	0.47
query33	3.03	3.14	3.07
query34	16.15	5.36	4.82
query35	4.83	4.81	4.85
query36	0.69	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.18	0.15	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 104.01 s
Total hot run time: 29.59 s

hello-stephen · 2025-06-18T16:09:09Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.34% (15049/26709)
Line Coverage	45.10% (134589/298409)
Region Coverage	44.24% (67699/153016)
Branch Coverage	38.82% (34727/89464)

hello-stephen · 2025-06-18T16:36:41Z

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	61.19% (16084/26284)
Line Coverage	50.71% (151227/298248)
Region Coverage	48.06% (86500/179998)
Branch Coverage	41.55% (42493/102274)

mymeiyi · 2025-07-08T06:27:29Z

run buildall

doris-robot · 2025-07-08T06:51:45Z

Cloud UT Coverage Report

Increment line coverage 87.50% (14/16) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	82.89% (1216/1467)
Line Coverage	67.46% (21057/31212)
Region Coverage	67.20% (10503/15629)
Branch Coverage	56.66% (5533/9766)

zhannngchen

LGTM

github-actions · 2025-07-11T02:31:15Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-11T02:31:17Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

…action (#51676)

…erge_on_compaction #51676 (#53082) Cherry-picked from #51676 Co-authored-by: meiyi <meiyi@selectdb.com>

mymeiyi requested review from dataroaring, gavinchou and w41ter as code owners June 12, 2025 10:12

mymeiyi mentioned this pull request Jun 16, 2025
[fix](mow) fix check delete bitmap for mow tables with seq column #51763
Merged
16 tasks

dataroaring force-pushed the remove-checker branch from f32bf51 to 68f7ca4Compare June 18, 2025 13:23

remove code
da8972d

mymeiyi force-pushed the remove-checker branch from 68f7ca4 to da8972dCompare July 8, 2025 06:25

zhannngchen approved these changes Jul 11, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

github-actionsBot added the reviewed label Jul 11, 2025

dataroaring approved these changes Jul 11, 2025
View reviewed changes

dataroaring added the dev/3.1.x label Jul 11, 2025

dataroaring merged commit 7c69a40 into apache:masterJul 11, 2025

github-actionsBot pushed a commit that referenced this pull request Jul 11, 2025
[fix](mow) remove checker code for enable_delete_bitmap_merge_on_comp…
a0353fd
…action (#51676)

github-actionsBot mentioned this pull request Jul 11, 2025
branch-3.1: [fix](mow) remove checker code for enable_delete_bitmap_merge_on_compaction #51676 #53082
Merged

morrySnow pushed a commit that referenced this pull request Jul 11, 2025
branch-3.1: [fix](mow) remove checker code for enable_delete_bitmap_m…
481ea59
…erge_on_compaction #51676 (#53082) Cherry-picked from #51676 Co-authored-by: meiyi <meiyi@selectdb.com>

morrySnow removed the dev/3.1.x label Jul 11, 2025

morrySnow added the dev/3.1.0-merged label Jul 11, 2025

Uh oh!

Conversation

mymeiyi commented Jun 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jun 12, 2025

Uh oh!

mymeiyi commented Jun 12, 2025

Uh oh!

dataroaring commented Jun 18, 2025

Uh oh!

hello-stephen commented Jun 18, 2025

Cloud UT Coverage Report

Uh oh!

doris-robot commented Jun 18, 2025

Uh oh!

doris-robot commented Jun 18, 2025

Uh oh!

doris-robot commented Jun 18, 2025

Uh oh!

hello-stephen commented Jun 18, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Jun 18, 2025

BE Regression && UT Coverage Report

Uh oh!

mymeiyi commented Jul 8, 2025

Uh oh!

doris-robot commented Jul 8, 2025

Cloud UT Coverage Report

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jul 11, 2025

Uh oh!

github-actionsBot commented Jul 11, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mymeiyi commented Jun 12, 2025•
edited
Loading