Skip to content

[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling - #47536

Merged
gavinchou merged 1 commit into
apache:masterfrom
Yukang-Lian:Fix-Recycler-Tmp-Rowset3
Feb 6, 2025
Merged

[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling#47536
gavinchou merged 1 commit into
apache:masterfrom
Yukang-Lian:Fix-Recycler-Tmp-Rowset3

Conversation

@Yukang-Lian

@Yukang-LianYukang-Lian commented Feb 6, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #47475#47486

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian

Yukang-Lian commented Feb 6, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@gavinchou

gavinchou commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Add UT in a new PR

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2025
@github-actions

github-actionsBot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Hastyshell
Hastyshell approved these changes Feb 6, 2025
View reviewed changes

@HastyshellHastyshell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

airborne12
airborne12 reviewed Feb 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/recycler.cpp
airborne12
airborne12 approved these changes Feb 6, 2025
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou
gavinchou merged commit 3fb37ce into apache:masterFeb 6, 2025
github-actionsBot pushed a commit that referenced this pull request Feb 6, 2025
@Yukang-LianYour Name
[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling (#…
b89d55d
…47536)
Related PR: #47475#47486
@github-actionsgithub-actionsBot mentioned this pull request Feb 6, 2025
Merged
gavinchou pushed a commit that referenced this pull request Feb 7, 2025
@github-actions@Yukang-Lian
branch-3.0: [Fix](recycler) Fix retain inverted indexes in tmp rowset…
814e4d7
… recycling #47536 (#47546)
Cherry-picked from #47536
Co-authored-by: abmdocrt <lianyukang@selectdb.com>
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@Yukang-Lian@lzyy2024
[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling (a…
ec7c52c
…pache#47536)
Related PR: apache#47475apache#47486
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Yukang-Liankoarz
[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling (a…
6206aac
…pache#47536)
Related PR: apache#47475apache#47486
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringAwaiting requested review from dataroaring
@w41terw41terAwaiting requested review from w41ter
+1 more reviewer
@HastyshellHastyshellHastyshell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Yukang-Lian@hello-stephen@gavinchou@airborne12@Hastyshell@wm1581066@dataroaring