[improve](cloud-mow) MS can choose use new way or old way when processing delete bitmap lock by hust-hhb · Pull Request #49223 · apache/doris

hust-hhb · 2025-03-18T14:00:14Z

MS can choose use new way or old way when processing delete bitmap lock

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-03-18T14:00:22Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

hust-hhb · 2025-03-18T14:00:27Z

run buildall

doris-robot · 2025-03-18T14:10:55Z

TeamCity cloud ut coverage result:
Function Coverage: 82.86% (1083/1307)
Line Coverage: 65.41% (18023/27553)
Region Coverage: 64.72% (8887/13731)
Branch Coverage: 54.49% (4779/8770)
Coverage Report: http://coverage.selectdb-in.cc/coverage/afd702d0a8241f4fca09356a4f29295928f2be3c_afd702d0a8241f4fca09356a4f29295928f2be3c_cloud/report/index.html

hust-hhb · 2025-03-19T02:00:08Z

run buildall

zhannngchen · 2025-03-19T06:48:49Z

 CONF_Strings(recycler_storage_vault_white_list, "");
+
+CONF_mBool(use_delete_bitmap_lock_new_way, "true");
+CONF_mBool(use_delete_bitmap_lock_random_way, "true");


The random strategy doesn’t seem to need a configuration; injection should be enough.

In my test, injection like pr #47336 dosn't work in normal case

hust-hhb · 2025-04-02T01:52:25Z

run buildall

doris-robot · 2025-04-02T02:04:26Z

TeamCity cloud ut coverage result:
Function Coverage: 83.05% (1093/1316)
Line Coverage: 65.92% (18274/27720)
Region Coverage: 65.39% (9020/13795)
Branch Coverage: 55.15% (4860/8812)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4c15e53b1af343c891c55d6987998e3fc688ae96_4c15e53b1af343c891c55d6987998e3fc688ae96_cloud/report/index.html

cosven · 2025-04-07T13:05:22Z

Please rebase so we can run the correctness test again. @hust-hhb

hust-hhb · 2025-04-14T07:24:46Z

run buildall

doris-robot · 2025-04-14T07:45:58Z

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1094/1318)
Line Coverage: 65.72% (18276/27810)
Region Coverage: 65.11% (9049/13897)
Branch Coverage: 55.16% (4878/8844)
Coverage Report: http://coverage.selectdb-in.cc/coverage/32e9e07e2e8b6ee3019f9d43785d6a3559535676_32e9e07e2e8b6ee3019f9d43785d6a3559535676_cloud/report/index.html

…sing delete bitmap lock

hust-hhb · 2025-04-16T03:35:19Z

run buildall

doris-robot · 2025-04-16T03:44:22Z

TeamCity cloud ut coverage result:
Function Coverage: 82.93% (1093/1318)
Line Coverage: 65.64% (18257/27814)
Region Coverage: 65.02% (9039/13902)
Branch Coverage: 55.03% (4869/8848)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7682d7de8cb76b95644d9283cdf39431270a1e12_7682d7de8cb76b95644d9283cdf39431270a1e12_cloud/report/index.html

zhannngchen

LGTM

github-actions · 2025-04-16T15:27:29Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-04-16T15:27:33Z

PR approved by anyone and no changes requested.

hust-hhb · 2025-04-17T02:31:11Z

run buildall

doris-robot · 2025-04-17T02:43:07Z

TeamCity cloud ut coverage result:
Function Coverage: 82.93% (1093/1318)
Line Coverage: 65.67% (18265/27814)
Region Coverage: 65.06% (9044/13902)
Branch Coverage: 55.00% (4866/8848)
Coverage Report: http://coverage.selectdb-in.cc/coverage/90707f8403bd0f25a570b9d0b94cd727c0b86a07_90707f8403bd0f25a570b9d0b94cd727c0b86a07_cloud/report/index.html

zhannngchen

LGTM

github-actions · 2025-04-18T02:56:37Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

…ock version (#50281) update ut for pr #49223, add update delete bitmap case

…sing delete bitmap lock (apache#49223) MS can choose use new way or old way when processing delete bitmap lock

…ock version (apache#50281) update ut for pr apache#49223, add update delete bitmap case

…sing delete bitmap lock (apache#49223) MS can choose use new way or old way when processing delete bitmap lock

…ock version (apache#50281) update ut for pr apache#49223, add update delete bitmap case

…sing delete bitmap lock (apache#49223) MS can choose use new way or old way when processing delete bitmap lock

…ock version (apache#50281) update ut for pr apache#49223, add update delete bitmap case

…52038) pick #49716 #49223 #50242 #50281 #50062 --------- Co-authored-by: huanghaibin <huanghaibin@selectdb.com>

hust-hhb requested review from dataroaring, gavinchou and w41ter as code owners March 18, 2025 14:00

zhannngchen reviewed Mar 19, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

zhannngchen reviewed Mar 19, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.h Outdated

hust-hhb commented Mar 19, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

hust-hhb force-pushed the two-way branch from 0a5ba04 to bddc946Compare March 25, 2025 07:19

zhannngchen reviewed Apr 9, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

zhannngchen reviewed Apr 9, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp Outdated

zhannngchen reviewed Apr 9, 2025
View reviewed changes

Comment threadcloud/test/meta_service_test.cpp Outdated

[improve](cloud-mow) MS can choose use new way or old way when proces…
3c4871c
…sing delete bitmap lock

hust-hhb force-pushed the two-way branch from 32e9e07 to 3c4871cCompare April 15, 2025 07:05

edit
7682d7d

zhannngchen reviewed Apr 16, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.h Outdated

zhannngchen previously approved these changes Apr 16, 2025
View reviewed changes

zhannngchen reviewed Apr 16, 2025
View reviewed changes

Comment threadcloud/src/common/config.h

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 16, 2025

github-actionsBot added the reviewed label Apr 16, 2025

edit
90707f8

hust-hhb dismissed zhannngchen’s stale review via 90707f8April 17, 2025 02:30

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 17, 2025

zhannngchen approved these changes Apr 18, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 18, 2025

mymeiyi approved these changes Apr 18, 2025
View reviewed changes

dataroaring approved these changes Apr 18, 2025
View reviewed changes

dataroaring added the dev/3.1.x label Apr 18, 2025

dataroaring merged commit 1e4f8bd into apache:masterApr 18, 2025

hust-hhb mentioned this pull request Apr 22, 2025
[improve](cloud-mow)Add update delete bitmap case for delete bitmap lock version #50281
Merged
16 tasks

dataroaring pushed a commit that referenced this pull request Apr 23, 2025
[improve](cloud-mow)Add update delete bitmap case for delete bitmap l…
be228e8
…ock version (#50281) update ut for pr #49223, add update delete bitmap case

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
[improve](cloud-mow) MS can choose use new way or old way when proces…
a0aa5e7
…sing delete bitmap lock (apache#49223) MS can choose use new way or old way when processing delete bitmap lock

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
[improve](cloud-mow)Add update delete bitmap case for delete bitmap l…
37272c8
…ock version (apache#50281) update ut for pr apache#49223, add update delete bitmap case

mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Jun 19, 2025
[improve](cloud-mow) MS can choose use new way or old way when proces…
d689e2f
…sing delete bitmap lock (apache#49223) MS can choose use new way or old way when processing delete bitmap lock

mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Jun 19, 2025
[improve](cloud-mow)Add update delete bitmap case for delete bitmap l…
2790275
…ock version (apache#50281) update ut for pr apache#49223, add update delete bitmap case

mymeiyi mentioned this pull request Jun 20, 2025
branch-3.1: pick 5 mow lock prs #49716, #49223, #50242, #50281, #50062 #52038
Merged

mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Jun 20, 2025
[improve](cloud-mow) MS can choose use new way or old way when proces…
636b6cf
…sing delete bitmap lock (apache#49223) MS can choose use new way or old way when processing delete bitmap lock

mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Jun 20, 2025
[improve](cloud-mow)Add update delete bitmap case for delete bitmap l…
2dd11a5
…ock version (apache#50281) update ut for pr apache#49223, add update delete bitmap case

morrySnow pushed a commit that referenced this pull request Jun 20, 2025
branch-3.1: pick 5 mow lock prs#49716#49223#50242#50281#50062(#…
72eeccf
…52038) pick #49716 #49223 #50242 #50281 #50062 --------- Co-authored-by: huanghaibin <huanghaibin@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jun 20, 2025

Uh oh!

Conversation

hust-hhb commented Mar 18, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Mar 18, 2025

Uh oh!

hust-hhb commented Mar 18, 2025

Uh oh!

doris-robot commented Mar 18, 2025

Uh oh!

hust-hhb commented Mar 19, 2025

Uh oh!

zhannngchenMar 19, 2025

Choose a reason for hiding this comment

Uh oh!

hust-hhbApr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hust-hhb commented Apr 2, 2025

Uh oh!

doris-robot commented Apr 2, 2025

Uh oh!

cosven commented Apr 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hust-hhb commented Apr 14, 2025

Uh oh!

doris-robot commented Apr 14, 2025

Uh oh!

hust-hhb commented Apr 16, 2025

Uh oh!

doris-robot commented Apr 16, 2025

Uh oh!

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actionsBot commented Apr 16, 2025

Uh oh!

github-actionsBot commented Apr 16, 2025

Uh oh!

hust-hhb commented Apr 17, 2025

Uh oh!

doris-robot commented Apr 17, 2025

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 18, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cosven commented Apr 7, 2025•
edited
Loading