Skip to content

[improve](cloud-mow)Add checker for compaction key - #50062

Merged
dataroaring merged 8 commits into
apache:masterfrom
hust-hhb:add-checker
May 8, 2025
Merged

[improve](cloud-mow)Add checker for compaction key#50062
dataroaring merged 8 commits into
apache:masterfrom
hust-hhb:add-checker

Conversation

@hust-hhb

@hust-hhbhust-hhb commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Add checker for compaction key

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb

hust-hhb commented Apr 15, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Apr 15, 2025

Copy link
Copy Markdown

TeamCity cloud ut coverage result:
Function Coverage: 83.02% (1090/1313)
Line Coverage: 66.01% (18188/27552)
Region Coverage: 65.47% (8961/13687)
Branch Coverage: 55.27% (4825/8730)
Coverage Report: http://coverage.selectdb-in.cc/coverage/17cadc4f083fa77aed57ceb671a3bb6efc366254_17cadc4f083fa77aed57ceb671a3bb6efc366254_cloud/report/index.html

zhannngchen
zhannngchen reviewed Apr 23, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
zhannngchen
zhannngchen reviewed Apr 23, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
zhannngchen
zhannngchen reviewed Apr 23, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.h Outdated
zhannngchen
zhannngchen reviewed Apr 23, 2025
View reviewed changes
Comment threadcloud/test/recycler_test.cpp Outdated
zhannngchen
zhannngchen reviewed Apr 23, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
@hust-hhb

hust-hhb commented May 6, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 6, 2025

Copy link
Copy Markdown

TeamCity cloud ut coverage result:
Function Coverage: 83.09% (1101/1325)
Line Coverage: 65.94% (18472/28015)
Region Coverage: 65.35% (9152/14004)
Branch Coverage: 55.28% (4922/8904)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ea0e80bad07c576966408f1dbb50620421ed7868_ea0e80bad07c576966408f1dbb50620421ed7868_cloud/report/index.html

mymeiyi
mymeiyi reviewed May 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
mymeiyi
mymeiyi reviewed May 6, 2025
View reviewed changes
Comment threadcloud/src/common/config.h Outdated
@hust-hhb

hust-hhb commented May 7, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 7, 2025

Copy link
Copy Markdown

TeamCity cloud ut coverage result:
Function Coverage: 83.09% (1101/1325)
Line Coverage: 65.98% (18483/28015)
Region Coverage: 65.39% (9157/14004)
Branch Coverage: 55.35% (4928/8904)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c827d6cca31014aea06cfffb1ffb9bfa43a05139_c827d6cca31014aea06cfffb1ffb9bfa43a05139_cloud/report/index.html

@hust-hhb

hust-hhb commented May 7, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 7, 2025

Copy link
Copy Markdown

TeamCity cloud ut coverage result:
Function Coverage: 83.09% (1101/1325)
Line Coverage: 65.98% (18484/28016)
Region Coverage: 65.47% (9170/14006)
Branch Coverage: 55.38% (4932/8906)
Coverage Report: http://coverage.selectdb-in.cc/coverage/161365b774219eb937a33f5f08dd5d923994322d_161365b774219eb937a33f5f08dd5d923994322d_cloud/report/index.html

@hust-hhb

hust-hhb commented May 7, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

zhannngchen
zhannngchen approved these changes May 7, 2025
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 7, 2025
@github-actions

github-actionsBot commented May 7, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 7, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented May 7, 2025

Copy link
Copy Markdown

TeamCity cloud ut coverage result:
Function Coverage: 83.18% (1103/1326)
Line Coverage: 66.09% (18561/28084)
Region Coverage: 65.65% (9239/14073)
Branch Coverage: 55.42% (4966/8960)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b0efb3759c9a18954b26a621ccfedbcac00cc063_b0efb3759c9a18954b26a621ccfedbcac00cc063_cloud/report/index.html

dataroaring
dataroaring approved these changes May 8, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 5648560 into apache:masterMay 8, 2025
github-actionsBot pushed a commit that referenced this pull request May 8, 2025
@hust-hhbYour Name
[improve](cloud-mow)Add checker for compaction key (#50062)
8f72f06
Add checker for compaction key
@github-actionsgithub-actionsBot mentioned this pull request May 8, 2025
Closed
dataroaring pushed a commit that referenced this pull request May 13, 2025
@hust-hhb@dataroaring
[improve](cloud-mow)Add checker for compaction key (#50062)
72690b8
Add checker for compaction key
dataroaring pushed a commit that referenced this pull request May 24, 2025
@hust-hhb@dataroaring
[improve](cloud-mow)Add checker for compaction key (#50062)
30eba94
Add checker for compaction key
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@hust-hhbkoarz
[improve](cloud-mow)Add checker for compaction key (apache#50062)
d83f662
Add checker for compaction key
dataroaring pushed a commit that referenced this pull request Jun 11, 2025
@hust-hhb@dataroaring
[improve](cloud-mow)Add checker for compaction key (#50062)
b64c450
Add checker for compaction key
mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Jun 19, 2025
@hust-hhb@mymeiyi
[improve](cloud-mow)Add checker for compaction key (apache#50062)
dd3b2d9
Add checker for compaction key
@mymeiyimymeiyi mentioned this pull request Jun 20, 2025
Merged
mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Jun 20, 2025
@hust-hhb@mymeiyi
[improve](cloud-mow)Add checker for compaction key (apache#50062)
22f8ca8
Add checker for compaction key
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
@mymeiyi@hust-hhb
branch-3.1: pick 5 mow lock prs#49716#49223#50242#50281#50062(#…
72eeccf
…52038)
pick
#49716#49223#50242#50281#50062
---------
Co-authored-by: huanghaibin <huanghaibin@selectdb.com>
dataroaring pushed a commit that referenced this pull request Jun 27, 2025
@hust-hhb@dataroaring
[improve](cloud-mow)Add checker for compaction key (#50062)
e9e5421
Add checker for compaction key
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyimymeiyimymeiyi approved these changes
@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchouAwaiting requested review from gavinchougavinchou is a code owner
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hust-hhb@hello-stephen@doris-robot@mymeiyi@zhannngchen@dataroaring@morrySnow