Uh oh!
There was an error while loading. Please reload this page.
[fix](ubsan) fix ubsan error in DataTypeHLL::serialize - #50628
Merged
Conversation
Thearas
commented
May 6, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Mryange
commented
May 6, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 6, 2025
TPC-H: Total hot run time: 33754 ms |
doris-robot
commented
May 6, 2025
TPC-DS: Total hot run time: 192365 ms |
doris-robot
commented
May 6, 2025
ClickBench: Total hot run time: 28.42 s |
Mryange
commented
May 7, 2025
ContributorAuthor
run buildall |
doris-robot
commented
May 7, 2025
TPC-H: Total hot run time: 33507 ms |
doris-robot
commented
May 7, 2025
TPC-DS: Total hot run time: 185409 ms |
doris-robot
commented
May 7, 2025
ClickBench: Total hot run time: 28.66 s |
doris-robot
commented
May 7, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
May 7, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
May 7, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
May 7, 2025
github-actionsBot
pushed a commit
that referenced
this pull request
May 7, 2025
### What problem does this PR solve? In the code below, if the column size is 0, an empty vector will be created. A vector with size 0 may return nullptr from data() https://en.cppreference.com/w/cpp/container/vector/data `If size() is 0, data() may or may not return a null pointer.` This would trigger a ubsan error: `null pointer passed as argument 2, which is declared to never be null` Other data types don't have this issue because they use Doris internal pod array that guarantees data won't be nullptr.
dataroaring pushed a commit
that referenced
this pull request
May 13, 2025
### What problem does this PR solve? In the code below, if the column size is 0, an empty vector will be created. A vector with size 0 may return nullptr from data() https://en.cppreference.com/w/cpp/container/vector/data `If size() is 0, data() may or may not return a null pointer.` This would trigger a ubsan error: `null pointer passed as argument 2, which is declared to never be null` Other data types don't have this issue because they use Doris internal pod array that guarantees data won't be nullptr.
dataroaring pushed a commit
that referenced
this pull request
May 14, 2025
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? In the code below, if the column size is 0, an empty vector will be created. A vector with size 0 may return nullptr from data() https://en.cppreference.com/w/cpp/container/vector/data `If size() is 0, data() may or may not return a null pointer.` This would trigger a ubsan error: `null pointer passed as argument 2, which is declared to never be null` Other data types don't have this issue because they use Doris internal pod array that guarantees data won't be nullptr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the code below, if the column size is 0, an empty vector will be created. A vector with size 0 may return nullptr from data()
https://en.cppreference.com/w/cpp/container/vector/data
If size() is 0, data() may or may not return a null pointer.This would trigger a ubsan error:
null pointer passed as argument 2, which is declared to never be nullOther data types don't have this issue because they use Doris internal pod array that guarantees data won't be nullptr.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)