branch-3.0: [fix](ubsan) fix ubsan error in DataTypeHLL::serialize #50628 by github-actions[bot] · Pull Request #50668 · apache/doris

github-actions · 2025-05-07T11:19:38Z

Cherry-picked from #50628

hello-stephen · 2025-05-07T11:19:44Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

hello-stephen · 2025-05-07T11:19:48Z

run buildall

hello-stephen · 2025-05-07T12:07:35Z

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	40.93% (10789/26361)
Line Coverage	31.79% (92125/289756)
Region Coverage	30.85% (47517/154031)
Branch Coverage	27.35% (24349/89016)

dataroaring

LGTM

github-actions · 2025-05-08T01:45:37Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-05-08T01:45:39Z

PR approved by anyone and no changes requested.

### What problem does this PR solve? In the code below, if the column size is 0, an empty vector will be created. A vector with size 0 may return nullptr from data() https://en.cppreference.com/w/cpp/container/vector/data `If size() is 0, data() may or may not return a null pointer.` This would trigger a ubsan error: `null pointer passed as argument 2, which is declared to never be null` Other data types don't have this issue because they use Doris internal pod array that guarantees data won't be nullptr.

dataroaring · 2025-05-14T02:04:32Z

run buildall

doris-robot · 2025-05-14T02:50:11Z

TPC-H: Total hot run time: 40050 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7990a70c54aca07ec325ce9ab118795ad0ac7141, data reload: false
------ Round 1 ----------------------------------
q1	17568	6895	6588	6588
q2	2047	162	188	162
q3	10770	1078	1170	1078
q4	10519	710	763	710
q5	7761	2906	2871	2871
q6	220	134	131	131
q7	969	619	594	594
q8	9341	1975	1985	1975
q9	6585	6363	6379	6363
q10	7032	2285	2280	2280
q11	464	261	261	261
q12	397	215	212	212
q13	17798	2981	3013	2981
q14	243	215	223	215
q15	502	473	461	461
q16	686	586	596	586
q17	977	517	582	517
q18	7244	6582	6584	6582
q19	1400	1075	1043	1043
q20	475	208	205	205
q21	4069	3244	3303	3244
q22	1074	997	991	991
Total cold run time: 108141 ms
Total hot run time: 40050 ms
----- Round 2, with runtime_filter_mode=off -----
q1	6596	6530	6536	6530
q2	329	234	239	234
q3	2864	2752	2882	2752
q4	2018	1787	1777	1777
q5	5794	5769	5717	5717
q6	212	128	129	128
q7	2252	1815	1787	1787
q8	3337	3561	3523	3523
q9	8905	8762	8950	8762
q10	3585	3545	3473	3473
q11	590	489	483	483
q12	817	567	620	567
q13	10108	3173	3197	3173
q14	305	271	272	271
q15	513	463	460	460
q16	689	647	650	647
q17	1841	1625	1625	1625
q18	8086	7701	7713	7701
q19	1702	1542	1408	1408
q20	2035	1783	1856	1783
q21	5512	5359	5258	5258
q22	1107	1072	1027	1027
Total cold run time: 69197 ms
Total hot run time: 59086 ms

hello-stephen · 2025-05-14T03:00:03Z

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	40.98% (10811/26381)
Line Coverage	31.83% (92335/290092)
Region Coverage	30.90% (47654/154197)
Branch Coverage	27.41% (24422/89102)

doris-robot · 2025-05-14T03:02:46Z

TPC-DS: Total hot run time: 196780 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7990a70c54aca07ec325ce9ab118795ad0ac7141, data reload: false
query1	1276	920	914	914
query2	6339	2085	2044	2044
query3	10845	4274	4285	4274
query4	61200	29306	23547	23547
query5	5251	462	451	451
query6	399	167	180	167
query7	5475	309	308	308
query8	298	207	208	207
query9	8830	2581	2573	2573
query10	459	262	259	259
query11	17630	15155	15924	15155
query12	160	124	109	109
query13	1509	446	434	434
query14	10292	7310	6707	6707
query15	204	188	176	176
query16	7100	487	451	451
query17	1190	559	562	559
query18	1848	330	311	311
query19	209	154	145	145
query20	115	106	113	106
query21	207	103	104	103
query22	4628	4466	4895	4466
query23	34598	34207	34526	34207
query24	6211	2969	2958	2958
query25	537	428	428	428
query26	652	179	169	169
query27	1805	354	365	354
query28	4070	2468	2424	2424
query29	712	455	446	446
query30	253	169	167	167
query31	980	813	813	813
query32	63	57	58	57
query33	444	286	291	286
query34	912	506	508	506
query35	845	759	765	759
query36	1074	950	937	937
query37	115	69	71	69
query38	4040	3939	3939	3939
query39	1539	1464	1507	1464
query40	209	101	102	101
query41	52	53	51	51
query42	121	101	104	101
query43	550	491	481	481
query44	1150	815	813	813
query45	197	170	173	170
query46	1151	717	720	717
query47	2048	1907	1944	1907
query48	487	397	421	397
query49	770	430	415	415
query50	859	419	416	416
query51	7394	7210	7186	7186
query52	105	90	90	90
query53	261	193	192	192
query54	607	474	472	472
query55	81	78	78	78
query56	262	233	254	233
query57	1272	1144	1154	1144
query58	219	207	207	207
query59	3194	3119	3025	3025
query60	281	270	260	260
query61	118	110	107	107
query62	790	697	698	697
query63	217	187	183	183
query64	1389	685	651	651
query65	3261	3182	3177	3177
query66	711	299	298	298
query67	15787	15502	15730	15502
query68	4137	581	556	556
query69	435	265	283	265
query70	1113	1118	1102	1102
query71	348	244	249	244
query72	6372	4104	3961	3961
query73	748	340	359	340
query74	10217	9115	9002	9002
query75	3319	2680	2624	2624
query76	1992	1017	1019	1017
query77	514	280	260	260
query78	10527	9719	9527	9527
query79	2313	587	612	587
query80	1403	430	420	420
query81	536	247	236	236
query82	1223	89	87	87
query83	270	144	144	144
query84	280	80	75	75
query85	1029	300	295	295
query86	394	304	283	283
query87	4404	4249	4243	4243
query88	3828	2388	2355	2355
query89	425	289	290	289
query90	1960	178	184	178
query91	181	151	157	151
query92	62	50	51	50
query93	2858	552	541	541
query94	805	288	298	288
query95	369	255	250	250
query96	627	288	286	286
query97	3298	3116	3143	3116
query98	209	201	192	192
query99	1576	1322	1296	1296
Total cold run time: 315629 ms
Total hot run time: 196780 ms

doris-robot · 2025-05-14T03:08:14Z

ClickBench: Total hot run time: 31.56 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7990a70c54aca07ec325ce9ab118795ad0ac7141, data reload: false
query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.11	0.10
query5	0.52	0.49	0.52
query6	1.15	0.72	0.74
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.57	0.49	0.51
query10	0.54	0.56	0.56
query11	0.14	0.10	0.10
query12	0.15	0.11	0.10
query13	0.62	0.59	0.60
query14	2.86	2.72	2.72
query15	0.89	0.82	0.82
query16	0.38	0.39	0.38
query17	1.06	1.07	1.05
query18	0.23	0.22	0.22
query19	1.88	1.85	2.03
query20	0.02	0.01	0.02
query21	15.36	0.60	0.58
query22	2.50	2.49	2.07
query23	16.85	1.05	0.80
query24	2.98	1.98	0.12
query25	0.23	0.16	0.26
query26	0.21	0.14	0.14
query27	0.04	0.04	0.05
query28	10.53	0.52	0.46
query29	12.56	3.27	3.22
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.27	0.47	0.46
query33	2.98	3.02	3.02
query34	17.10	4.52	4.47
query35	4.56	4.48	4.45
query36	0.69	0.48	0.47
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.48 s
Total hot run time: 31.56 s

github-actionsBot requested a review from dataroaring as a code owner May 7, 2025 11:19

dataroaring closed this May 7, 2025

dataroaring reopened this May 7, 2025

dataroaring approved these changes May 8, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 8, 2025

github-actionsBot added the reviewed label May 8, 2025

dataroaring force-pushed the auto-pick-50628-branch-3.0 branch from a640332 to 7990a70Compare May 13, 2025 14:12

dataroaring merged commit 7ad2185 into branch-3.0May 14, 2025

github-actionsBot deleted the auto-pick-50628-branch-3.0 branch May 14, 2025 13:00

Navigation Menu

Uh oh!

branch-3.0: [fix](ubsan) fix ubsan error in DataTypeHLL::serialize #50628 - #50668

branch-3.0: [fix](ubsan) fix ubsan error in DataTypeHLL::serialize #50628#50668
dataroaring merged 1 commit into
branch-3.0from
auto-pick-50628-branch-3.0

github-actionsBot commented May 7, 2025

Uh oh!

hello-stephen commented May 7, 2025

Uh oh!

hello-stephen commented May 7, 2025

Uh oh!

hello-stephen commented May 7, 2025

Uh oh!

dataroaring left a comment

Uh oh!

github-actionsBot commented May 8, 2025

Uh oh!

github-actionsBot commented May 8, 2025

Uh oh!

dataroaring commented May 14, 2025

Uh oh!

doris-robot commented May 14, 2025

Uh oh!

hello-stephen commented May 14, 2025

Uh oh!

doris-robot commented May 14, 2025

Uh oh!

doris-robot commented May 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

github-actionsBot commented May 7, 2025

Uh oh!

hello-stephen commented May 7, 2025

Uh oh!

hello-stephen commented May 7, 2025

Uh oh!

hello-stephen commented May 7, 2025

BE UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented May 8, 2025

Uh oh!

github-actionsBot commented May 8, 2025

Uh oh!

dataroaring commented May 14, 2025

Uh oh!

doris-robot commented May 14, 2025

Uh oh!

hello-stephen commented May 14, 2025

BE UT Coverage Report

Uh oh!

doris-robot commented May 14, 2025

Uh oh!

doris-robot commented May 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants