[fix](cloud) potential data race when retrying prepare/commit rowset for load by liaoxin01 · Pull Request #51129 · apache/doris

liaoxin01 · 2025-05-22T01:59:19Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
If the transaction has been finished, it means the prepare/commit rowset is a timeout retry request. In this case, do not write the recycle key again, otherwise it may cause data loss.
Notice:
There is a compatibility issue with multi-statement transaction write operations during upgrades that could cause write operations to fail either before or during the meta service upgrade process.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-05-22T01:59:26Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

liaoxin01 · 2025-05-22T02:14:54Z

run buildall

liaoxin01 · 2025-05-22T06:26:17Z

run buildall

liaoxin01 · 2025-05-22T07:13:42Z

run buildall

doris-robot · 2025-05-22T07:55:47Z

TPC-H: Total hot run time: 33716 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 12c02b7923e43c1a78827b10dba0bbc3eb1607fa, data reload: false
------ Round 1 ----------------------------------
q1	26583	5012	4975	4975
q2	2059	310	196	196
q3	10366	1253	735	735
q4	10237	1003	527	527
q5	7589	2332	2335	2332
q6	188	162	131	131
q7	913	774	609	609
q8	9321	1288	1069	1069
q9	6913	5074	5062	5062
q10	6867	2324	1897	1897
q11	487	284	283	283
q12	349	364	209	209
q13	17758	3666	3051	3051
q14	239	240	213	213
q15	528	476	491	476
q16	431	439	378	378
q17	613	860	362	362
q18	7594	7133	7066	7066
q19	1808	961	548	548
q20	337	346	225	225
q21	3812	3152	2403	2403
q22	1078	981	969	969
Total cold run time: 116070 ms
Total hot run time: 33716 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5186	5061	5033	5033
q2	237	327	230	230
q3	2188	2641	2270	2270
q4	1357	1768	1331	1331
q5	4483	4403	4420	4403
q6	223	169	130	130
q7	2054	1920	1768	1768
q8	2613	2628	2604	2604
q9	7363	7338	7019	7019
q10	3054	3172	2720	2720
q11	580	515	511	511
q12	688	781	624	624
q13	3533	3883	3282	3282
q14	285	317	292	292
q15	528	477	474	474
q16	437	474	441	441
q17	1158	1513	1430	1430
q18	7909	7575	7619	7575
q19	836	837	970	837
q20	2000	1963	1819	1819
q21	4906	4576	4640	4576
q22	1121	1072	1032	1032
Total cold run time: 52739 ms
Total hot run time: 50401 ms

doris-robot · 2025-05-22T08:08:03Z

TPC-DS: Total hot run time: 192328 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 12c02b7923e43c1a78827b10dba0bbc3eb1607fa, data reload: false
query1	1431	1086	1054	1054
query2	6360	1871	1868	1868
query3	10998	4605	4566	4566
query4	55639	25386	23135	23135
query5	5179	530	460	460
query6	362	208	217	208
query7	4914	511	284	284
query8	311	241	242	241
query9	5903	2620	2625	2620
query10	427	321	258	258
query11	15168	15020	14850	14850
query12	151	109	105	105
query13	1061	536	404	404
query14	10217	6216	6297	6216
query15	214	199	180	180
query16	7075	650	480	480
query17	1091	746	582	582
query18	1564	427	328	328
query19	205	197	175	175
query20	135	126	119	119
query21	214	128	131	128
query22	4605	4598	4293	4293
query23	34528	33842	33638	33638
query24	7150	2445	2449	2445
query25	499	461	404	404
query26	696	279	152	152
query27	2333	505	342	342
query28	3241	2179	2153	2153
query29	580	568	438	438
query30	282	228	195	195
query31	894	866	780	780
query32	79	60	63	60
query33	442	373	322	322
query34	778	861	528	528
query35	803	865	748	748
query36	974	990	902	902
query37	112	101	82	82
query38	4309	4257	4190	4190
query39	1505	1466	1432	1432
query40	216	127	114	114
query41	56	54	51	51
query42	128	114	111	111
query43	502	515	495	495
query44	1338	828	823	823
query45	183	174	164	164
query46	836	1041	662	662
query47	1881	1856	1840	1840
query48	401	428	313	313
query49	700	515	433	433
query50	662	694	415	415
query51	4252	4246	4198	4198
query52	113	112	98	98
query53	224	260	186	186
query54	590	590	514	514
query55	93	84	93	84
query56	332	297	297	297
query57	1202	1230	1155	1155
query58	269	267	259	259
query59	2705	2840	2778	2778
query60	349	328	316	316
query61	133	127	132	127
query62	734	733	684	684
query63	228	197	190	190
query64	1762	1032	696	696
query65	4317	4249	4237	4237
query66	722	400	304	304
query67	16116	15684	15314	15314
query68	7268	872	518	518
query69	539	307	279	279
query70	1200	1098	1049	1049
query71	510	332	292	292
query72	5943	4798	4815	4798
query73	1416	644	351	351
query74	9042	9001	8674	8674
query75	3775	3204	2715	2715
query76	4167	1186	768	768
query77	637	362	289	289
query78	10166	10172	9278	9278
query79	2324	810	576	576
query80	684	510	439	439
query81	477	260	226	226
query82	444	123	95	95
query83	258	250	244	244
query84	294	108	81	81
query85	777	348	313	313
query86	406	345	298	298
query87	4353	4452	4334	4334
query88	3514	2280	2261	2261
query89	399	312	281	281
query90	1786	218	212	212
query91	146	146	117	117
query92	71	63	55	55
query93	1988	919	577	577
query94	676	395	314	314
query95	375	291	291	291
query96	505	571	282	282
query97	2754	2777	2632	2632
query98	227	204	203	203
query99	1431	1394	1263	1263
Total cold run time: 302025 ms
Total hot run time: 192328 ms

doris-robot · 2025-05-22T08:13:17Z

ClickBench: Total hot run time: 29.58 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 12c02b7923e43c1a78827b10dba0bbc3eb1607fa, data reload: false
query1	0.04	0.04	0.03
query2	0.15	0.10	0.11
query3	0.34	0.20	0.20
query4	1.59	0.19	0.19
query5	0.48	0.45	0.45
query6	1.16	0.65	0.66
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.61	0.53	0.51
query10	0.57	0.58	0.57
query11	0.26	0.13	0.12
query12	0.25	0.13	0.14
query13	0.63	0.62	0.63
query14	0.80	0.83	0.83
query15	0.96	0.88	0.86
query16	0.37	0.36	0.37
query17	1.09	1.02	1.08
query18	0.17	0.19	0.18
query19	1.99	1.83	1.88
query20	0.02	0.02	0.01
query21	15.42	1.00	0.67
query22	0.93	1.09	0.79
query23	14.70	1.55	0.75
query24	5.19	0.65	0.31
query25	0.17	0.10	0.08
query26	0.56	0.22	0.18
query27	0.09	0.09	0.08
query28	11.08	1.23	0.59
query29	12.52	4.15	3.39
query30	0.27	0.08	0.06
query31	2.82	0.63	0.42
query32	3.23	0.59	0.50
query33	3.05	3.14	3.10
query34	16.71	5.08	4.38
query35	4.50	4.41	4.49
query36	0.64	0.50	0.48
query37	0.21	0.17	0.17
query38	0.17	0.16	0.16
query39	0.05	0.04	0.04
query40	0.19	0.16	0.16
query41	0.11	0.06	0.05
query42	0.06	0.04	0.05
query43	0.06	0.05	0.05
Total cold run time: 104.29 s
Total hot run time: 29.58 s

liaoxin01 · 2025-05-23T02:01:32Z

run buildall

doris-robot · 2025-05-23T03:27:49Z

TPC-H: Total hot run time: 33958 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08c3697b2e7e31492e183bdcbbc67d922f889c7c, data reload: false
------ Round 1 ----------------------------------
q1	26553	5186	5133	5133
q2	2087	281	192	192
q3	10446	1282	709	709
q4	10236	1052	517	517
q5	7529	2451	2329	2329
q6	190	162	135	135
q7	978	735	614	614
q8	9307	1372	1068	1068
q9	6895	5092	5097	5092
q10	6882	2323	1889	1889
q11	491	291	272	272
q12	350	354	232	232
q13	17801	3695	3097	3097
q14	233	229	211	211
q15	534	487	475	475
q16	440	436	380	380
q17	630	887	378	378
q18	7731	7277	7085	7085
q19	1624	970	596	596
q20	334	346	233	233
q21	3934	3181	2352	2352
q22	1060	1000	969	969
Total cold run time: 116265 ms
Total hot run time: 33958 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5250	5137	5142	5137
q2	245	324	240	240
q3	2187	2704	2292	2292
q4	1412	1828	1513	1513
q5	4505	4420	4460	4420
q6	225	170	130	130
q7	2030	1943	1782	1782
q8	2614	2497	2611	2497
q9	7297	7174	7208	7174
q10	3003	3164	2784	2784
q11	603	522	513	513
q12	728	784	604	604
q13	3532	3970	3407	3407
q14	279	305	263	263
q15	519	464	476	464
q16	449	498	442	442
q17	1199	1546	1410	1410
q18	7851	7654	7642	7642
q19	884	857	966	857
q20	2000	2041	1866	1866
q21	4900	4501	4345	4345
q22	1143	1080	1012	1012
Total cold run time: 52855 ms
Total hot run time: 50794 ms

doris-robot · 2025-05-23T03:40:06Z

TPC-DS: Total hot run time: 193674 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08c3697b2e7e31492e183bdcbbc67d922f889c7c, data reload: false
query1	1400	1093	1078	1078
query2	6249	1810	1784	1784
query3	11042	4504	4589	4504
query4	54177	26001	23674	23674
query5	5180	599	452	452
query6	378	205	193	193
query7	5006	532	284	284
query8	316	247	221	221
query9	5891	2702	2686	2686
query10	447	342	276	276
query11	15084	15101	14778	14778
query12	167	111	104	104
query13	1101	543	414	414
query14	10190	6376	6513	6376
query15	205	204	187	187
query16	7118	665	508	508
query17	1110	774	615	615
query18	1558	431	347	347
query19	208	206	187	187
query20	134	121	121	121
query21	204	135	114	114
query22	4433	4466	4464	4464
query23	34281	33527	33927	33527
query24	6609	2435	2494	2435
query25	485	463	405	405
query26	729	281	154	154
query27	2355	516	351	351
query28	3143	2213	2185	2185
query29	604	555	459	459
query30	276	219	192	192
query31	873	850	789	789
query32	71	64	67	64
query33	464	421	306	306
query34	814	866	545	545
query35	812	863	754	754
query36	928	1030	910	910
query37	124	108	82	82
query38	4357	4264	4209	4209
query39	1701	1492	1481	1481
query40	211	129	111	111
query41	57	54	55	54
query42	124	111	115	111
query43	507	535	512	512
query44	1411	877	847	847
query45	186	185	173	173
query46	861	1040	650	650
query47	1826	1870	1793	1793
query48	413	453	351	351
query49	676	529	446	446
query50	698	709	405	405
query51	4340	4362	4219	4219
query52	116	114	97	97
query53	229	264	183	183
query54	607	608	520	520
query55	87	82	94	82
query56	336	316	316	316
query57	1206	1177	1142	1142
query58	274	281	271	271
query59	2715	2855	2574	2574
query60	356	336	333	333
query61	129	129	124	124
query62	722	729	663	663
query63	225	185	186	185
query64	1808	1019	668	668
query65	4325	4223	4234	4223
query66	732	401	304	304
query67	15987	15819	15508	15508
query68	6589	909	539	539
query69	545	313	286	286
query70	1192	1147	1102	1102
query71	520	321	302	302
query72	5954	4773	4819	4773
query73	1439	620	358	358
query74	9178	8913	8794	8794
query75	4097	3218	2795	2795
query76	4262	1183	745	745
query77	743	392	297	297
query78	10179	10175	9297	9297
query79	2408	807	574	574
query80	627	539	453	453
query81	476	264	221	221
query82	433	135	99	99
query83	306	258	245	245
query84	291	112	98	98
query85	789	354	316	316
query86	366	298	280	280
query87	4486	4404	4426	4404
query88	3530	2313	2330	2313
query89	411	331	303	303
query90	1902	218	215	215
query91	141	140	114	114
query92	73	60	60	60
query93	1829	974	580	580
query94	672	414	288	288
query95	379	303	289	289
query96	500	588	281	281
query97	2715	2797	2678	2678
query98	245	208	203	203
query99	1449	1383	1292	1292
Total cold run time: 300114 ms
Total hot run time: 193674 ms

doris-robot · 2025-05-23T03:45:21Z

ClickBench: Total hot run time: 29.95 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08c3697b2e7e31492e183bdcbbc67d922f889c7c, data reload: false
query1	0.03	0.03	0.03
query2	0.14	0.10	0.11
query3	0.36	0.20	0.20
query4	1.59	0.20	0.20
query5	0.47	0.45	0.47
query6	1.15	0.66	0.67
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.62	0.52	0.52
query10	0.58	0.58	0.59
query11	0.26	0.13	0.12
query12	0.25	0.14	0.13
query13	0.63	0.62	0.64
query14	0.81	0.84	0.82
query15	0.98	0.89	0.87
query16	0.38	0.37	0.38
query17	1.07	1.07	1.02
query18	0.19	0.19	0.18
query19	1.96	1.90	1.84
query20	0.01	0.02	0.01
query21	15.42	0.97	0.67
query22	0.94	1.02	0.86
query23	14.67	1.52	0.78
query24	5.40	0.58	0.29
query25	0.17	0.09	0.08
query26	0.56	0.22	0.18
query27	0.09	0.09	0.09
query28	11.02	1.21	0.59
query29	12.55	4.09	3.49
query30	0.29	0.09	0.08
query31	2.81	0.62	0.44
query32	3.24	0.60	0.51
query33	3.10	3.13	3.09
query34	16.50	5.12	4.42
query35	4.45	4.52	4.44
query36	0.65	0.50	0.50
query37	0.20	0.18	0.17
query38	0.17	0.15	0.15
query39	0.05	0.04	0.04
query40	0.20	0.15	0.16
query41	0.10	0.07	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 104.24 s
Total hot run time: 29.95 s

hello-stephen · 2025-05-23T04:46:57Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.00% (14918/26640)
Line Coverage	44.79% (132703/296276)
Region Coverage	43.85% (66705/152109)
Branch Coverage	38.48% (34215/88920)

hello-stephen · 2025-05-23T05:39:40Z

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	79.56% (20864/26223)
Line Coverage	72.74% (215514/296263)
Region Coverage	70.89% (126646/178653)
Branch Coverage	64.66% (65664/101558)

liaoxin01 · 2025-05-24T14:18:49Z

run buildall

liaoxin01 · 2025-05-24T15:00:47Z

run buildall

doris-robot · 2025-05-24T15:19:45Z

Cloud UT Coverage Report

Increment line coverage 72.41% (42/58) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	83.26% (1114/1338)
Line Coverage	66.17% (18713/28282)
Region Coverage	65.87% (9293/14108)
Branch Coverage	55.68% (5003/8986)

doris-robot · 2025-05-24T16:38:14Z

TPC-H: Total hot run time: 33880 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 490a438f754c71776b603193cf2bfe6bdca3d54d, data reload: false
------ Round 1 ----------------------------------
q1	26381	5075	5011	5011
q2	2078	296	199	199
q3	10472	1245	682	682
q4	10229	1008	512	512
q5	7648	2343	2345	2343
q6	180	162	138	138
q7	919	729	613	613
q8	9343	1268	1109	1109
q9	6860	5334	5090	5090
q10	6862	2290	1903	1903
q11	484	294	279	279
q12	337	345	216	216
q13	17804	3690	3064	3064
q14	233	226	217	217
q15	533	493	490	490
q16	416	434	378	378
q17	620	863	375	375
q18	7594	7295	7131	7131
q19	1998	958	563	563
q20	334	338	226	226
q21	3786	3194	2350	2350
q22	1050	1020	991	991
Total cold run time: 116161 ms
Total hot run time: 33880 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5233	5047	5062	5047
q2	235	326	234	234
q3	2161	2684	2324	2324
q4	1334	1757	1396	1396
q5	4451	4482	4424	4424
q6	217	167	130	130
q7	2039	1959	1787	1787
q8	2583	2509	2500	2500
q9	7319	7134	7123	7123
q10	3006	3188	2792	2792
q11	570	518	499	499
q12	698	798	634	634
q13	3468	3884	3356	3356
q14	300	289	263	263
q15	516	474	484	474
q16	451	503	430	430
q17	1166	1607	1365	1365
q18	7732	7773	7365	7365
q19	798	952	941	941
q20	1945	1973	1835	1835
q21	4861	4428	4325	4325
q22	1096	1068	1010	1010
Total cold run time: 52179 ms
Total hot run time: 50254 ms

doris-robot · 2025-05-24T16:50:29Z

TPC-DS: Total hot run time: 192763 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 490a438f754c71776b603193cf2bfe6bdca3d54d, data reload: false
query1	1437	1056	1051	1051
query2	6202	1787	1793	1787
query3	11057	4642	4312	4312
query4	55607	25185	23244	23244
query5	5296	521	465	465
query6	357	221	197	197
query7	4942	501	298	298
query8	339	268	243	243
query9	6075	2610	2625	2610
query10	428	349	272	272
query11	14994	15045	14858	14858
query12	163	106	104	104
query13	1035	524	417	417
query14	10147	6529	6358	6358
query15	198	206	185	185
query16	7110	670	496	496
query17	1094	769	643	643
query18	1566	432	316	316
query19	207	194	189	189
query20	137	133	127	127
query21	215	132	116	116
query22	4414	4409	4342	4342
query23	34243	33620	33588	33588
query24	7283	2434	2448	2434
query25	456	474	407	407
query26	680	274	153	153
query27	2265	518	376	376
query28	3177	2181	2140	2140
query29	579	575	436	436
query30	273	223	195	195
query31	857	858	783	783
query32	81	65	70	65
query33	461	364	317	317
query34	797	861	532	532
query35	809	824	741	741
query36	953	1026	899	899
query37	113	96	78	78
query38	4284	4257	4214	4214
query39	1530	1466	1464	1464
query40	222	121	115	115
query41	53	52	50	50
query42	124	113	115	113
query43	514	502	478	478
query44	1359	854	861	854
query45	187	175	170	170
query46	872	1039	656	656
query47	1833	1907	1820	1820
query48	416	435	341	341
query49	683	524	432	432
query50	688	694	414	414
query51	4214	4307	4200	4200
query52	117	111	105	105
query53	236	263	204	204
query54	606	594	519	519
query55	86	84	82	82
query56	313	315	292	292
query57	1203	1207	1129	1129
query58	276	261	261	261
query59	2765	2816	2644	2644
query60	375	339	326	326
query61	135	123	134	123
query62	757	736	640	640
query63	224	186	191	186
query64	1453	1036	709	709
query65	4326	4206	4204	4204
query66	725	410	297	297
query67	15947	15610	15562	15562
query68	7072	894	531	531
query69	536	305	268	268
query70	1115	1171	1115	1115
query71	501	331	301	301
query72	5958	4839	4867	4839
query73	1385	676	363	363
query74	8986	9102	8651	8651
query75	3822	3279	2647	2647
query76	4173	1194	780	780
query77	652	367	274	274
query78	10175	10269	9431	9431
query79	2242	789	574	574
query80	612	509	432	432
query81	482	260	222	222
query82	460	122	95	95
query83	256	245	239	239
query84	345	101	79	79
query85	780	356	309	309
query86	400	323	302	302
query87	4519	4511	4362	4362
query88	3730	2326	2324	2324
query89	401	316	285	285
query90	1795	208	215	208
query91	147	171	122	122
query92	72	64	60	60
query93	1899	931	584	584
query94	676	413	310	310
query95	373	291	289	289
query96	497	565	282	282
query97	2716	2727	2623	2623
query98	235	213	204	204
query99	1359	1392	1280	1280
Total cold run time: 300941 ms
Total hot run time: 192763 ms

doris-robot · 2025-05-24T16:55:44Z

ClickBench: Total hot run time: 29.73 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 490a438f754c71776b603193cf2bfe6bdca3d54d, data reload: false
query1	0.03	0.03	0.04
query2	0.15	0.11	0.10
query3	0.34	0.20	0.20
query4	1.59	0.22	0.20
query5	0.49	0.45	0.44
query6	1.17	0.65	0.66
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.63	0.53	0.52
query10	0.58	0.58	0.58
query11	0.26	0.14	0.13
query12	0.25	0.14	0.13
query13	0.63	0.62	0.62
query14	0.80	0.82	0.84
query15	0.96	0.87	0.89
query16	0.36	0.38	0.37
query17	1.03	1.06	1.05
query18	0.20	0.20	0.18
query19	1.95	1.83	1.86
query20	0.02	0.02	0.01
query21	15.40	0.97	0.67
query22	0.93	0.98	0.77
query23	14.74	1.49	0.76
query24	5.25	0.58	0.30
query25	0.17	0.10	0.09
query26	0.55	0.23	0.18
query27	0.09	0.08	0.09
query28	11.08	1.13	0.58
query29	12.55	4.15	3.38
query30	0.27	0.08	0.06
query31	2.82	0.63	0.45
query32	3.22	0.60	0.51
query33	3.07	3.07	3.16
query34	16.42	5.17	4.43
query35	4.51	4.47	4.48
query36	0.64	0.51	0.50
query37	0.20	0.18	0.17
query38	0.18	0.15	0.16
query39	0.05	0.04	0.05
query40	0.20	0.18	0.15
query41	0.10	0.05	0.05
query42	0.07	0.06	0.05
query43	0.06	0.04	0.04
Total cold run time: 104.08 s
Total hot run time: 29.73 s

doris-robot · 2025-05-25T16:26:19Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	56.00% (14920/26644)
Line Coverage	44.82% (132841/296391)
Region Coverage	43.90% (66777/152119)
Branch Coverage	38.52% (34265/88944)

hello-stephen · 2025-05-25T16:31:28Z

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	79.58% (20872/26227)
Line Coverage	72.79% (215741/296378)
Region Coverage	70.99% (126807/178626)
Branch Coverage	64.79% (65811/101570)

github-actions · 2025-05-30T08:19:59Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-05-30T08:20:01Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

…for load (#51129) If the transaction has been finished, it means the prepare/commit rowset is a timeout retry request. In this case, do not write the recycle key again, otherwise it may cause data loss. **Notice**: There is a compatibility issue with multi-statement transaction write operations during upgrades that could cause write operations to fail either before or during the meta service upgrade process.

…mmit rowset for load #51129 (#51483) Cherry-picked from #51129 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

…trying prepare rowset (#51048) related PR #51129

…trying prepare rowset (apache#51048) related PR apache#51129

…trying prepare rowset (#51048) (#51852) related PR #51129 pick master #51048

…mmit rowset for load #51129 (#51483) Cherry-picked from #51129 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

…trying prepare rowset (#51048) (#51852) related PR #51129 pick master #51048

…trying prepare rowset (apache#51048) related PR apache#51129

…race when retrying prepare rowset #51048 (#52075) related PR #51129 pick master #51048

…for load (apache#51129) (apache#4066) pick from: apache#51129 If the transaction has been finished, it means the prepare/commit rowset is a timeout retry request. In this case, do not write the recycle key again, otherwise it may cause data loss. **Notice**: There is a compatibility issue with multi-statement transaction write operations during upgrades that could cause write operations to fail either before or during the meta service upgrade process.

…trying prepare rowset (apache#51048) (apache#4097) related PR apache#51129

…for load (apache#51129) (apache#4106) pick from: apache#51129 If the transaction has been finished, it means the prepare/commit rowset is a timeout retry request. In this case, do not write the recycle key again, otherwise it may cause data loss. **Notice**: There is a compatibility issue with multi-statement transaction write operations during upgrades that could cause write operations to fail either before or during the meta service upgrade process.

…trying prepare rowset (apache#51048) (apache#4103) related PR apache#51129

liaoxin01 requested review from dataroaring, gavinchou and w41ter as code owners May 22, 2025 01:59

liaoxin01 changed the title ~~[fix](cloud) potential data race when retrying prepare rowset for load~~[fix](cloud) potential data race when retrying prepare/commit rowset for loadMay 22, 2025

liaoxin01 force-pushed the fix-prepare-rowset branch from 12c02b7 to ffb0128Compare May 22, 2025 07:12

liaoxin01 force-pushed the fix-prepare-rowset branch from ffb0128 to 08c3697Compare May 23, 2025 02:00

dataroaring added dev/3.0.x p0_l labels May 26, 2025

gavinchou reviewed May 26, 2025
View reviewed changes

Comment threadcloud/src/meta-service/meta_service.cpp

gavinchou approved these changes May 30, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 30, 2025

github-actionsBot added the reviewed label May 30, 2025

dataroaring approved these changes Jun 4, 2025
View reviewed changes

liaoxin01 merged commit 5cdc082 into apache:masterJun 4, 2025

liaoxin01 deleted the fix-prepare-rowset branch June 4, 2025 08:33

github-actionsBot mentioned this pull request Jun 4, 2025
branch-3.0: [fix](cloud) potential data race when retrying prepare/commit rowset for load #51129 #51483
Merged

dataroaring pushed a commit that referenced this pull request Jun 11, 2025
branch-3.0: [fix](cloud) potential data race when retrying prepare/co…
7247a23
…mmit rowset for load #51129 (#51483) Cherry-picked from #51129 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

dataroaring added dev/3.0.7-merged and removed dev/3.0.x labels Jun 11, 2025

This was referenced Jun 12, 2025
[fix](cloud) compaction and schema change potential data race when retrying prepare rowset #51048
Merged
[fix](meta-service) Read recycle rowset key before removing when commit rowset #46657
Closed

gavinchou pushed a commit that referenced this pull request Jun 12, 2025
[fix](cloud) compaction and schema change potential data race when re…
b31648a
…trying prepare rowset (#51048) related PR #51129

morrySnow added the dev/3.1.0-merged label Jun 17, 2025

luwei16 added a commit to luwei16/Doris that referenced this pull request Jun 18, 2025
[fix](cloud) compaction and schema change potential data race when re…
312dd52
…trying prepare rowset (apache#51048) related PR apache#51129

luwei16 mentioned this pull request Jun 18, 2025
[fix](cloud) compaction and schema change potential data race when retrying prepare rowset (#51048) #51852
Merged

dataroaring pushed a commit that referenced this pull request Jun 18, 2025
[fix](cloud) compaction and schema change potential data race when re…
9d727d6
…trying prepare rowset (#51048) (#51852) related PR #51129 pick master #51048

dataroaring pushed a commit that referenced this pull request Jun 18, 2025
branch-3.0: [fix](cloud) potential data race when retrying prepare/co…
7bc546c
…mmit rowset for load #51129 (#51483) Cherry-picked from #51129 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

dataroaring pushed a commit that referenced this pull request Jun 18, 2025
[fix](cloud) compaction and schema change potential data race when re…
1739fd2
…trying prepare rowset (#51048) (#51852) related PR #51129 pick master #51048

luwei16 added a commit to luwei16/Doris that referenced this pull request Jun 20, 2025
[fix](cloud) compaction and schema change potential data race when re…
eae4d1f
…trying prepare rowset (apache#51048) related PR apache#51129

luwei16 mentioned this pull request Jun 20, 2025
[fix](cloud) compaction and schema change potential data race when retrying prepare rowset (#51048) #52075
Merged

morrySnow pushed a commit that referenced this pull request Jun 23, 2025
branch-3.1: [fix](cloud) compaction and schema change potential data …
8eec696
…race when retrying prepare rowset #51048 (#52075) related PR #51129 pick master #51048

Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 21, 2025
[fix](cloud) compaction and schema change potential data race when re…
009bbac
…trying prepare rowset (apache#51048) (apache#4097) related PR apache#51129

Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Jul 30, 2025
[fix](cloud) compaction and schema change potential data race when re…
36c9a78
…trying prepare rowset (apache#51048) (apache#4103) related PR apache#51129

gavinchou mentioned this pull request Aug 15, 2025
Release Note 3.0.7 #54868
Closed

Uh oh!

Conversation

liaoxin01 commented May 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented May 22, 2025

Uh oh!

liaoxin01 commented May 22, 2025

Uh oh!

liaoxin01 commented May 22, 2025

Uh oh!

liaoxin01 commented May 22, 2025

Uh oh!

doris-robot commented May 22, 2025

Uh oh!

doris-robot commented May 22, 2025

Uh oh!

doris-robot commented May 22, 2025

Uh oh!

liaoxin01 commented May 23, 2025

Uh oh!

doris-robot commented May 23, 2025

Uh oh!

doris-robot commented May 23, 2025

Uh oh!

doris-robot commented May 23, 2025

Uh oh!

hello-stephen commented May 23, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented May 23, 2025

BE Regression && UT Coverage Report

Uh oh!

liaoxin01 commented May 24, 2025

Uh oh!

liaoxin01 commented May 24, 2025

Uh oh!

doris-robot commented May 24, 2025

Cloud UT Coverage Report

Uh oh!

doris-robot commented May 24, 2025

Uh oh!

doris-robot commented May 24, 2025

Uh oh!

doris-robot commented May 24, 2025

Uh oh!

doris-robot commented May 25, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented May 25, 2025

BE Regression && UT Coverage Report

Uh oh!

Uh oh!

github-actionsBot commented May 30, 2025

Uh oh!

github-actionsBot commented May 30, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

liaoxin01 commented May 22, 2025•
edited
Loading