Skip to content

[fix](cloud) compaction and schema change potential data race when retrying prepare rowset (#51048) - #51852

Merged
dataroaring merged 1 commit into
apache:branch-3.0from
luwei16:luwei/fix-compact-prepare-3.0
Jun 18, 2025
Merged

[fix](cloud) compaction and schema change potential data race when retrying prepare rowset (#51048)#51852
dataroaring merged 1 commit into
apache:branch-3.0from
luwei16:luwei/fix-compact-prepare-3.0

Conversation

@luwei16

@luwei16luwei16 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

related PR #51129
pick master #51048

@Thearas

Thearas commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@luwei16

luwei16 commented Jun 18, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 90.00% (54/60) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage83.16% (1096/1318)
Line Coverage66.43% (18349/27621)
Region Coverage66.18% (9092/13739)
Branch Coverage56.05% (4930/8796)

@hello-stephen

hello-stephen commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage41.17% (10897/26467)
Line Coverage31.99% (93221/291417)
Region Coverage31.07% (48086/154783)
Branch Coverage27.54% (24638/89462)

dataroaring
dataroaring approved these changes Jun 18, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 9d727d6 into apache:branch-3.0Jun 18, 2025
dataroaring pushed a commit that referenced this pull request Jun 18, 2025
@luwei16Yongqiang YANG
[fix](cloud) compaction and schema change potential data race when re…
1739fd2
…trying prepare rowset (#51048) (#51852)
related PR #51129
pick master #51048
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luwei16@Thearas@hello-stephen@dataroaring