[fix](checker) Fix checking inverted index file incorrectly by wyxxxcat · Pull Request #53876 · apache/doris

wyxxxcat · 2025-07-25T01:43:15Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-07-25T01:43:19Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

wyxxxcat · 2025-07-25T08:45:39Z

run buildall

hello-stephen · 2025-07-25T09:05:16Z

Cloud UT Coverage Report

Increment line coverage 41.86% (90/215) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	80.42% (1302/1619)
Line Coverage	65.79% (21996/33434)
Region Coverage	66.96% (10989/16411)
Branch Coverage	56.48% (5782/10238)

wyxxxcat · 2025-07-25T10:41:46Z

run buildall

hello-stephen · 2025-07-25T10:52:53Z

Cloud UT Coverage Report

Increment line coverage 41.63% (87/209) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	80.38% (1303/1621)
Line Coverage	65.67% (21848/33270)
Region Coverage	66.92% (10984/16414)
Branch Coverage	56.47% (5781/10238)

github-actions · 2025-07-26T14:27:19Z

PR approved by anyone and no changes requested.

wyxxxcat · 2025-07-29T07:11:05Z

run buildall

wyxxxcat · 2025-07-29T08:45:05Z

run buildall

dataroaring

LGTM

wyxxxcat · 2025-07-31T07:07:13Z

run buildall

hello-stephen · 2025-07-31T07:19:44Z

Cloud UT Coverage Report

Increment line coverage 80.09% (169/211) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	80.71% (1343/1664)
Line Coverage	65.83% (23215/35266)
Region Coverage	66.97% (11505/17180)
Branch Coverage	56.56% (6035/10670)

Yukang-Lian · 2025-08-01T07:49:48Z

run cloud_p0

github-actions · 2025-08-01T15:23:43Z

PR approved by at least one committer and no changes requested.

…3876)

…index file incorrectly (#53876)" (#54334) Pick #53876 Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>

#53876 (#54333) Pick #53876 Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>

related #53876 test: ``` [ RUN ] CheckerTest.normal_check_index_file_v1 [ RUN ] CheckerTest.normal_inverted_check_index_file_v1 [ RUN ] CheckerTest.normal_check_index_file_v2 [ RUN ] CheckerTest.normal_inverted_check_index_file_v2 [ RUN ] CheckerTest.abnormal_check_index_file_v1 (loss key) [ RUN ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file) [ RUN ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file) [ RUN ] CheckerTest.abnormal_check_index_file_v2 (loss key) ```

wyxxxcat force-pushed the fix_checker branch from 99fc07b to a7dd364Compare July 25, 2025 08:23

wyxxxcat marked this pull request as ready for review July 25, 2025 08:23

wyxxxcat requested review from dataroaring, gavinchou and w41ter as code owners July 25, 2025 08:23

wyxxxcat force-pushed the fix_checker branch from a7dd364 to 664e00cCompare July 25, 2025 08:45

gavinchou reviewed Jul 25, 2025
View reviewed changes

Comment threadcloud/src/recycler/checker.cpp

wyxxxcat force-pushed the fix_checker branch from 664e00c to 73607eeCompare July 25, 2025 08:57

gavinchou reviewed Jul 25, 2025
View reviewed changes

Comment threadcloud/src/recycler/checker.cpp Outdated

wyxxxcat force-pushed the fix_checker branch from 73607ee to 412f118Compare July 25, 2025 09:30

wyxxxcat requested a review from gavinchou July 25, 2025 09:58

Yukang-Lian approved these changes Jul 26, 2025
View reviewed changes

github-actionsBot added the reviewed label Jul 26, 2025

gavinchou reviewed Jul 28, 2025
View reviewed changes

Comment threadcloud/src/recycler/checker.h Outdated

gavinchou requested changes Jul 28, 2025
View reviewed changes

Comment threadcloud/src/recycler/checker.h Outdated
Comment threadcloud/src/recycler/checker.cpp Outdated

wyxxxcat force-pushed the fix_checker branch 3 times, most recently from f996706 to 4c75035Compare July 29, 2025 07:10

1
200c9ce

wyxxxcat force-pushed the fix_checker branch from 4c75035 to 200c9ceCompare July 29, 2025 08:25

dataroaring previously approved these changes Jul 29, 2025
View reviewed changes

dataroaring added the dev/3.0.x label Jul 29, 2025

wyxxxcat dismissed stale reviews from gavinchou and dataroaring via e9207d5July 31, 2025 07:03

1
d9d287a

wyxxxcat force-pushed the fix_checker branch from e9207d5 to d9d287aCompare July 31, 2025 07:07

gavinchou approved these changes Aug 1, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 1, 2025

dataroaring merged commit eac4f7f into apache:masterAug 2, 2025
26 checks passed

dataroaring added the p0_test label Aug 2, 2025

github-actionsBot added dev/3.0.x-conflict dev/3.1.x-conflict labels Aug 2, 2025

Yukang-Lian pushed a commit to Yukang-Lian/doris that referenced this pull request Aug 5, 2025
[fix](checker) Fix checking inverted index file incorrectly (apache#5…
308a3e1
…3876)

Yukang-Lian mentioned this pull request Aug 5, 2025
branch-3.1: [fix](checker) Fix checking inverted index file incorrectly #53876 #54333
Merged

Yukang-Lian pushed a commit to Yukang-Lian/doris that referenced this pull request Aug 5, 2025
[fix](checker) Fix checking inverted index file incorrectly (apache#5…
aed6ca7
…3876)

Yukang-Lian mentioned this pull request Aug 5, 2025
[Cherry-Pick](branch-3.0) Pick "[fix](checker) Fix checking inverted index file incorrectly (#53876)" #54334
Merged
16 tasks

dataroaring pushed a commit that referenced this pull request Aug 5, 2025
[Cherry-Pick](branch-3.0) Pick "[fix](checker) Fix checking inverted …
d14aca0
…index file incorrectly (#53876)" (#54334) Pick #53876 Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Aug 5, 2025

morrySnow pushed a commit that referenced this pull request Aug 5, 2025
branch-3.1: [fix](checker) Fix checking inverted index file incorrectly
9ad6977
#53876 (#54333) Pick #53876 Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Aug 5, 2025

gavinchou mentioned this pull request Aug 6, 2025
[fix](checker) Fix inverted check and test for checker #54403
Merged

Uh oh!

Conversation

wyxxxcat commented Jul 25, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jul 25, 2025

Uh oh!

wyxxxcat commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

hello-stephen commented Jul 25, 2025

Cloud UT Coverage Report

Uh oh!

wyxxxcat commented Jul 25, 2025

Uh oh!

hello-stephen commented Jul 25, 2025

Cloud UT Coverage Report

Uh oh!

github-actionsBot commented Jul 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wyxxxcat commented Jul 29, 2025

Uh oh!

wyxxxcat commented Jul 29, 2025

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

wyxxxcat commented Jul 31, 2025

Uh oh!

hello-stephen commented Jul 31, 2025

Cloud UT Coverage Report

Uh oh!

Yukang-Lian commented Aug 1, 2025

Uh oh!

github-actionsBot commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants