Skip to content

[fix](checker) Fix inverted check and test for checker - #54403

Merged
dataroaring merged 1 commit into
apache:masterfrom
wyxxxcat:fix_inverted_check
Aug 7, 2025
Merged

[fix](checker) Fix inverted check and test for checker#54403
dataroaring merged 1 commit into
apache:masterfrom
wyxxxcat:fix_inverted_check

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Aug 6, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

related #53876

test:

[ RUN ] CheckerTest.normal_check_index_file_v1
[ RUN ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN ] CheckerTest.normal_check_index_file_v2
[ RUN ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN ] CheckerTest.abnormal_check_index_file_v2 (loss key)

@Thearas

Thearas commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat

wyxxxcat commented Aug 6, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat

wyxxxcat commented Aug 6, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 70.59% (12/17) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage81.79% (1406/1719)
Line Coverage66.03% (23975/36309)
Region Coverage67.25% (11894/17687)
Branch Coverage56.93% (6230/10944)

gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
gavinchou
gavinchou reviewed Aug 6, 2025
View reviewed changes
Comment threadcloud/src/recycler/checker.cpp Outdated
@wyxxxcat
wyxxxcat requested a review from gavinchouAugust 7, 2025 03:01
@wyxxxcat

wyxxxcat commented Aug 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 68.00% (17/25) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage81.79% (1406/1719)
Line Coverage66.09% (24010/36328)
Region Coverage67.35% (11921/17699)
Branch Coverage56.96% (6240/10956)

@wyxxxcat

wyxxxcat commented Aug 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

run cloud_p0

dataroaring
dataroaring approved these changes Aug 7, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2025
@github-actions

github-actionsBot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit 6c960c5 into apache:masterAug 7, 2025
29 of 30 checks passed
github-actionsBot pushed a commit that referenced this pull request Aug 7, 2025
@wyxxxcatYour Name
[fix](checker) Fix inverted check and test for checker (#54403)
e1ebae5
related #53876 test:
```
[ RUN ] CheckerTest.normal_check_index_file_v1
[ RUN ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN ] CheckerTest.normal_check_index_file_v2
[ RUN ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN ] CheckerTest.abnormal_check_index_file_v2 (loss key)
```
@github-actionsgithub-actionsBot mentioned this pull request Aug 7, 2025
Merged
github-actionsBot pushed a commit that referenced this pull request Aug 7, 2025
@wyxxxcatYour Name
[fix](checker) Fix inverted check and test for checker (#54403)
40cc00f
related #53876 test:
```
[ RUN ] CheckerTest.normal_check_index_file_v1
[ RUN ] CheckerTest.normal_inverted_check_index_file_v1
[ RUN ] CheckerTest.normal_check_index_file_v2
[ RUN ] CheckerTest.normal_inverted_check_index_file_v2
[ RUN ] CheckerTest.abnormal_check_index_file_v1 (loss key)
[ RUN ] CheckerTest.abnormal_inverted_check_index_file_v1 (loss file)
[ RUN ] CheckerTest.abnormal_inverted_check_index_file_v2 (loss file)
[ RUN ] CheckerTest.abnormal_check_index_file_v2 (loss key)
```
@github-actionsgithub-actionsBot mentioned this pull request Aug 7, 2025
Merged
dataroaring pushed a commit that referenced this pull request Aug 8, 2025
@github-actions@wyxxxcat
branch-3.0: [fix](checker) Fix inverted check and test for checker#5…
98bafae
…4403 (#54469)
Cherry-picked from #54403
Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
morrySnow pushed a commit that referenced this pull request Aug 8, 2025
@github-actions@wyxxxcat
branch-3.1: [fix](checker) Fix inverted check and test for checker#5…
e13fade
…4403 (#54470)
Cherry-picked from #54403
Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yukang-LianYukang-LianYukang-Lian approved these changes
@dataroaringdataroaringdataroaring approved these changes
@w41terw41terAwaiting requested review from w41ter
@gavinchougavinchouAwaiting requested review from gavinchougavinchou is a code owner

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.7-mergeddev/3.1.0-mergedp0_testreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wyxxxcat@Thearas@hello-stephen@gavinchou@Yukang-Lian@dataroaring@morrySnow