Uh oh!
There was an error while loading. Please reload this page.
[fix](parquet)fix parquet topn lazy mat complex data error result - #58785
Merged
Conversation
Thearas
commented
Dec 7, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hubgeterforce-pushed
the
fix_topn_complex
branch
from
December 8, 2025 03:19
8c6692b to
7db879bComparehubgeter
commented
Dec 8, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Dec 8, 2025
TPC-H: Total hot run time: 34889 ms |
doris-robot
commented
Dec 8, 2025
TPC-DS: Total hot run time: 179870 ms |
doris-robot
commented
Dec 8, 2025
ClickBench: Total hot run time: 27.26 s |
hubgeterforce-pushed
the
fix_topn_complex
branch
from
December 8, 2025 16:38
d701319 to
4616b96Comparehubgeter
commented
Dec 8, 2025
ContributorAuthor
run buildall |
hubgeterforce-pushed
the
fix_topn_complex
branch
from
December 9, 2025 09:33
4616b96 to
fb1123aComparehubgeter
commented
Dec 9, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Dec 9, 2025
TPC-DS: Total hot run time: 182047 ms |
doris-robot
commented
Dec 9, 2025
ClickBench: Total hot run time: 27.53 s |
hubgeterforce-pushed
the
fix_topn_complex
branch
from
December 9, 2025 16:59
fb1123a to
78603b7Comparehubgeter
commented
Dec 9, 2025
ContributorAuthor
run buildall |
hubgeter
commented
Dec 10, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Dec 10, 2025
TPC-H: Total hot run time: 35339 ms |
doris-robot
commented
Dec 10, 2025
TPC-DS: Total hot run time: 181983 ms |
doris-robot
commented
Dec 10, 2025
ClickBench: Total hot run time: 27.83 s |
hubgeter
commented
Dec 10, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Dec 10, 2025
TPC-H: Total hot run time: 35515 ms |
doris-robot
commented
Dec 10, 2025
TPC-DS: Total hot run time: 181931 ms |
doris-robot
commented
Dec 10, 2025
ClickBench: Total hot run time: 27.11 s |
hello-stephen
commented
Dec 10, 2025
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Dec 10, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hubgeter
marked this pull request as ready for review
December 11, 2025 03:06
Contributor
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Dec 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
hubgeter added a commit
to hubgeter/doris
that referenced
this pull request
Dec 17, 2025
…ache#58785) Related PR: apache#51329 Problem Summary: This PR primarily enables the Parquet reader to use page indexes when reading complex columns, and also fixes a data reading error in PR of topn.
16 tasks
yiguolei pushed a commit
that referenced
this pull request
Dec 22, 2025
… result (#58785) (#59129) bp #58785 Related PR: #51329 Problem Summary: This PR primarily enables the Parquet reader to use page indexes when reading complex columns, and also fixes a data reading error in PR of topn. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
16 tasks
kaka11chen pushed a commit
to kaka11chen/doris
that referenced
this pull request
Jan 7, 2026
…ache#58785) Related PR: apache#51329 Problem Summary: This PR primarily enables the Parquet reader to use page indexes when reading complex columns, and also fixes a data reading error in PR of topn.
Closed
16 tasks
morningman pushed a commit
that referenced
this pull request
Jan 16, 2026
…en reading Parquet scalar columns. (#59833) ### What problem does this PR solve? Related PR: #58785 Problem Summary: The performance rollback was introduced in #58785. The reason is that, prior to #58785, reading ordinary columns did not require filling and saving the RL DL. #58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
hubgeter added a commit
to hubgeter/doris
that referenced
this pull request
Jan 22, 2026
…en reading Parquet scalar columns. (apache#59833) Related PR: apache#58785 Problem Summary: The performance rollback was introduced in apache#58785. The reason is that, prior to apache#58785, reading ordinary columns did not require filling and saving the RL DL. apache#58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
yiguolei pushed a commit
that referenced
this pull request
Jan 22, 2026
…en reading Parquet scalar columns. (#59833) (#60130) Related PR: #58785 Problem Summary: The performance rollback was introduced in #58785. The reason is that, prior to #58785, reading ordinary columns did not require filling and saving the RL DL. #58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
Closed
zclllyybb pushed a commit
to zclllyybb/doris
that referenced
this pull request
Feb 9, 2026
…ache#58785) Related PR: apache#51329 Problem Summary: This PR primarily enables the Parquet reader to use page indexes when reading complex columns, and also fixes a data reading error in PR of topn.
ybtsdst pushed a commit
to ybtsdst/doris
that referenced
this pull request
Feb 27, 2026
…en reading Parquet scalar columns. (apache#59833) (apache#60130) Related PR: apache#58785 Problem Summary: The performance rollback was introduced in apache#58785. The reason is that, prior to apache#58785, reading ordinary columns did not require filling and saving the RL DL. apache#58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
16 tasks
Mryange added a commit
that referenced
this pull request
Apr 15, 2026
…_with_s3data (#62488) The regression test `datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data` was failing with a `CHAR result mismatch` on the `order_qt_sql_s3` tag. Root-cause analysis: 1. The S3 source files (`one_level_array.parquet`, `.orc`, `.csv`) in `oss://doris-regression-hk/regression/datalake/` have **not changed since 2024-07-27** (confirmed via `ossutil stat`). The parquet `c_bool` column is `list<bool>` (verified with pyarrow). The column type (`array<boolean>`) in the test plugin has also never changed. 2. On **2025-09-12**, commit `074d88b` (PR #55896, "fix cases from s3") added `WHERE k1 IS NOT NULL` to the query and regenerated the `.out`. At that time, Doris had a bug in reading parquet `list<bool>` values inside nested arrays, producing incorrect boolean values (e.g. `[0, 0, 1, 0, ...]` instead of the correct `[0, 0, 0, 1, 1, ...]`). 3. On **2025-12-16**, commit `0031179b1e6` (PR #58785, "fix parquet topn lazy mat complex data error result") refactored `ColumnChunkReader` to use `IN_COLLECTION`/`OFFSET_INDEX` template parameters, giving nested-array columns a distinct and correct read path. This fix incidentally corrected the boolean array reading for columns like `c_bool`. 4. After PR #58785 landed, Doris now reads parquet `list<bool>` correctly (matching pyarrow), but the `.out` file was never updated, causing the test to fail. Fix: force-regenerate `one_level_nestedtypes_with_s3data.out` using the current correct Doris behavior against the unchanged S3 data.
github-actionsBot
pushed a commit
that referenced
this pull request
May 15, 2026
…_with_s3data (#62488) The regression test `datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data` was failing with a `CHAR result mismatch` on the `order_qt_sql_s3` tag. Root-cause analysis: 1. The S3 source files (`one_level_array.parquet`, `.orc`, `.csv`) in `oss://doris-regression-hk/regression/datalake/` have **not changed since 2024-07-27** (confirmed via `ossutil stat`). The parquet `c_bool` column is `list<bool>` (verified with pyarrow). The column type (`array<boolean>`) in the test plugin has also never changed. 2. On **2025-09-12**, commit `074d88b` (PR #55896, "fix cases from s3") added `WHERE k1 IS NOT NULL` to the query and regenerated the `.out`. At that time, Doris had a bug in reading parquet `list<bool>` values inside nested arrays, producing incorrect boolean values (e.g. `[0, 0, 1, 0, ...]` instead of the correct `[0, 0, 0, 1, 1, ...]`). 3. On **2025-12-16**, commit `0031179b1e6` (PR #58785, "fix parquet topn lazy mat complex data error result") refactored `ColumnChunkReader` to use `IN_COLLECTION`/`OFFSET_INDEX` template parameters, giving nested-array columns a distinct and correct read path. This fix incidentally corrected the boolean array reading for columns like `c_bool`. 4. After PR #58785 landed, Doris now reads parquet `list<bool>` correctly (matching pyarrow), but the `.out` file was never updated, causing the test to fail. Fix: force-regenerate `one_level_nestedtypes_with_s3data.out` using the current correct Doris behavior against the unchanged S3 data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #51329
Problem Summary:
This PR primarily enables the Parquet reader to use page indexes when reading complex columns, and also fixes a data reading error in PR #51329 when materializing data based on row number in the second stage of topn.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)