Uh oh!
There was an error while loading. Please reload this page.
[fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. - #59833
Merged
Conversation
Thearas
commented
Jan 13, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hubgeter
commented
Jan 13, 2026
ContributorAuthor
run buildall |
doris-robot
commented
Jan 13, 2026
TPC-H: Total hot run time: 31757 ms |
doris-robot
commented
Jan 13, 2026
TPC-DS: Total hot run time: 172742 ms |
hubgeter
commented
Jan 13, 2026
ContributorAuthor
run buildall |
doris-robot
commented
Jan 13, 2026
TPC-H: Total hot run time: 31866 ms |
doris-robot
commented
Jan 13, 2026
TPC-DS: Total hot run time: 173527 ms |
doris-robot
commented
Jan 13, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
…en reading Parquet scalar columns.
hubgeterforce-pushed
the
fix_parquet_falt_slow
branch
from
January 14, 2026 02:50
1473e5e to
770f06aComparehubgeter
commented
Jan 14, 2026
ContributorAuthor
run buildall |
doris-robot
commented
Jan 14, 2026
TPC-H: Total hot run time: 31771 ms |
doris-robot
commented
Jan 14, 2026
TPC-DS: Total hot run time: 174300 ms |
doris-robot
commented
Jan 14, 2026
ClickBench: Total hot run time: 27.1 s |
doris-robot
commented
Jan 14, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jan 14, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Jan 15, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
hubgeter added a commit
to hubgeter/doris
that referenced
this pull request
Jan 22, 2026
…en reading Parquet scalar columns. (apache#59833) Related PR: apache#58785 Problem Summary: The performance rollback was introduced in apache#58785. The reason is that, prior to apache#58785, reading ordinary columns did not require filling and saving the RL DL. apache#58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
yiguolei pushed a commit
that referenced
this pull request
Jan 22, 2026
…en reading Parquet scalar columns. (#59833) (#60130) Related PR: #58785 Problem Summary: The performance rollback was introduced in #58785. The reason is that, prior to #58785, reading ordinary columns did not require filling and saving the RL DL. #58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
ybtsdst pushed a commit
to ybtsdst/doris
that referenced
this pull request
Feb 27, 2026
…en reading Parquet scalar columns. (apache#59833) (apache#60130) Related PR: apache#58785 Problem Summary: The performance rollback was introduced in apache#58785. The reason is that, prior to apache#58785, reading ordinary columns did not require filling and saving the RL DL. apache#58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #58785
Problem Summary:
The performance rollback was introduced in #58785. The reason is that, prior to #58785, reading ordinary columns did not require filling and saving the RL DL. #58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)