[chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness by gavinchou · Pull Request #59019 · apache/doris

gavinchou · 2025-12-14T06:57:46Z

The original implementation of do...while() check is not extensible for retry if we failed to do the first txn->get() in the while loop. It will end with referencing null pointer at the check while (it->more()), and the original pattern is easily misused/copied in a scenario needs retry.

No need to add new tests, the changes are covered by existing tests.

hello-stephen · 2025-12-14T06:57:51Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

gavinchou · 2025-12-14T07:00:50Z

run buildall

gavinchou · 2025-12-14T13:34:00Z

run cloud_ut

…>get() failed #59019 (#59020) fix first txn->get ends up with null pointer partial pick #59019

github-actions · 2025-12-15T10:09:44Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-12-15T10:09:47Z

PR approved by anyone and no changes requested.

gavinchou · 2025-12-18T04:15:21Z

run buildall

…apache#59020 (apache#6203) fix first txn->get ends up with null pointer partial pick apache#59019

…>get() failed apache#59019 (apache#59020) fix first txn->get ends up with null pointer partial pick apache#59019

gavinchou · 2026-03-27T13:24:27Z

run buildall

…o while() to get better robustness The original implementation of do...while() check is not extensible for retry if we failed to do the first `txn->get()` in the while loop. It will end with referencing null pointer at the check `while (it->more())`

gavinchou · 2026-04-04T09:41:30Z

run buildall

gavinchou · 2026-04-07T13:01:54Z

run buildall

wyxxxcat

LGTM

github-actions · 2026-04-08T02:20:14Z

PR approved by at least one committer and no changes requested.

…to while() to get better robustness (#59019) The original implementation of do...while() check is not extensible for retry if we failed to do the first `txn->get()` in the while loop. It will end with referencing null pointer at the check `while (it->more())`, and the original pattern is easily misused/copied in a scenario needs retry. No need to add new tests, the changes are covered by existing tests.

…o...while() to while() to get better robustness #59019 (#62192) Cherry-picked from #59019 Co-authored-by: Gavin Chou <gavin@selectdb.com>

gavinchou requested review from dataroaring and w41ter as code owners December 14, 2025 06:57

gavinchou changed the title ~~[chore](cloud) Change range iterator check pattern from do..while() to while() to get better robustness~~[chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustnessDec 14, 2025

gavinchou added the dev/4.0.x label Dec 14, 2025

gavinchou mentioned this pull request Dec 14, 2025
branch-3.1: [Fix](recycler) Fix possible null pointer when first txn->get() failed #59019 #59020
Merged

morrySnow pushed a commit that referenced this pull request Dec 15, 2025
branch-3.1: [Fix](recycler) Fix possible null pointer when first txn-…
a5c0a69
…>get() failed #59019 (#59020) fix first txn->get ends up with null pointer partial pick #59019

w41ter previously approved these changes Dec 15, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2025

github-actionsBot added the reviewed label Dec 15, 2025

gavinchou dismissed w41ter’s stale review via 67f42b1December 18, 2025 04:11

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Dec 18, 2025

gavinchou marked this pull request as draft December 25, 2025 12:43

w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 26, 2025
[Fix](recycler) Fix possible null pointer when first txn->get() failed…
7bcb279
…apache#59020 (apache#6203) fix first txn->get ends up with null pointer partial pick apache#59019

seawinde pushed a commit to seawinde/doris that referenced this pull request Jan 30, 2026
branch-3.1: [Fix](recycler) Fix possible null pointer when first txn-…
662f4dc
…>get() failed apache#59019 (apache#59020) fix first txn->get ends up with null pointer partial pick apache#59019

gavinchou marked this pull request as ready for review March 27, 2026 13:24

gavinchou added dev/4.1.x and removed dev/4.0.x labels Apr 3, 2026

gavinchouand others added 6 commits April 4, 2026 03:10

Fix UT
17eba50

Opt comments
baeeed2

Restore recycle_func/loop_done return
c7f794e

fix
59b3e04

fix
ce72e2d

gavinchou force-pushed the gavin-fix-cloud-while-more branch from 67f42b1 to ce72e2dCompare April 4, 2026 09:40

Fix ut
c983c2c

Yukang-Lian approved these changes Apr 7, 2026
View reviewed changes

wyxxxcat approved these changes Apr 7, 2026
View reviewed changes

w41ter approved these changes Apr 8, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 8, 2026

w41ter merged commit b31412a into apache:masterApr 8, 2026
31 of 32 checks passed

github-actionsBot mentioned this pull request Apr 8, 2026
branch-4.1: [chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness #59019 #62192
Merged

yiguolei pushed a commit that referenced this pull request Apr 8, 2026
branch-4.1: [chore](cloud) Change range iterator check pattern from d…
d027510
…o...while() to while() to get better robustness #59019 (#62192) Cherry-picked from #59019 Co-authored-by: Gavin Chou <gavin@selectdb.com>

yiguolei added dev/4.1.0-merged and removed dev/4.1.x labels Apr 8, 2026

mymeiyi mentioned this pull request Apr 21, 2026
[fix](wal) Fix WAL replay loading 0 rows due to columns being marked as missing #62658
Merged

Navigation Menu

Uh oh!

[chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness - #59019

[chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness#59019
w41ter merged 8 commits into
apache:masterfrom
gavinchou:gavin-fix-cloud-while-more

gavinchou commented Dec 14, 2025•
edited
Loading

Uh oh!

hello-stephen commented Dec 14, 2025

Uh oh!

gavinchou commented Dec 14, 2025

Uh oh!

gavinchou commented Dec 14, 2025

Uh oh!

github-actionsBot commented Dec 15, 2025

Uh oh!

github-actionsBot commented Dec 15, 2025

Uh oh!

gavinchou commented Dec 18, 2025

Uh oh!

gavinchou commented Mar 27, 2026

Uh oh!

gavinchou commented Apr 4, 2026

Uh oh!

gavinchou commented Apr 7, 2026

Uh oh!

wyxxxcat left a comment

Uh oh!

github-actionsBot commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

gavinchou commented Dec 14, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hello-stephen commented Dec 14, 2025

Uh oh!

gavinchou commented Dec 14, 2025

Uh oh!

gavinchou commented Dec 14, 2025

Uh oh!

github-actionsBot commented Dec 15, 2025

Uh oh!

github-actionsBot commented Dec 15, 2025

Uh oh!

gavinchou commented Dec 18, 2025

Uh oh!

gavinchou commented Mar 27, 2026

Uh oh!

gavinchou commented Apr 4, 2026

Uh oh!

gavinchou commented Apr 7, 2026

Uh oh!

wyxxxcat left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gavinchou commented Dec 14, 2025•
edited
Loading