Skip to content

branch-4.1: [chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness #59019 - #62192

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-59019-branch-4.1
Apr 8, 2026
Merged

branch-4.1: [chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness #59019#62192
yiguolei merged 1 commit into
branch-4.1from
auto-pick-59019-branch-4.1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #59019

@gavinchouYour Name
[chore](cloud) Change range iterator check pattern from do...while() …
88de5fc
…to while() to get better robustness (#59019)
The original implementation of do...while() check is not extensible for
retry if we failed to do the first `txn->get()` in the while loop. It
will end with referencing null pointer at the check `while
(it->more())`, and the original pattern is easily misused/copied in a
scenario needs retry.
No need to add new tests, the changes are covered by existing tests.
@github-actions
github-actionsBot requested a review from yiguolei as a code ownerApril 8, 2026 02:25
@hello-stephen

hello-stephen commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaringdataroaring reopened this Apr 8, 2026
@hello-stephen

hello-stephen commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
yiguolei merged commit d027510 into branch-4.1Apr 8, 2026
26 of 28 checks passed
@morningman
morningman deleted the auto-pick-59019-branch-4.1 branch July 8, 2026 14:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen@yiguolei@dataroaring@gavinchou