Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [refact](inverted index) refact compound idx writer #59219 - #59364
Merged
yiguolei merged 1 commit intoDec 26, 2025
Merged
Conversation
This PR refactors the compound index writer for the inverted index V2 format to optimize performance, particularly for cloud storage systems like S3. The main improvement is bypassing unnecessary directory operations by directly creating the output stream using an existing file writer. Key changes: Added a static factory method FSIndexOutputV2::create() for direct instantiation without requiring a Directory object Refactored IndexStorageFormatV2::create_output_stream() to return only an IndexOutput instead of a Directory-IndexOutput pair Removed the cloud mode check in DorisFSDirectoryFactory::getDirectory() to simplify code (directory creation is safe for all file systems)
airborne12
commented
Dec 25, 2025
MemberAuthor
run buildall |
Thearas
commented
Dec 25, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
doris-robot
commented
Dec 25, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Dec 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
16 tasks
yiguolei pushed a commit
that referenced
this pull request
Jan 16, 2026
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: The issue was caused by picking the two PRs #59364 and #59693 in the wrong order. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
ybtsdst pushed a commit
to ybtsdst/doris
that referenced
this pull request
Feb 27, 2026
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: The issue was caused by picking the two PRs apache#59364 and apache#59693 in the wrong order. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick from #59219