Skip to content

[fix](packed-file) fix inverted index writer init error - #59923

Merged
yiguolei merged 1 commit into
apache:branch-4.0from
liaoxin01:fix_packed_file_index
Jan 16, 2026
Merged

[fix](packed-file) fix inverted index writer init error#59923
yiguolei merged 1 commit into
apache:branch-4.0from
liaoxin01:fix_packed_file_index

Conversation

@liaoxin01

@liaoxin01liaoxin01 commented Jan 15, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

The issue was caused by picking the two PRs #59364
and #59693 in the wrong order.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

CopilotAI review requested due to automatic review settings January 15, 2026 09:40
@Thearas

Thearas commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01

liaoxin01 commented Jan 15, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

CopilotAI reviewed Jan 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an inverted index writer initialization error in cloud mode by removing an incorrect check that prevented directory creation. The removed condition incorrectly assumed that cloud mode does not need local temporary directories for inverted index building.

Changes:

  • Removed the cloud mode check that was preventing directory creation in DorisFSDirectoryFactory::getDirectory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

airborne12
airborne12 approved these changes Jan 15, 2026
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 15, 2026
@github-actions

github-actionsBot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (19/19) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.41% (18848/35287)
Line Coverage39.27% (174999/445683)
Region Coverage33.90% (135400/399352)
Branch Coverage34.86% (58616/168135)

@yiguolei
yiguolei merged commit ebcf7fe into apache:branch-4.0Jan 16, 2026
35 of 38 checks passed
ybtsdst pushed a commit to ybtsdst/doris that referenced this pull request Feb 27, 2026
@liaoxin01bingtao.yin
[fix](packed-file) fix inverted index writer init error (apache#59923)
f62b247
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The issue was caused by picking the two PRs
apache#59364
and apache#59693 in the wrong order.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@airborne12airborne12airborne12 approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liaoxin01@Thearas@hello-stephen@airborne12@yiguolei