[opt](move-memtable) reduce tablet report frequency by sollhui · Pull Request #59973 · apache/doris

sollhui · 2026-01-16T09:49:18Z

What problem does this PR solve?

Report tablet load info only on ADD_SEGMENT to reduce frequency: ADD_SEGMENT is sent once per segment, while APPEND_DATA is sent for every data batch, which reduces some unnecessary tablet report.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2026-01-16T09:49:24Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

sollhui · 2026-01-16T09:49:42Z

run buildall

doris-robot · 2026-01-16T10:23:09Z

TPC-H: Total hot run time: 31239 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f4e23d7bcd7b7275f06b8c417125a6c1e8fd30db, data reload: false
------ Round 1 ----------------------------------
q1	17603	4148	4046	4046
q2	2030	351	254	254
q3	10173	1253	705	705
q4	10201	831	303	303
q5	7524	2076	1819	1819
q6	197	172	141	141
q7	921	779	646	646
q8	9267	1419	1109	1109
q9	4929	4526	4581	4526
q10	6760	1792	1384	1384
q11	526	298	286	286
q12	704	762	576	576
q13	17808	3780	3116	3116
q14	286	297	277	277
q15	590	514	509	509
q16	703	674	632	632
q17	652	781	490	490
q18	6613	6444	6347	6347
q19	1171	977	620	620
q20	389	360	243	243
q21	2961	2383	2225	2225
q22	1024	985	996	985
Total cold run time: 103032 ms
Total hot run time: 31239 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4102	4024	4023	4023
q2	328	406	323	323
q3	2094	2563	2242	2242
q4	1335	1754	1344	1344
q5	4115	4063	4038	4038
q6	211	167	130	130
q7	1890	1826	1651	1651
q8	2870	2522	2405	2405
q9	7529	7444	7190	7190
q10	2575	2765	2311	2311
q11	559	504	460	460
q12	781	817	670	670
q13	3819	4198	3682	3682
q14	283	321	295	295
q15	550	505	500	500
q16	711	705	682	682
q17	1166	1270	1385	1270
q18	8261	8332	7837	7837
q19	884	818	853	818
q20	2115	2091	1875	1875
q21	4834	4387	4012	4012
q22	1039	1028	972	972
Total cold run time: 52051 ms
Total hot run time: 48730 ms

doris-robot · 2026-01-16T10:33:57Z

TPC-DS: Total hot run time: 174147 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f4e23d7bcd7b7275f06b8c417125a6c1e8fd30db, data reload: false
query5	4414	625	502	502
query6	323	229	199	199
query7	4230	467	267	267
query8	343	243	227	227
query9	8732	2900	2865	2865
query10	487	375	350	350
query11	15325	15279	14953	14953
query12	187	117	113	113
query13	1261	481	380	380
query14	6171	3034	2871	2871
query14_1	2711	2852	2687	2687
query15	203	198	176	176
query16	993	476	455	455
query17	1094	687	573	573
query18	2463	435	339	339
query19	226	219	198	198
query20	124	115	113	113
query21	217	144	116	116
query22	3753	3908	4009	3908
query23	16055	15500	15279	15279
query23_1	15379	15355	15385	15355
query24	7148	1552	1181	1181
query24_1	1166	1162	1169	1162
query25	536	450	417	417
query26	1246	271	157	157
query27	2764	451	284	284
query28	4551	2178	2153	2153
query29	807	525	441	441
query30	313	241	211	211
query31	823	656	585	585
query32	88	79	77	77
query33	544	367	328	328
query34	919	874	531	531
query35	733	778	674	674
query36	876	893	832	832
query37	133	100	90	90
query38	2816	2736	2682	2682
query39	775	741	733	733
query39_1	714	716	701	701
query40	221	137	123	123
query41	77	67	66	66
query42	106	106	103	103
query43	472	486	415	415
query44	1353	759	759	759
query45	185	191	181	181
query46	836	955	589	589
query47	1482	1491	1402	1402
query48	316	325	234	234
query49	616	411	330	330
query50	635	279	210	210
query51	3756	3827	3720	3720
query52	106	106	96	96
query53	294	328	277	277
query54	290	264	262	262
query55	83	80	77	77
query56	315	305	300	300
query57	1032	989	980	980
query58	275	270	255	255
query59	2145	2071	1999	1999
query60	325	331	313	313
query61	148	147	143	143
query62	380	348	310	310
query63	300	268	264	264
query64	4970	1285	950	950
query65	3836	3733	3780	3733
query66	1442	418	320	320
query67	15522	15559	15478	15478
query68	2480	1121	765	765
query69	443	365	330	330
query70	1007	956	878	878
query71	337	327	295	295
query72	5260	3144	3212	3144
query73	600	737	312	312
query74	8753	8758	8552	8552
query75	2740	2793	2471	2471
query76	2286	1084	666	666
query77	359	401	309	309
query78	9805	9755	9188	9188
query79	3034	867	592	592
query80	1757	574	494	494
query81	549	259	229	229
query82	950	142	105	105
query83	325	253	232	232
query84	256	129	96	96
query85	900	486	430	430
query86	421	298	319	298
query87	3005	2895	2810	2810
query88	3507	2594	2568	2568
query89	384	353	334	334
query90	1940	175	169	169
query91	169	156	129	129
query92	81	73	72	72
query93	1201	968	539	539
query94	654	332	304	304
query95	589	385	310	310
query96	642	513	235	235
query97	2355	2382	2315	2315
query98	229	214	195	195
query99	569	574	510	510
Total cold run time: 249969 ms
Total hot run time: 174147 ms

doris-robot · 2026-01-16T10:38:59Z

ClickBench: Total hot run time: 27.02 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f4e23d7bcd7b7275f06b8c417125a6c1e8fd30db, data reload: false
query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.60	0.11	0.12
query5	0.28	0.26	0.26
query6	1.15	0.68	0.65
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.55	0.56	0.53
query11	0.14	0.10	0.09
query12	0.15	0.11	0.12
query13	0.60	0.58	0.58
query14	0.95	0.94	0.95
query15	0.80	0.78	0.78
query16	0.43	0.41	0.41
query17	1.06	1.08	1.04
query18	0.23	0.21	0.21
query19	1.89	1.90	1.74
query20	0.01	0.02	0.01
query21	15.46	0.29	0.14
query22	5.05	0.05	0.04
query23	15.78	0.29	0.11
query24	1.08	0.63	0.81
query25	0.11	0.05	0.06
query26	0.15	0.13	0.13
query27	0.07	0.05	0.05
query28	4.99	1.07	0.88
query29	12.60	3.90	3.14
query30	0.29	0.14	0.12
query31	2.82	0.64	0.40
query32	3.24	0.58	0.46
query33	2.94	3.02	3.13
query34	16.40	5.09	4.42
query35	4.48	4.41	4.45
query36	0.64	0.51	0.50
query37	0.10	0.07	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.16	0.14	0.13
query41	0.09	0.04	0.02
query42	0.05	0.03	0.02
query43	0.05	0.04	0.03
Total cold run time: 97.55 s
Total hot run time: 27.02 s

doris-robot · 2026-01-16T11:11:22Z

BE UT Coverage Report

Increment line coverage 85.71% (6/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.38% (19025/36319)
Line Coverage	35.71% (176285/493724)
Region Coverage	32.22% (136402/423344)
Branch Coverage	33.13% (58992/178061)

hello-stephen · 2026-01-16T12:35:49Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.45% (25433/35597)
Line Coverage	53.93% (265942/493142)
Region Coverage	51.51% (220363/427846)
Branch Coverage	53.00% (94772/178822)

hello-stephen · 2026-01-17T09:03:48Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.45% (25433/35597)
Line Coverage	53.93% (265942/493142)
Region Coverage	51.51% (220363/427846)
Branch Coverage	53.00% (94772/178822)

liaoxin01 · 2026-01-18T13:22:14Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

liaoxin01

LGTM

github-actions · 2026-01-18T13:34:30Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-01-18T13:34:32Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

Report tablet load info only on `ADD_SEGMENT` to reduce frequency: ` ADD_SEGMENT` is sent once per segment, while `APPEND_DATA` is sent for every data batch, which reduces some unnecessary tablet report.

…ol version number (part II) (#60866) pick #57654 #59973 #60688

reduce tablet report frequency
f4e23d7

liaoxin01 approved these changes Jan 18, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 18, 2026

github-actionsBot added the reviewed label Jan 18, 2026

dataroaring approved these changes Jan 19, 2026
View reviewed changes

dataroaring merged commit 536078a into apache:masterJan 19, 2026
29 of 30 checks passed

sollhui mentioned this pull request Feb 27, 2026
branch-4.0: [feat](storage) introduce backpressure algorithm to control version number (part II) #60866
Merged

yiguolei pushed a commit that referenced this pull request Mar 9, 2026
branch-4.0: [feat](storage) introduce backpressure algorithm to contr…
fc486ab
…ol version number (part II) (#60866) pick #57654 #59973 #60688

yiguolei added the dev/4.0.5-merged label Mar 9, 2026

yiguolei added the dev/4.1.0-merged label Mar 16, 2026

Uh oh!

Conversation

sollhui commented Jan 16, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jan 16, 2026

Uh oh!

sollhui commented Jan 16, 2026

Uh oh!

doris-robot commented Jan 16, 2026

Uh oh!

doris-robot commented Jan 16, 2026

Uh oh!

doris-robot commented Jan 16, 2026

Uh oh!

doris-robot commented Jan 16, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Jan 16, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Jan 17, 2026

BE Regression && UT Coverage Report

Uh oh!

liaoxin01 commented Jan 18, 2026

Code review

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jan 18, 2026

Uh oh!

github-actionsBot commented Jan 18, 2026

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants