Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [feat](storage) introduce backpressure algorithm to control version number (part II) - #60866
Merged
Merged
Conversation
…umber (part II) (apache#57654) ### What problem does this PR solve? Write memtable on sink implement of apache#57133.
Report tablet load info only on `ADD_SEGMENT` to reduce frequency: ` ADD_SEGMENT` is sent once per segment, while `APPEND_DATA` is sent for every data batch, which reduces some unnecessary tablet report.
…load info (apache#60688) ## Summary Fix a bug where `_report_tablet_load_info` writes an empty `IOBuf` to brpc stream, causing `Socket::Write` to return EINVAL and log warnings like: ``` Fail to write to _fake_socket, Invalid argument ``` ## Root Cause `_report_tablet_load_info` is called on every `ADD_SEGMENT` request to report tablet load info (version count) back to the sender for back-pressure control. The call chain is: 1. `_report_tablet_load_info` gets `write_tablet_ids` from the index stream 2. `_collect_tablet_load_info_from_tablets` iterates over these tablet IDs 3. `collect_tablet_load_rowset_num_info` only adds an entry when `version_count` exceeds `max_version_config * load_back_pressure_version_threshold / 100` In normal cases where no tablet hits the back-pressure threshold, `tablet_load_infos` remains empty. A protobuf message with only an empty repeated field serializes to an empty string (0 bytes). The empty `IOBuf` is then passed to `brpc::StreamWrite`, and brpc's `Socket::Write` rejects empty data with EINVAL. This error is harmless (the socket is not closed or failed, and subsequent writes succeed), but it produces noisy WARNING logs on every `ADD_SEGMENT` request. ## Fix Skip the `StreamWrite` call when `tablet_load_infos` is empty after collection, since there is nothing to report.
Thearas
commented
Feb 27, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
sollhui
commented
Feb 27, 2026
ContributorAuthor
run buildall |
hello-stephen
commented
Feb 27, 2026
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Feb 27, 2026
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
doris-robot
commented
Feb 27, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Mar 9, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick
#57654
#59973
#60688