Skip to content

[feat](http) Support update and show config for recycler and meta-service - #60816

Merged
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:recycler_update_show_config
Mar 18, 2026
Merged

[feat](http) Support update and show config for recycler and meta-service#60816
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:recycler_update_show_config

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

  • add show_config endpoint to MetaService HTTP API (including v1 path)
  • refactor RecyclerService HTTP handlers and add show_config/update_config support
  • expose recycler thread pool group accessor used by HTTP service
  • add cloud regression test for update_config + show_config roundtrip
  • add recycleServiceHttpAddress in cloud_p0 custom regression config

example:

curl "http://localhost:5678/MetaService/http/show_config?token=greedisgood9999&conf_key=compacted_rowset_retention_seconds"
{
"code": "OK",
"msg": "",
"result": [
[
"compacted_rowset_retention_seconds",
"int64_t",
"1080",
true
]
]
}
curl "http://localhost:5678/MetaService/http/update_config?configs=compacted_rowset_retention_seconds=108&token=greedisgood9999"
{
"code": "OK",
"msg": ""
}
curl "http://localhost:5678/MetaService/http/show_config?token=greedisgood9999&conf_key=compacted_rowset_retention_seconds"
{
"code": "OK",
"msg": "",
"result": [
[
"compacted_rowset_retention_seconds",
"int64_t",
"108",
true
]
]
}

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
wyxxxcatforce-pushed the recycler_update_show_config branch 2 times, most recently from 9c43a64 to 11dffdaCompareFebruary 27, 2026 01:59
@wyxxxcat
wyxxxcat marked this pull request as ready for review February 27, 2026 07:58
@wyxxxcat

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat
wyxxxcatforce-pushed the recycler_update_show_config branch from 11dffda to 8399a34CompareFebruary 28, 2026 02:19
@wyxxxcat

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

Cloud UT Coverage Report

Increment line coverage 0.84% (2/237) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.81% (1796/2279)
Line Coverage64.80% (32045/49451)
Region Coverage65.47% (15984/24416)
Branch Coverage55.97% (8502/15190)

@w41ter

Copy link
Copy Markdown
Contributor

Please provide an example and share the output.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@gavinchou
gavinchou merged commit e917993 into apache:masterMar 18, 2026
32 of 33 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 18, 2026
…vice (#60816)
- add `show_config` endpoint to MetaService HTTP API (including v1 path)
- refactor RecyclerService HTTP handlers and add
`show_config`/`update_config` support
- expose recycler thread pool group accessor used by HTTP service
- add cloud regression test for update_config + show_config roundtrip
- add `recycleServiceHttpAddress` in cloud_p0 custom regression config
example:
```
curl "http://localhost:5678/MetaService/http/show_config?token=greedisgood9999&conf_key=compacted_rowset_retention_seconds"
{
"code": "OK",
"msg": "",
"result": [
[
"compacted_rowset_retention_seconds",
"int64_t",
"1080",
true
]
]
}
curl "http://localhost:5678/MetaService/http/update_config?configs=compacted_rowset_retention_seconds=108&token=greedisgood9999"
{
"code": "OK",
"msg": ""
}
curl "http://localhost:5678/MetaService/http/show_config?token=greedisgood9999&conf_key=compacted_rowset_retention_seconds"
{
"code": "OK",
"msg": "",
"result": [
[
"compacted_rowset_retention_seconds",
"int64_t",
"108",
true
]
]
}
```
yiguolei pushed a commit that referenced this pull request Mar 19, 2026
…and meta-service #60816 (#61479)
Cherry-picked from #60816
Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
github-actionsBot pushed a commit that referenced this pull request May 22, 2026
…vice (#60816)
- add `show_config` endpoint to MetaService HTTP API (including v1 path)
- refactor RecyclerService HTTP handlers and add
`show_config`/`update_config` support
- expose recycler thread pool group accessor used by HTTP service
- add cloud regression test for update_config + show_config roundtrip
- add `recycleServiceHttpAddress` in cloud_p0 custom regression config
example:
```
curl "http://localhost:5678/MetaService/http/show_config?token=greedisgood9999&conf_key=compacted_rowset_retention_seconds"
{
"code": "OK",
"msg": "",
"result": [
[
"compacted_rowset_retention_seconds",
"int64_t",
"1080",
true
]
]
}
curl "http://localhost:5678/MetaService/http/update_config?configs=compacted_rowset_retention_seconds=108&token=greedisgood9999"
{
"code": "OK",
"msg": ""
}
curl "http://localhost:5678/MetaService/http/show_config?token=greedisgood9999&conf_key=compacted_rowset_retention_seconds"
{
"code": "OK",
"msg": "",
"result": [
[
"compacted_rowset_retention_seconds",
"int64_t",
"108",
true
]
]
}
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/4.0.6-mergeddev/4.1.0-mergedint/3.1.6-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@wyxxxcat@Thearas@doris-robot@w41ter@gavinchou@Hastyshell@morningman@yiguolei