[fix](recycler) Recycler/Ms http api result msg should set ok

[wyxxxcat]

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

• Test

  • Regression test
  • Unit Test
  • Manual test (add detailed scripts or steps below)
  • No need to test or manual test. Explain why:
    • This is a refactor/code format and no logic has been changed.
    • Previous test can cover this change.
    • No code files have been changed.
    • Other reason

• Behavior changed:

  • No.
  • Yes.

• Does this need documentation?

  • No.
  • Yes.

Check List (For Reviewer who merge this PR)

• Confirm the release note
• Confirm test cases
• Confirm document
• Add branch pick label

[hello-stephen]

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?

[wyxxxcat]

run buildall

[wyxxxcat]

run buildall

[wyxxxcat]

run buildall

[wyxxxcat]

/review

[github-actions]

OpenCode automated review failed and did not complete.

Error: Review step was skipped (possibly timeout or cancelled)
Workflow run: https://github.com/apache/doris/actions/runs/25783579063

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

[wyxxxcat]

/review

[github-actions]

I found one blocking correctness issue in the recycler HTTP path.

Critical checkpoint conclusions:

• Goal: set successful Recycler/MS HTTP API messages to OK; the shared helper covers JSON/text success messages, but one changed recycler endpoint now reports OK on a concrete failure path.
• Scope: the change is small and focused, but the per-endpoint default initialization needs to account for callees that do not always set code/msg.
• Concurrency: this PR does not introduce new shared state or lock ordering; existing recycler worker concurrency is unchanged.
• Lifecycle/static initialization: no new lifecycle or cross-TU static initialization concern introduced.
• Configuration/compatibility: no new configs or storage/protocol formats; HTTP response message behavior is user-visible but appears intentional.
• Parallel paths: JSON/text helper paths were both updated; the recycler manual trigger path has a distinct unchecked failure return.
• Tests: existing tests were updated for representative meta-service JSON responses, but there is no coverage for the recycle_copy_jobs init-failure path that now returns OK.
• Observability: logs use the response message, so the same failure path can now be logged as success.
• Transaction/persistence/data correctness: no transaction visibility, persistence, or data-write semantics changed by this PR.
• User focus: no additional user-provided focus points were supplied.

[github-actions]

PR approved by at least one committer and no changes requested.

dismiss