[fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients by luwei16 · Pull Request #62244 · apache/doris

luwei16 · 2026-04-08T12:04:16Z

What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK.

Release note

None

Check List (For Author)

Test: Cloud unit test
- ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8
Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)
Does this need documentation: No

### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8 - Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally) - Does this need documentation: No

hello-stephen · 2026-04-08T12:04:21Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

luwei16 · 2026-04-08T12:04:30Z

run buildall

luwei16 · 2026-04-08T12:10:37Z

run buildall

github-actions · 2026-04-08T12:23:18Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-04-08T12:23:20Z

PR approved by anyone and no changes requested.

hello-stephen · 2026-04-08T12:40:57Z

Cloud UT Coverage Report

Increment line coverage 83.33% (5/6) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	78.52% (1799/2291)
Line Coverage	64.30% (32343/50301)
Region Coverage	65.13% (16286/25005)
Branch Coverage	55.63% (8704/15646)

hello-stephen · 2026-04-08T14:50:13Z

BE Regression && UT Coverage Report

Increment line coverage 59.38% (19/32) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.63% (27364/37165)
Line Coverage	57.28% (295358/515662)
Region Coverage	54.56% (246206/451241)
Branch Coverage	56.17% (106626/189833)

### What problem does this PR solve? Issue Number: None Related PR: apache#62244 Problem Summary: Add cloud unit tests that cover the MetaServiceProxy downgrade paths for KV_TXN_MAYBE_COMMITTED so the PR's retry-handling change is exercised on both read and commit RPCs. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j8 - Behavior changed: No - Does this need documentation: No

luwei16 · 2026-04-10T08:45:56Z

run buildall

luwei16 · 2026-04-10T09:07:05Z

run buildall

hello-stephen · 2026-04-10T10:21:51Z

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

luwei16 · 2026-04-14T07:27:51Z

run buildall

hello-stephen · 2026-04-14T08:40:50Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	53.03% (20135/37969)
Line Coverage	36.58% (189353/517680)
Region Coverage	32.82% (146957/447716)
Branch Coverage	33.98% (64357/189421)

hello-stephen · 2026-04-14T10:04:50Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.64% (27380/37183)
Line Coverage	57.31% (295789/516096)
Region Coverage	54.48% (246156/451848)
Branch Coverage	56.20% (106777/190003)

hello-stephen · 2026-04-14T10:14:39Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/63) 🎉
Increment coverage report
Complete coverage report

luwei16 · 2026-04-14T12:09:43Z

run nonConcurrent

hello-stephen · 2026-04-14T14:01:43Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.63% (27378/37183)
Line Coverage	57.30% (295743/516096)
Region Coverage	54.46% (246057/451848)
Branch Coverage	56.19% (106756/190003)

hello-stephen · 2026-04-14T14:12:54Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/63) 🎉
Increment coverage report
Complete coverage report

Hastyshell

LGTM

github-actions · 2026-04-17T09:44:32Z

PR approved by at least one committer and no changes requested.

Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8 - Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)

(#62644) Cherry-picked from #62244 Co-authored-by: Luwei <814383175@qq.com>

(#62642) Cherry-picked from #62244 Co-authored-by: Luwei <814383175@qq.com>

Problem Summary: Preserve MetaService retry handling for KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2 unknown enum as OK. ### Release note None ### Check List (For Author) - Test: Cloud unit test - ./run-cloud-ut.sh --run --filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8 - Behavior changed: Yes (MetaService no longer exposes KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and returns KV_TXN_COMMIT_ERR externally)

luwei16 requested review from dataroaring, gavinchou and w41ter as code owners April 8, 2026 12:04

fix code style
31e6c59

luwei16 added dev/4.0.x dev/4.1.x dev/3.1.x labels Apr 8, 2026

w41ter previously approved these changes Apr 8, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 8, 2026

github-actionsBot added the reviewed label Apr 8, 2026

gavinchou previously approved these changes Apr 8, 2026
View reviewed changes

luwei16 dismissed stale reviews from gavinchou and w41ter via 58c0555April 10, 2026 07:31

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 10, 2026

Hastyshell approved these changes Apr 17, 2026
View reviewed changes

gavinchou approved these changes Apr 17, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2026

luwei16 removed the dev/3.1.x label Apr 20, 2026

luwei16 merged commit 48bad76 into apache:masterApr 20, 2026
30 of 31 checks passed

github-actionsBot mentioned this pull request Apr 20, 2026
branch-4.0: [fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients #62244 #62642
Merged

github-actionsBot mentioned this pull request Apr 20, 2026
branch-4.1: [fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients #62244 #62644
Merged

mymeiyi mentioned this pull request Apr 21, 2026
[fix](wal) Fix WAL replay loading 0 rows due to columns being marked as missing #62658
Merged

yiguolei pushed a commit that referenced this pull request Apr 22, 2026
branch-4.1: [fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients#62244
4244061
(#62644) Cherry-picked from #62244 Co-authored-by: Luwei <814383175@qq.com>

yiguolei added dev/4.1.1-merged and removed dev/4.1.x labels Apr 22, 2026

yiguolei pushed a commit that referenced this pull request Apr 22, 2026
branch-4.0: [fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients#62244
bca492d
(#62642) Cherry-picked from #62244 Co-authored-by: Luwei <814383175@qq.com>

yiguolei added dev/4.0.6-merged and removed dev/4.0.x labels Apr 22, 2026

yiguolei mentioned this pull request May 20, 2026
4.1.1 Release Notes #63426
Closed

morningman mentioned this pull request Jun 3, 2026
4.0.6 Release Notes #64065
Closed

Uh oh!

Conversation

luwei16 commented Apr 8, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Uh oh!

hello-stephen commented Apr 8, 2026

Uh oh!

luwei16 commented Apr 8, 2026

Uh oh!

luwei16 commented Apr 8, 2026

Uh oh!

github-actionsBot commented Apr 8, 2026

Uh oh!

github-actionsBot commented Apr 8, 2026

Uh oh!

hello-stephen commented Apr 8, 2026

Cloud UT Coverage Report

Uh oh!

hello-stephen commented Apr 8, 2026

BE Regression && UT Coverage Report

Uh oh!

luwei16 commented Apr 10, 2026

Uh oh!

luwei16 commented Apr 10, 2026

Uh oh!

hello-stephen commented Apr 10, 2026

FE UT Coverage Report

Uh oh!

luwei16 commented Apr 14, 2026

Uh oh!

hello-stephen commented Apr 14, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Apr 14, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Apr 14, 2026

FE Regression Coverage Report

Uh oh!

luwei16 commented Apr 14, 2026

Uh oh!

hello-stephen commented Apr 14, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Apr 14, 2026

FE Regression Coverage Report

Uh oh!

Hastyshell left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants