Skip to content

branch-4.0: [fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients #62244 - #62642

Merged
yiguolei merged 1 commit into
branch-4.0from
auto-pick-62244-branch-4.0
Apr 22, 2026
Merged

branch-4.0: [fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients #62244#62642
yiguolei merged 1 commit into
branch-4.0from
auto-pick-62244-branch-4.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #62244

@luwei16Your Name
[fix](cloud) Hide KV_TXN_MAYBE_COMMITTED from clients (#62244)
283f088
Problem Summary: Preserve MetaService retry handling for
KV_TXN_MAYBE_COMMITTED internally, but downgrade the final response code
to KV_TXN_COMMIT_ERR so older BE/FE clients do not treat the proto2
unknown enum as OK.
### Release note
None
### Check List (For Author)
- Test: Cloud unit test
- ./run-cloud-ut.sh --run
--filter='meta_service_test:MetaServiceTxnStoreRetryableTest.*' -j 8
- Behavior changed: Yes (MetaService no longer exposes
KV_TXN_MAYBE_COMMITTED to clients; it still retries internally and
returns KV_TXN_COMMIT_ERR externally)
@Thearas

Thearas commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Thearas

Thearas commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.05% (19286/36352)
Line Coverage36.22% (179808/496422)
Region Coverage32.80% (139419/425110)
Branch Coverage33.75% (60496/179223)

@hello-stephen

hello-stephen commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.34% (25386/35586)
Line Coverage54.04% (267793/495536)
Region Coverage51.32% (220363/429386)
Branch Coverage52.92% (95171/179854)

@yiguolei
yiguolei merged commit bca492d into branch-4.0Apr 22, 2026
28 of 32 checks passed
@github-actions
github-actionsBot deleted the auto-pick-62244-branch-4.0 branch April 22, 2026 07:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@morningmanmorningmanAwaiting requested review from morningmanmorningman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas@hello-stephen@yiguolei@dataroaring@luwei16