Uh oh!
There was an error while loading. Please reload this page.
Backport #63972 branch 4.1 - #64260
Merged
Merged
Conversation
hello-stephen
commented
Jun 9, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
yiguolei
approved these changes
Jun 10, 2026
yiguolei
commented
Jun 10, 2026
Contributor
run buildall |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Issue Number: closeapache#26112 Related PR: None Problem Summary: Querying information_schema.columns with an external system table name such as table can call FrontendServiceImpl.getTableNames with the table name as a pattern. The MySQL pattern converter rejected '$' as a forbidden regex character, so the FE thrift service threw an internal getTableNames error before metadata resolution. This change treats '$' as a literal character in MySQL patterns by escaping it for the generated Java regex, allowing system table names to be matched safely. Fixes metadata lookup for table names containing '$', including external system tables such as table. - Test: Manual test - Ran git diff --check and git diff --cached --check. - Tried ./run-fe-ut.sh --run org.apache.doris.common.PatternMatcherTest, but the local environment only has JDK 11 and the script requires JDK 17. - Behavior changed: Yes. MySQL pattern matching now allows '$' as a literal table-name character. - Does this need documentation: No (cherry picked from commit 14c184f)
### What problem does this PR solve? Issue Number: closeapache#63972 Related PR: apache#63972 Problem Summary: MySQL pattern conversion escaped '$' in the first pass, but the second pass only preserved escaped '.', so the escaped dollar became a regex that did not match a literal '$'. This change preserves '$' during the second pass so table names containing '$' can be matched literally. ### Release note None ### Check List (For Author) - Test: Manual test - Ran git diff --check and git diff --cached --check. FE unit test org.apache.doris.common.PatternMatcherTest could not run because local JAVA_HOME points to JDK 11 and JDK_17 is not set. - Behavior changed: No - Does this need documentation: No (cherry picked from commit bdd4a1b)
yiguoleiforce-pushed
the
backport-63972-branch-4.1
branch
from
June 16, 2026 08:37
914adc2 to
849f881Compareyiguolei
commented
Jun 16, 2026
Contributor
run buildall |
hello-stephen
commented
Jun 16, 2026
Contributor
FE Regression Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Jun 17, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#63972
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)