Uh oh!
There was an error while loading. Please reload this page.
[fix](cloud) Track deleted instance recycle status - #66519
Conversation
hello-stephen
commented
Aug 6, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
cb9f32a to
4d99af8Comparewyxxxcat
commented
Aug 6, 2026
run buildall |
4d99af8 to
aac2195Comparewyxxxcat
commented
Aug 6, 2026
run buildall |
hello-stephen
commented
Aug 6, 2026
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 6, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
wyxxxcat
commented
Aug 6, 2026
/review |
Codex automated review failed and did not complete. Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z. Please trigger /review again after that time. |
hello-stephen
commented
Aug 6, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 6, 2026
TPC-H: Total hot run time: 28941 ms |
hello-stephen
commented
Aug 6, 2026
TPC-DS: Total hot run time: 166564 ms |
hello-stephen
commented
Aug 6, 2026
ClickBench: Total hot run time: 23.87 s |
ab8d98d to
2a3c6d4Comparewyxxxcat
commented
Aug 9, 2026
run buildall |
2a3c6d4 to
c9e09a4Comparec9e09a4 to
b63e453Comparewyxxxcat
commented
Aug 10, 2026
run buildall |
hello-stephen
commented
Aug 10, 2026
FE UT Coverage ReportIncrement line coverage `` 🎉 |
66fab99 to
1ecde75Comparewyxxxcat
commented
Aug 10, 2026
run buildall |
hello-stephen
commented
Aug 10, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
hello-stephen
commented
Aug 10, 2026
FE UT Coverage ReportIncrement line coverage `` 🎉 |
hello-stephen
commented
Aug 10, 2026
TPC-H: Total hot run time: 29405 ms |
hello-stephen
commented
Aug 10, 2026
TPC-DS: Total hot run time: 158399 ms |
hello-stephen
commented
Aug 10, 2026
ClickBench: Total hot run time: 24.06 s |
hello-stephen
commented
Aug 10, 2026
FE Regression Coverage ReportIncrement line coverage |
wyxxxcat
commented
Aug 10, 2026
run check_coverage |
Uh oh!
There was an error while loading. Please reload this page.
Introduce a persistent recycle state for deleted instances to split instance recycling into separate data cleanup and metadata cleanup stages. The recycle process now transitions through: ``` DATA_CLEANUP_PENDING -> METADATA_CLEANUP_PENDING -> CLEANUP_COMPLETED ``` Each transition is persisted so that recycling can resume from the latest state after failures or retries. Also add an API to skip instance data cleanup by advancing the recycle state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING. Subsequent recycle rounds will skip object data cleanup and continue with metadata cleanup. Repeated DROP operations preserve the existing recycle state instead of resetting the recycle process.
Introduce a persistent recycle state for deleted instances to split instance recycling into separate data cleanup and metadata cleanup stages. The recycle process now transitions through: ``` DATA_CLEANUP_PENDING -> METADATA_CLEANUP_PENDING -> CLEANUP_COMPLETED ``` Each transition is persisted so that recycling can resume from the latest state after failures or retries. Also add an API to skip instance data cleanup by advancing the recycle state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING. Subsequent recycle rounds will skip object data cleanup and continue with metadata cleanup. Repeated DROP operations preserve the existing recycle state instead of resetting the recycle process.
Introduce a persistent recycle state for deleted instances to split instance recycling into separate data cleanup and metadata cleanup stages. The recycle process now transitions through: ``` DATA_CLEANUP_PENDING -> METADATA_CLEANUP_PENDING -> CLEANUP_COMPLETED ``` Each transition is persisted so that recycling can resume from the latest state after failures or retries. Also add an API to skip instance data cleanup by advancing the recycle state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING. Subsequent recycle rounds will skip object data cleanup and continue with metadata cleanup. Repeated DROP operations preserve the existing recycle state instead of resetting the recycle process.
Introduce a persistent recycle state for deleted instances to split instance recycling into separate data cleanup and metadata cleanup stages. The recycle process now transitions through: ``` DATA_CLEANUP_PENDING -> METADATA_CLEANUP_PENDING -> CLEANUP_COMPLETED ``` Each transition is persisted so that recycling can resume from the latest state after failures or retries. Also add an API to skip instance data cleanup by advancing the recycle state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING. Subsequent recycle rounds will skip object data cleanup and continue with metadata cleanup. Repeated DROP operations preserve the existing recycle state instead of resetting the recycle process.
Introduce a persistent recycle state for deleted instances to split instance recycling into separate data cleanup and metadata cleanup stages. The recycle process now transitions through: ``` DATA_CLEANUP_PENDING -> METADATA_CLEANUP_PENDING -> CLEANUP_COMPLETED ``` Each transition is persisted so that recycling can resume from the latest state after failures or retries. Also add an API to skip instance data cleanup by advancing the recycle state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING. Subsequent recycle rounds will skip object data cleanup and continue with metadata cleanup. Repeated DROP operations preserve the existing recycle state instead of resetting the recycle process.
Related PR: #66519 Problem Summary: The recycler previously removed the instance key after the recycle state reached INSTANCE_RECYCLE_STATE_CLEANUP_COMPLETED. This made the final recycle state unavailable and prevented successor-chain checks from distinguishing a completed successor from a missing instance. This change retains the deleted instance record as a tombstone, skips completed tombstones during scanning, excludes deleted instances from ResourceManager runtime indexes and caches, and allows predecessors to continue once their successor has completed cleanup.
Related PR: #66519 Problem Summary: The recycler previously removed the instance key after the recycle state reached INSTANCE_RECYCLE_STATE_CLEANUP_COMPLETED. This made the final recycle state unavailable and prevented successor-chain checks from distinguishing a completed successor from a missing instance. This change retains the deleted instance record as a tombstone, skips completed tombstones during scanning, excludes deleted instances from ResourceManager runtime indexes and caches, and allows predecessors to continue once their successor has completed cleanup.
What problem does this PR solve?
Introduce a persistent recycle state for deleted instances to split instance recycling into separate data cleanup and metadata cleanup stages.
The recycle process now transitions through:
Each transition is persisted so that recycling can resume from the latest state after failures or retries.
Also add an API to skip instance data cleanup by advancing the recycle state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING. Subsequent recycle rounds will skip object data cleanup and continue with metadata cleanup.
Repeated DROP operations preserve the existing recycle state instead of
resetting the recycle process.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)