Skip to content

branch-4.0: [fix](cloud) Track deleted instance recycle status (#66519) - #66679

Closed
wyxxxcat wants to merge 1 commit into
apache:branch-4.0from
wyxxxcat:pick_66519_4_0
Closed

branch-4.0: [fix](cloud) Track deleted instance recycle status (#66519)#66679
wyxxxcat wants to merge 1 commit into
apache:branch-4.0from
wyxxxcat:pick_66519_4_0

Conversation

@wyxxxcat

Copy link
Copy Markdown
Collaborator

pick: #66519

Introduce a persistent recycle state for deleted instances to split
instance recycling into separate data cleanup and metadata cleanup
stages.
The recycle process now transitions through:
```
DATA_CLEANUP_PENDING
-> METADATA_CLEANUP_PENDING
-> CLEANUP_COMPLETED
```
Each transition is persisted so that recycling can resume from the
latest state after failures or retries.
Also add an API to skip instance data cleanup by advancing the recycle
state directly from DATA_CLEANUP_PENDING to METADATA_CLEANUP_PENDING.
Subsequent recycle rounds will skip object data cleanup and continue
with metadata cleanup.
Repeated DROP operations preserve the existing recycle state instead of
resetting the recycle process.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 48.96% (212/433) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.63% (1869/2377)
Line Coverage65.43% (33583/51326)
Region Coverage65.87% (16569/25156)
Branch Coverage56.57% (8865/15670)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.64% (19651/36633)
Line Coverage36.72% (184231/501673)
Region Coverage33.25% (143137/430432)
Branch Coverage34.11% (61867/181367)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wyxxxcat@hello-stephen