[improvement](log) Log the user name of HTTP requests for auditing by liaoxin01 · Pull Request #66745 · apache/doris

liaoxin01 · 2026-08-13T15:36:26Z

What problem does this PR solve?

Problem Summary:

HttpRequest::debug_string() masks the whole Authorization header, so the BE request log shows that a request carried credentials but not whose, leaving operations such as /api/update_config without an audit trail. Keep the user name of HTTP Basic credentials and mask only the password, rendering <user>:***MASKED***. Every other sensitive header (token, auth-token, auth_code, proxy-authorization), every non-Basic scheme, and any credential that cannot be decoded stays masked in full. What is emitted is a rendering, not the header value: the real one is base64 encoded.

One more path wrote credentials to the logs in clear text and is fixed as well: FE's BaseController logged the raw Authorization header, that is base64(user:password), at INFO level when parsing failed. This is a parse failure rather than an authentication failure, so it runs before the password is verified and the header often carries valid credentials. Only whether the header was absent or malformed is logged now.

Note: an earlier revision of this PR also rewrote the permission verification failed log in HttpHandlerWithAuth, which streamed TCheckAuthRequest and let the thrift-generated printTo() dump passwd. #66618 has since landed a fix for that same leak, so this PR was rebased onto it and no longer touches that file.

Release note

None

Check List (For Author)

Test
- Unit Test
- Manual test (add detailed scripts or steps below)
HttpRequestTest covers the rendering of the Authorization header: the user name is kept for Basic credentials (including a password containing colons and a case insensitive scheme), while a malformed, undecodable or non-Basic credential and every other sensitive header stay masked in full.
Also verified on a single FE + BE cluster that no credential appears in fe.log, be.INFO or be.WARNING.
Behavior changed:
- No.
Does this need documentation?
- No.

hello-stephen · 2026-08-13T15:36:32Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

liaoxin01 · 2026-08-13T15:39:35Z

/review

liaoxin01 · 2026-08-13T15:48:43Z

run buildall

gavinchou

LGTM

github-actions · 2026-08-13T15:54:46Z

PR approved by at least one committer and no changes requested.

github-actions · 2026-08-13T15:54:49Z

PR approved by anyone and no changes requested.

liaoxin01 · 2026-08-14T01:39:38Z

run buildall

hello-stephen · 2026-08-14T03:12:47Z

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-08-14T04:36:20Z

BE Regression && UT Coverage Report

Increment line coverage 84.00% (21/25) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	76.11% (32570/42791)
Line Coverage	61.07% (366016/599352)
Region Coverage	57.85% (308510/533247)
Branch Coverage	59.12% (139795/236446)

hello-stephen · 2026-08-14T04:43:51Z

FE Regression Coverage Report

Increment line coverage 0.32% (2/633) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-08-14T08:48:09Z

TPC-H: Total hot run time: 17763 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3e76017c2409b86b41a1def4a6300d117bc6ca82, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17559	3047	3037	3037
q2	1941	241	158	158
q3	10407	877	513	513
q4	4669	244	195	195
q5	7685	566	385	385
q6	139	118	98	98
q7	531	505	387	387
q8	9241	922	926	922
q9	3430	2369	2406	2369
q10	6532	870	750	750
q11	440	269	233	233
q12	704	389	336	336
q13	17855	1878	1571	1571
q14	161	153	144	144
q15	q16	443	399	369	369
q17	826	798	769	769
q18	3174	2306	2291	2291
q19	1117	928	818	818
q20	655	529	452	452
q21	5332	1723	1940	1723
q22	334	277	243	243
Total cold run time: 93175 ms
Total hot run time: 17763 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3415	3364	3342	3342
q2	213	208	160	160
q3	2252	2329	2153	2153
q4	1187	1174	896	896
q5	2205	2130	2169	2130
q6	172	119	89	89
q7	1046	926	895	895
q8	1603	1394	1411	1394
q9	3126	3091	3066	3066
q10	1888	1835	1695	1695
q11	361	271	249	249
q12	472	450	339	339
q13	1835	1871	1536	1536
q14	192	183	157	157
q15	q16	402	408	358	358
q17	1032	1027	1025	1025
q18	5013	4528	4845	4528
q19	888	900	914	900
q20	959	975	817	817
q21	3896	3235	3285	3235
q22	488	364	337	337
Total cold run time: 32645 ms
Total hot run time: 29301 ms

hello-stephen · 2026-08-14T08:54:49Z

TPC-DS: Total hot run time: 86588 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e76017c2409b86b41a1def4a6300d117bc6ca82, data reload: false
query5	4245	404	330	330
query6	429	163	158	158
query7	4859	455	258	258
query8	293	126	112	112
query9	8705	2934	2920	2920
query10	418	249	215	215
query11	5384	1048	927	927
query12	126	74	71	71
query13	1200	444	335	335
query14	5965	2031	1879	1879
query14_1	1768	1771	1776	1771
query15	173	123	115	115
query16	929	374	361	361
query17	816	473	369	369
query18	2333	332	246	246
query19	177	145	122	122
query20	77	69	74	69
query21	209	123	104	104
query22	5536	5384	5324	5324
query23	7458	6839	6715	6715
query23_1	6802	6811	6775	6775
query24	7300	1094	765	765
query24_1	792	814	769	769
query25	438	318	264	264
query26	1254	265	161	161
query27	2721	464	290	290
query28	4635	1529	1522	1522
query29	944	473	366	366
query30	268	181	160	160
query31	971	667	613	613
query32	105	53	56	53
query33	464	218	185	185
query34	988	858	490	490
query35	418	414	342	342
query36	563	533	507	507
query37	125	84	76	76
query38	1003	882	813	813
query39	563	551	533	533
query39_1	542	513	534	513
query40	228	131	113	113
query41	58	58	55	55
query42	79	76	82	76
query43	253	252	224	224
query44	1045	585	579	579
query45	114	111	105	105
query46	805	873	601	601
query47	1002	967	943	943
query48	310	304	224	224
query49	539	269	189	189
query50	871	338	262	262
query51	8098	8353	8124	8124
query52	69	68	59	59
query53	202	220	162	162
query54	243	169	178	169
query55	73	57	53	53
query56	237	237	215	215
query57	655	633	608	608
query58	213	200	196	196
query59	1122	1146	1000	1000
query60	244	198	186	186
query61	113	113	110	110
query62	353	193	175	175
query63	182	154	154	154
query64	2638	649	527	527
query65	1529	1557	1569	1557
query66	1794	291	234	234
query67	9733	9764	9918	9764
query68	2857	1238	781	781
query69	359	230	197	197
query70	655	610	561	561
query71	289	259	236	236
query72	2360	1764	1590	1590
query73	638	621	351	351
query74	1850	1228	1144	1144
query75	1229	1164	1040	1040
query76	2286	750	554	554
query77	255	251	195	195
query78	5247	4901	4765	4765
query79	2337	835	603	603
query80	1567	408	374	374
query81	476	197	175	175
query82	615	129	106	106
query83	309	253	238	238
query84	297	121	101	101
query85	834	448	367	367
query86	384	177	164	164
query87	1020	998	915	915
query88	2818	2153	2169	2153
query89	310	229	203	203
query90	1846	150	146	146
query91	153	138	120	120
query92	53	48	49	48
query93	1479	1089	793	793
query94	613	245	231	231
query95	652	377	333	333
query96	791	595	265	265
query97	1127	1076	1052	1052
query98	168	143	135	135
query99	421	345	312	312
Total cold run time: 180562 ms
Total hot run time: 86588 ms

hello-stephen · 2026-08-14T08:59:12Z

ClickBench: Total hot run time: 14.76 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e76017c2409b86b41a1def4a6300d117bc6ca82, data reload: false
query1	0.01	0.00	0.01
query2	0.08	0.04	0.04
query3	0.24	0.09	0.11
query4	1.59	0.10	0.09
query5	0.17	0.17	0.17
query6	1.24	0.64	0.60
query7	0.03	0.01	0.01
query8	0.05	0.03	0.03
query9	0.30	0.22	0.23
query10	0.35	0.37	0.33
query11	0.15	0.11	0.12
query12	0.14	0.13	0.12
query13	0.30	0.31	0.31
query14	0.46	0.46	0.47
query15	0.37	0.36	0.36
query16	0.23	0.23	0.23
query17	0.67	0.70	0.73
query18	0.18	0.16	0.16
query19	1.20	1.14	1.20
query20	0.01	0.01	0.01
query21	15.43	0.15	0.11
query22	5.07	0.04	0.05
query23	16.17	0.25	0.11
query24	2.98	0.31	0.27
query25	0.12	0.04	0.04
query26	0.84	0.18	0.13
query27	0.04	0.02	0.04
query28	3.64	0.56	0.25
query29	12.48	3.13	2.55
query30	0.25	0.13	0.14
query31	2.76	0.37	0.17
query32	3.52	0.32	0.23
query33	1.51	1.55	1.45
query34	15.44	2.21	1.78
query35	1.81	1.78	1.81
query36	0.45	0.30	0.29
query37	0.06	0.04	0.04
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.12	0.07	0.07
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 90.67 s
Total hot run time: 14.76 s

HttpRequest::debug_string() masks the whole Authorization header, so the BE request log records that a request carried credentials but not whose. An operation such as /api/update_config therefore leaves no trace of who issued it. Keep the user name of HTTP Basic credentials and mask only the password, rendering "<user>:***MASKED***". Every other sensitive header (token, auth-token, auth_code, proxy-authorization), every non-Basic scheme, and any credential that cannot be decoded stays masked in full. The result is a rendering, not the header value: the real one is base64 encoded. FE's BaseController also logged the raw Authorization header at INFO level when it failed to parse it, that is base64(user:password). This is a parse failure rather than an authentication failure, so it runs before the password is verified and the header often carries valid credentials. Only whether the header was absent or malformed is logged now.

liaoxin01 · 2026-08-27T14:15:26Z

run buildall

hello-stephen · 2026-08-27T16:02:08Z

TPC-H: Total hot run time: 16919 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d7ce500696eafd773689c3288c2186f89e46eb16, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17627	3038	3040	3038
q2	2078	255	223	223
q3	10250	878	514	514
q4	4679	242	199	199
q5	7679	595	390	390
q6	141	112	93	93
q7	534	500	391	391
q8	9250	901	948	901
q9	3489	2390	2403	2390
q10	6521	849	716	716
q11	398	191	185	185
q12	610	260	197	197
q13	18162	1532	1157	1157
q14	153	150	140	140
q15	q16	435	389	366	366
q17	1368	921	792	792
q18	3044	2247	2241	2241
q19	1117	839	767	767
q20	373	291	197	197
q21	4925	1794	1819	1794
q22	311	262	228	228
Total cold run time: 93144 ms
Total hot run time: 16919 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3390	3333	3324	3324
q2	521	407	363	363
q3	2260	2309	2197	2197
q4	1178	1158	900	900
q5	2175	2110	2110	2110
q6	168	117	88	88
q7	1033	912	878	878
q8	1605	1392	1402	1392
q9	3103	3073	3088	3073
q10	1880	1775	1672	1672
q11	353	274	249	249
q12	453	425	331	331
q13	1474	1539	1154	1154
q14	170	173	151	151
q15	q16	387	395	368	368
q17	3594	3388	3213	3213
q18	4801	4444	4763	4444
q19	905	805	940	805
q20	1034	966	840	840
q21	3820	3110	3261	3110
q22	398	348	321	321
Total cold run time: 34702 ms
Total hot run time: 30983 ms

hello-stephen · 2026-08-27T16:08:34Z

TPC-DS: Total hot run time: 81525 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d7ce500696eafd773689c3288c2186f89e46eb16, data reload: false
query5	4285	421	349	349
query6	395	163	129	129
query7	4886	430	231	231
query8	302	133	131	131
query9	8693	2881	2863	2863
query10	392	216	187	187
query11	5389	1037	915	915
query12	121	73	80	73
query13	1196	435	341	341
query14	6104	2201	2065	2065
query14_1	1969	1945	1961	1945
query15	175	123	121	121
query16	908	371	377	371
query17	810	469	374	374
query18	2334	327	242	242
query19	167	137	118	118
query20	71	72	70	70
query21	201	103	89	89
query22	5343	5464	5259	5259
query23	6615	6232	6089	6089
query23_1	6187	5994	6136	5994
query24	7274	1099	781	781
query24_1	745	751	770	751
query25	441	311	274	274
query26	1231	234	134	134
query27	2785	401	260	260
query28	4689	1492	1503	1492
query29	938	448	348	348
query30	249	157	135	135
query31	835	397	324	324
query32	127	75	75	75
query33	470	229	183	183
query34	964	829	451	451
query35	394	407	339	339
query36	570	555	533	533
query37	122	87	73	73
query38	1002	852	792	792
query39	493	470	463	463
query39_1	461	486	482	482
query40	204	99	82	82
query41	58	56	56	56
query42	75	72	73	72
query43	241	246	210	210
query44	1021	556	555	555
query45	117	105	103	103
query46	858	849	509	509
query47	746	764	699	699
query48	316	290	231	231
query49	542	237	182	182
query50	770	259	196	196
query51	7910	7870	7929	7870
query52	66	66	60	60
query53	192	202	159	159
query54	241	181	183	181
query55	74	59	56	56
query56	206	172	158	158
query57	691	665	670	665
query58	212	189	214	189
query59	1212	1233	1092	1092
query60	250	182	172	172
query61	131	123	135	123
query62	389	214	189	189
query63	179	151	139	139
query64	2825	698	565	565
query65	1615	1581	1553	1553
query66	1813	285	209	209
query67	9803	9487	9597	9487
query68	2762	1227	679	679
query69	351	235	196	196
query70	669	616	608	608
query71	247	176	173	173
query72	2318	1698	1569	1569
query73	638	583	354	354
query74	1581	1222	1134	1134
query75	1180	1089	951	951
query76	2284	747	547	547
query77	263	251	210	210
query78	3927	3677	3202	3202
query79	1404	804	580	580
query80	1183	323	281	281
query81	484	152	136	136
query82	606	122	94	94
query83	286	204	184	184
query84	296	109	91	91
query85	781	358	299	299
query86	390	167	166	166
query87	1006	968	883	883
query88	2774	2100	2100	2100
query89	279	196	175	175
query90	1979	124	122	122
query91	130	119	98	98
query92	81	72	67	67
query93	1293	1074	660	660
query94	631	245	220	220
query95	508	332	226	226
query96	808	632	283	283
query97	1068	1069	969	969
query98	147	137	135	135
query99	414	335	309	309
Total cold run time: 175243 ms
Total hot run time: 81525 ms

hello-stephen · 2026-08-27T16:12:55Z

ClickBench: Total hot run time: 14.56 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d7ce500696eafd773689c3288c2186f89e46eb16, data reload: false
query1	0.01	0.01	0.00
query2	0.08	0.04	0.03
query3	0.25	0.11	0.10
query4	1.61	0.10	0.09
query5	0.17	0.15	0.17
query6	1.29	0.68	0.68
query7	0.04	0.00	0.01
query8	0.05	0.04	0.03
query9	0.29	0.21	0.20
query10	0.34	0.37	0.35
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.30	0.30	0.29
query14	0.46	0.47	0.43
query15	0.36	0.34	0.34
query16	0.21	0.22	0.23
query17	0.69	0.68	0.68
query18	0.18	0.17	0.17
query19	1.16	1.13	1.18
query20	0.02	0.01	0.01
query21	15.45	0.17	0.11
query22	5.07	0.04	0.04
query23	16.18	0.25	0.11
query24	3.05	0.31	0.25
query25	0.11	0.04	0.03
query26	0.79	0.16	0.13
query27	0.02	0.03	0.04
query28	3.63	0.58	0.27
query29	12.43	3.15	2.54
query30	0.26	0.12	0.12
query31	2.75	0.38	0.17
query32	3.52	0.31	0.22
query33	1.50	1.40	1.41
query34	15.35	2.17	1.78
query35	1.72	1.71	1.73
query36	0.45	0.30	0.29
query37	0.06	0.04	0.03
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.11	0.08	0.08
query41	0.07	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 90.49 s
Total hot run time: 14.56 s

hello-stephen · 2026-08-27T16:15:33Z

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-08-27T17:19:41Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	62.70% (29321/46766)
Line Coverage	47.68% (306723/643288)
Region Coverage	43.30% (247590/571862)
Branch Coverage	44.88% (115319/256970)

hello-stephen · 2026-08-27T18:09:35Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.93% (34391/45294)
Line Coverage	60.91% (387313/635925)
Region Coverage	57.02% (324835/569679)
Branch Coverage	57.86% (148266/256237)

hello-stephen · 2026-08-27T18:36:51Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

liaoxin01 · 2026-08-28T07:22:16Z

run buildall

hello-stephen · 2026-08-28T08:55:18Z

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-08-28T09:16:51Z

TPC-H: Total hot run time: 17024 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d7ce500696eafd773689c3288c2186f89e46eb16, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17579	3063	3021	3021
q2	2129	279	232	232
q3	10199	962	546	546
q4	4669	265	203	203
q5	7660	582	386	386
q6	139	119	98	98
q7	590	497	388	388
q8	9241	926	922	922
q9	3501	2433	2415	2415
q10	6502	906	736	736
q11	397	203	185	185
q12	619	259	199	199
q13	18127	1551	1168	1168
q14	165	150	144	144
q15	q16	440	399	378	378
q17	1493	921	868	868
q18	3075	2239	2261	2239
q19	1111	933	748	748
q20	367	312	212	212
q21	4859	1700	1931	1700
q22	332	273	236	236
Total cold run time: 93194 ms
Total hot run time: 17024 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3415	3368	3351	3351
q2	506	405	384	384
q3	2298	2366	2240	2240
q4	1208	1191	925	925
q5	2214	2161	2139	2139
q6	171	119	87	87
q7	1073	965	914	914
q8	1612	1436	1444	1436
q9	3198	3180	3131	3131
q10	1920	1841	1668	1668
q11	370	282	267	267
q12	469	442	360	360
q13	1492	1594	1180	1180
q14	175	177	163	163
q15	q16	393	416	371	371
q17	3637	3446	3478	3446
q18	4956	4510	4988	4510
q19	961	846	883	846
q20	1009	975	832	832
q21	3880	3290	3267	3267
q22	415	352	336	336
Total cold run time: 35372 ms
Total hot run time: 31853 ms

hello-stephen · 2026-08-28T09:23:28Z

TPC-DS: Total hot run time: 83721 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d7ce500696eafd773689c3288c2186f89e46eb16, data reload: false
query5	4299	427	348	348
query6	387	142	132	132
query7	4906	445	238	238
query8	308	129	123	123
query9	8710	3023	3056	3023
query10	416	235	188	188
query11	5414	1059	953	953
query12	121	74	72	72
query13	1213	472	321	321
query14	6099	2249	2161	2161
query14_1	2078	2027	2006	2006
query15	171	122	116	116
query16	957	381	368	368
query17	820	484	376	376
query18	2354	347	255	255
query19	176	143	120	120
query20	80	72	73	72
query21	204	105	90	90
query22	5386	5287	5305	5287
query23	6843	6270	6071	6071
query23_1	6164	6243	6155	6155
query24	7328	1123	787	787
query24_1	794	797	798	797
query25	424	286	238	238
query26	1248	244	124	124
query27	2765	445	241	241
query28	4686	1513	1484	1484
query29	927	427	354	354
query30	249	157	130	130
query31	829	394	338	338
query32	176	70	71	70
query33	466	219	187	187
query34	991	837	490	490
query35	431	405	357	357
query36	586	593	532	532
query37	132	83	75	75
query38	1041	864	814	814
query39	521	507	472	472
query39_1	488	468	492	468
query40	204	91	75	75
query41	56	53	53	53
query42	75	73	72	72
query43	249	245	215	215
query44	1024	549	557	549
query45	116	107	99	99
query46	784	821	527	527
query47	778	790	746	746
query48	308	294	219	219
query49	551	251	196	196
query50	746	278	200	200
query51	8276	8127	8091	8091
query52	70	68	66	66
query53	187	195	148	148
query54	233	176	241	176
query55	80	63	59	59
query56	198	180	163	163
query57	717	694	647	647
query58	217	172	167	167
query59	1243	1292	1132	1132
query60	238	205	213	205
query61	124	128	140	128
query62	392	210	191	191
query63	179	144	148	144
query64	2710	717	667	667
query65	1690	1606	1605	1605
query66	1835	260	203	203
query67	10213	10015	10111	10015
query68	3040	1179	764	764
query69	400	235	208	208
query70	682	620	601	601
query71	265	187	169	169
query72	2408	1914	1730	1730
query73	644	614	352	352
query74	2022	1265	1173	1173
query75	1216	1127	986	986
query76	2388	765	552	552
query77	278	280	222	222
query78	4010	3739	3231	3231
query79	2774	848	576	576
query80	1567	320	275	275
query81	527	162	137	137
query82	1207	130	99	99
query83	284	221	195	195
query84	306	113	92	92
query85	850	397	302	302
query86	513	191	179	179
query87	1045	1001	929	929
query88	3206	2127	2130	2127
query89	291	199	176	176
query90	2161	141	134	134
query91	136	124	100	100
query92	104	74	63	63
query93	2616	1060	685	685
query94	665	270	255	255
query95	511	259	235	235
query96	854	553	294	294
query97	1091	1052	991	991
query98	194	147	141	141
query99	485	357	310	310
Total cold run time: 182841 ms
Total hot run time: 83721 ms

hello-stephen · 2026-08-28T09:27:51Z

ClickBench: Total hot run time: 14.93 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d7ce500696eafd773689c3288c2186f89e46eb16, data reload: false
query1	0.01	0.00	0.00
query2	0.08	0.04	0.04
query3	0.26	0.12	0.11
query4	1.61	0.09	0.10
query5	0.17	0.16	0.16
query6	1.25	0.70	0.69
query7	0.03	0.01	0.00
query8	0.05	0.03	0.03
query9	0.29	0.22	0.24
query10	0.36	0.36	0.36
query11	0.16	0.11	0.12
query12	0.16	0.13	0.13
query13	0.32	0.32	0.32
query14	0.45	0.46	0.46
query15	0.38	0.35	0.36
query16	0.23	0.23	0.24
query17	0.72	0.73	0.71
query18	0.18	0.16	0.17
query19	1.23	1.10	1.23
query20	0.02	0.01	0.01
query21	15.43	0.16	0.13
query22	5.06	0.04	0.04
query23	16.16	0.25	0.10
query24	2.99	0.32	0.24
query25	0.10	0.04	0.04
query26	0.77	0.17	0.11
query27	0.03	0.03	0.03
query28	3.60	0.57	0.28
query29	12.47	3.18	2.59
query30	0.26	0.11	0.13
query31	2.75	0.38	0.17
query32	3.51	0.33	0.23
query33	1.40	1.47	1.64
query34	15.38	2.32	1.85
query35	1.82	1.76	1.72
query36	0.46	0.30	0.31
query37	0.06	0.04	0.04
query38	0.05	0.04	0.03
query39	0.04	0.02	0.03
query40	0.13	0.08	0.08
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 90.58 s
Total hot run time: 14.93 s

hello-stephen · 2026-08-28T11:13:05Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.85% (34368/45309)
Line Coverage	60.84% (387021/636082)
Region Coverage	56.96% (324619/569927)
Branch Coverage	57.81% (148184/256311)

hello-stephen · 2026-08-28T11:16:28Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.85% (34368/45309)
Line Coverage	60.84% (387003/636082)
Region Coverage	56.95% (324583/569927)
Branch Coverage	57.81% (148170/256311)

hello-stephen · 2026-08-28T12:15:44Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	76.01% (34441/45309)
Line Coverage	61.00% (388002/636082)
Region Coverage	57.17% (325843/569927)
Branch Coverage	57.97% (148588/256311)

hello-stephen · 2026-08-30T15:23:55Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	76.08% (34471/45309)
Line Coverage	61.06% (388365/636082)
Region Coverage	57.24% (326254/569927)
Branch Coverage	58.02% (148716/256311)

…66745) ### What problem does this PR solve? Problem Summary: `HttpRequest::debug_string()` masks the whole `Authorization` header, so the BE request log shows that a request carried credentials but not whose, leaving operations such as `/api/update_config` without an audit trail. Keep the user name of HTTP Basic credentials and mask only the password, rendering `<user>:***MASKED***`. Every other sensitive header (`token`, `auth-token`, `auth_code`, `proxy-authorization`), every non-Basic scheme, and any credential that cannot be decoded stays masked in full. What is emitted is a rendering, not the header value: the real one is base64 encoded. One more path wrote credentials to the logs in clear text and is fixed as well: FE's `BaseController` logged the raw `Authorization` header, that is `base64(user:password)`, at INFO level when parsing failed. This is a parse failure rather than an authentication failure, so it runs before the password is verified and the header often carries valid credentials. Only whether the header was absent or malformed is logged now. Note: an earlier revision of this PR also rewrote the `permission verification failed` log in `HttpHandlerWithAuth`, which streamed `TCheckAuthRequest` and let the thrift-generated `printTo()` dump `passwd`. #66618 has since landed a fix for that same leak, so this PR was rebased onto it and no longer touches that file. ### Release note None ### Check List (For Author) - Test - [x] Unit Test - [x] Manual test (add detailed scripts or steps below) `HttpRequestTest` covers the rendering of the `Authorization` header: the user name is kept for Basic credentials (including a password containing colons and a case insensitive scheme), while a malformed, undecodable or non-Basic credential and every other sensitive header stay masked in full. Also verified on a single FE + BE cluster that no credential appears in `fe.log`, `be.INFO` or `be.WARNING`. - Behavior changed: - [x] No. - Does this need documentation? - [x] No.

… auditing #66745 (#67319) Cherry-picked from #66745 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

liaoxin01 added the dev/4.1.x label Aug 13, 2026

gavinchou reviewed Aug 13, 2026
View reviewed changes

Comment threadbe/src/service/http/http_request.cpp

gavinchou previously approved these changes Aug 13, 2026
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2026

github-actionsBot added the reviewed label Aug 13, 2026

gavinchou added dev/3.1.x dev/4.0.x labels Aug 13, 2026

liaoxin01 dismissed gavinchou’s stale review via 2a7c34bAugust 13, 2026 16:00

liaoxin01 force-pushed the http-log-credential-redaction branch from fd652da to 2a7c34bCompare August 13, 2026 16:00

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Aug 13, 2026

liaoxin01 force-pushed the http-log-credential-redaction branch from 2a7c34b to 3e76017Compare August 14, 2026 01:35

liaoxin01 force-pushed the http-log-credential-redaction branch from 3e76017 to d7ce500Compare August 27, 2026 14:14

gavinchou approved these changes Aug 31, 2026
View reviewed changes

gavinchou merged commit 2befeb3 into apache:masterAug 31, 2026
29 of 31 checks passed

github-actionsBot mentioned this pull request Aug 31, 2026
branch-4.1: [improvement](log) Log the user name of HTTP requests for auditing #66745 #67319
Merged

yiguolei pushed a commit that referenced this pull request Sep 7, 2026
branch-4.1: [improvement](log) Log the user name of HTTP requests for…
e0cfca1
… auditing #66745 (#67319) Cherry-picked from #66745 Co-authored-by: Xin Liao <liaoxin@selectdb.com>

yiguolei added dev/4.1.5-merged and removed dev/4.1.x labels Sep 7, 2026

Uh oh!

Conversation

liaoxin01 commented Aug 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Uh oh!

hello-stephen commented Aug 13, 2026

Uh oh!

liaoxin01 commented Aug 13, 2026

Uh oh!

liaoxin01 commented Aug 13, 2026

Uh oh!

Uh oh!

gavinchou left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 13, 2026

Uh oh!

github-actionsBot commented Aug 13, 2026

Uh oh!

liaoxin01 commented Aug 14, 2026

Uh oh!

hello-stephen commented Aug 14, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Aug 14, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 14, 2026

FE Regression Coverage Report

Uh oh!

hello-stephen commented Aug 14, 2026

Uh oh!

hello-stephen commented Aug 14, 2026

Uh oh!

hello-stephen commented Aug 14, 2026

Uh oh!

liaoxin01 commented Aug 27, 2026

Uh oh!

hello-stephen commented Aug 27, 2026

Uh oh!

hello-stephen commented Aug 27, 2026

Uh oh!

hello-stephen commented Aug 27, 2026

Uh oh!

hello-stephen commented Aug 27, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Aug 27, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 27, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 27, 2026

FE Regression Coverage Report

Uh oh!

liaoxin01 commented Aug 28, 2026

Uh oh!

hello-stephen commented Aug 28, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Aug 28, 2026

Uh oh!

hello-stephen commented Aug 28, 2026

Uh oh!

hello-stephen commented Aug 28, 2026

Uh oh!

hello-stephen commented Aug 28, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 28, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 28, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Aug 30, 2026

liaoxin01 commented Aug 13, 2026•
edited
Loading