Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [improvement](log) Log the user name of HTTP requests for auditing #66745 - #67319
Merged
Merged
Conversation
hello-stephen
commented
Aug 31, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Aug 31, 2026
Contributor
run buildall |
…66745) ### What problem does this PR solve? Problem Summary: `HttpRequest::debug_string()` masks the whole `Authorization` header, so the BE request log shows that a request carried credentials but not whose, leaving operations such as `/api/update_config` without an audit trail. Keep the user name of HTTP Basic credentials and mask only the password, rendering `<user>:***MASKED***`. Every other sensitive header (`token`, `auth-token`, `auth_code`, `proxy-authorization`), every non-Basic scheme, and any credential that cannot be decoded stays masked in full. What is emitted is a rendering, not the header value: the real one is base64 encoded. One more path wrote credentials to the logs in clear text and is fixed as well: FE's `BaseController` logged the raw `Authorization` header, that is `base64(user:password)`, at INFO level when parsing failed. This is a parse failure rather than an authentication failure, so it runs before the password is verified and the header often carries valid credentials. Only whether the header was absent or malformed is logged now. Note: an earlier revision of this PR also rewrote the `permission verification failed` log in `HttpHandlerWithAuth`, which streamed `TCheckAuthRequest` and let the thrift-generated `printTo()` dump `passwd`. #66618 has since landed a fix for that same leak, so this PR was rebased onto it and no longer touches that file. ### Release note None ### Check List (For Author) - Test - [x] Unit Test - [x] Manual test (add detailed scripts or steps below) `HttpRequestTest` covers the rendering of the `Authorization` header: the user name is kept for Basic credentials (including a password containing colons and a case insensitive scheme), while a malformed, undecodable or non-Basic credential and every other sensitive header stay masked in full. Also verified on a single FE + BE cluster that no credential appears in `fe.log`, `be.INFO` or `be.WARNING`. - Behavior changed: - [x] No. - Does this need documentation? - [x] No.
yiguoleiforce-pushed
the
auto-pick-66745-branch-4.1
branch
from
September 6, 2026 07:57
9d4e63a to
23bdf9cCompareyiguolei
commented
Sep 6, 2026
Contributor
run buildall |
hello-stephen
commented
Sep 6, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Sep 7, 2026
ContributorAuthor
PR approved by anyone and no changes requested. |
ContributorAuthor
PR approved by at least one committer and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #66745