Skip to content

HBASE-29303 [hbase-thirdparty] Bump protobuf java to 4.30.2 - #136

Merged
NihalJain merged 4 commits into
apache:masterfrom
NihalJain:HBASE-29303
May 20, 2025
Merged

HBASE-29303 [hbase-thirdparty] Bump protobuf java to 4.30.2#136
NihalJain merged 4 commits into
apache:masterfrom
NihalJain:HBASE-29303

Conversation

@NihalJain

@NihalJainNihalJain commented May 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@NihalJain
NihalJain marked this pull request as draft May 14, 2025 08:09
@NihalJain

NihalJain commented May 14, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Compilation will fail as variable recursionDepth no longer exists in protobuf and was removed with commit protocolbuffers/protobuf@a4d4bfe

I will try to modify the existing patch https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-protobuf/src/main/patches/HBASE-15789_V3.patch which requires this field!

@NihalJain
NihalJain marked this pull request as ready for review May 14, 2025 08:18
@NihalJain

NihalJain commented May 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Compilation will fail as variable recursionDepth no longer exists in protobug and was removed with commit protocolbuffers/protobuf@a4d4bfe

I will try to modify the existing patch https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-protobuf/src/main/patches/HBASE-15789_V3.patch which requires this field!

Second commit handles this issue!

@Apache-HBase

Apache-HBase commented May 14, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall0m 44smaster passed
+1 💚compile0m 24smaster passed
+1 💚javadoc0m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
-1 ❌mvninstall0m 10shbase-shaded-protobuf in the patch failed.
-1 ❌mvninstall0m 32sroot in the patch failed.
-1 ❌compile0m 10shbase-shaded-protobuf in the patch failed.
-1 ❌compile0m 9sroot in the patch failed.
-1 ❌javac0m 10shbase-shaded-protobuf in the patch failed.
-1 ❌javac0m 9sroot in the patch failed.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 13sthe patch passed
_ Other Tests _
-1 ❌unit0m 9shbase-shaded-protobuf in the patch failed.
-1 ❌unit0m 48sroot in the patch failed.
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
5m 26s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#136
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 2dd4a20abbd5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 6016e75
Default JavaTemurin-1.8.0_452-b09
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javachttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
unithttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
unithttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/testReport/
Max. process+thread count398 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

NihalJain commented May 14, 2025

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 0m 44s master passed
+1 💚 compile 0m 24s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 10s hbase-shaded-protobuf in the patch failed.
-1 ❌ mvninstall 0m 32s root in the patch failed.
-1 ❌ compile 0m 10s hbase-shaded-protobuf in the patch failed.
-1 ❌ compile 0m 9s root in the patch failed.
-1 ❌ javac 0m 10s hbase-shaded-protobuf in the patch failed.
-1 ❌ javac 0m 9s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
-1 ❌ unit 0m 9s hbase-shaded-protobuf in the patch failed.
-1 ❌ unit 0m 48s root in the patch failed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
5m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #136
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 2dd4a20abbd5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
git revision master / 6016e75
Default Java Temurin-1.8.0_452-b09
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
mvninstall https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
compile https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
javac https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javac https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-compile-root.txt
unit https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
unit https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/testReport/
Max. process+thread count 398 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf . U: .
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/1/console
versions git=2.43.0 maven=3.9.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org
This message was automatically generated.

Failed, as expected!

@NihalJain
NihalJain requested a review from ndimidukMay 14, 2025 08:22
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@stoty

stoty commented May 14, 2025

Copy link
Copy Markdown
Contributor

Is the protobuf fork we're generating the patch from available somewhere ( i.e. github.com )?

@NihalJain

NihalJain commented May 14, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Is the protobuf fork we're generating the patch from available somewhere ( i.e. github.com )?

Yes please refer README.md of thirdparty repo. I added steps to generate patch from protobuf clone during last release.

For this PR, I checked out v30.2.

@Apache-HBase

Apache-HBase commented May 14, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for branch
+1 💚mvninstall0m 36smaster passed
+1 💚compile0m 23smaster passed
+1 💚javadoc0m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
-1 ❌mvninstall0m 5shbase-shaded-protobuf in the patch failed.
-1 ❌mvninstall0m 29sroot in the patch failed.
-1 ❌compile0m 6shbase-shaded-protobuf in the patch failed.
-1 ❌compile0m 6sroot in the patch failed.
-1 ❌javac0m 6shbase-shaded-protobuf in the patch failed.
-1 ❌javac0m 6sroot in the patch failed.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 13sthe patch passed
_ Other Tests _
-1 ❌unit0m 5shbase-shaded-protobuf in the patch failed.
-1 ❌unit0m 41sroot in the patch failed.
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
3m 56s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#136
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux bb6a94748441 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 6016e75
Default JavaTemurin-1.8.0_452-b09
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javachttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-compile-root.txt
unithttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
unithttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/testReport/
Max. process+thread count395 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

NihalJain commented May 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Strange even though I have renamed the patch file it is still applying old one not sure how.

[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789_V3.patch
[INFO] Applying patch: HBASE-15789_V4.patch

Ref https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/3/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt

NihalJain
NihalJain commented May 14, 2025
View reviewed changes
Comment threadhbase-shaded-protobuf/pom.xml Outdated
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

Apache-HBase commented May 15, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗markdownlint0m 0smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for branch
+1 💚mvninstall0m 37smaster passed
+1 💚compile0m 23smaster passed
+1 💚javadoc0m 13smaster passed
-0 ⚠️patch1m 27sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
+1 💚mvninstall0m 56sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 0sThe patch has no ill-formed XML file.
+1 💚javadoc0m 16sthe patch passed
_ Other Tests _
+1 💚unit0m 18shbase-shaded-protobuf in the patch passed.
+1 💚unit1m 6sroot in the patch passed.
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
5m 22s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/9/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#136
Optional Testsdupname asflicense javac javadoc unit xml compile markdownlint
unameLinux 3c9c65d9fa11 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 6016e75
Default JavaTemurin-1.8.0_452-b09
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/9/testReport/
Max. process+thread count395 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/9/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

NihalJain commented May 15, 2025

Copy link
Copy Markdown
ContributorAuthor

Finally a Pass 😌

[INFO] --- patch:1.2:apply (patch) @ hbase-shaded-protobuf ---
[INFO] Applying patch: HBASE-15789_V4.patch
[INFO] Applying patch: HBASE-17087.patch
[INFO] Applying patch: HBASE-17239.patch

Hi @stoty , @Apache9 does this look good? Should I go ahead run this PR and #135 against hbase master branch?

@NihalJainNihalJain mentioned this pull request May 15, 2025
Closed
stoty
stoty reviewed May 16, 2025
View reviewed changes
Comment threadREADME.md

```
HBASE-15789_V3.patch
HBASE-15789_V4.patch

@stotystotyMay 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure versioning this patch is useful.

@NihalJainNihalJainMay 20, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised https://issues.apache.org/jira/browse/HBASE-29343

stoty
stoty approved these changes May 16, 2025
View reviewed changes

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@stoty

stoty commented May 16, 2025

Copy link
Copy Markdown
Contributor

Sure, running a full CI build is the only way to validate.

@NihalJain

NihalJain commented May 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Sure, running a full CI build is the only way to validate.

Build passes with this change, refer apache/hbase#6993

@Apache-HBase

Apache-HBase commented May 19, 2025

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 1sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗markdownlint0m 0smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
-1 ❌mvninstall0m 17sroot in master failed.
-1 ❌compile0m 17sroot in master failed.
-1 ❌compile0m 18shbase-shaded-protobuf in master failed.
-1 ❌javadoc0m 17sroot in master failed.
-1 ❌javadoc0m 18shbase-shaded-protobuf in master failed.
-0 ⚠️patch2m 32sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for patch
-1 ❌mvninstall0m 18sroot in the patch failed.
-1 ❌mvninstall0m 17shbase-shaded-protobuf in the patch failed.
-1 ❌compile0m 17sroot in the patch failed.
-1 ❌compile0m 18shbase-shaded-protobuf in the patch failed.
-1 ❌javac0m 17sroot in the patch failed.
-1 ❌javac0m 18shbase-shaded-protobuf in the patch failed.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
-1 ❌javadoc0m 17sroot in the patch failed.
-1 ❌javadoc0m 17shbase-shaded-protobuf in the patch failed.
_ Other Tests _
-1 ❌unit0m 17sroot in the patch failed.
-1 ❌unit0m 17shbase-shaded-protobuf in the patch failed.
+0 🆗asflicense0m 34sASF License check generated no output?
8m 2s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#136
Optional Testsdupname asflicense javac javadoc unit xml compile markdownlint
unameLinux add74a049221 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 6016e75
Default JavaTemurin-1.8.0_452-b09
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-compile-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-compile-hbase-shaded-protobuf.txt
javadochttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-javadoc-root.txt
javadochttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/branch-javadoc-hbase-shaded-protobuf.txt
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt
mvninstallhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-shaded-protobuf.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javachttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-compile-hbase-shaded-protobuf.txt
javadochttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-javadoc-root.txt
javadochttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-javadoc-hbase-shaded-protobuf.txt
unithttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-unit-root.txt
unithttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/artifact/yetus-precommit-check/output/patch-unit-hbase-shaded-protobuf.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/testReport/
Max. process+thread count20 (vs. ulimit of 1000)
modulesC: . hbase-shaded-protobuf U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/10/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 20, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗markdownlint0m 1smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall0m 43smaster passed
+1 💚compile0m 23smaster passed
+1 💚javadoc0m 13smaster passed
-0 ⚠️patch1m 47sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚mvninstall0m 52sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 0sThe patch has no ill-formed XML file.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 11shbase-shaded-protobuf in the patch passed.
+1 💚unit0m 47sroot in the patch passed.
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
5m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/11/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#136
Optional Testsdupname asflicense javac javadoc unit xml compile markdownlint
unameLinux 675b136a2947 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 6016e75
Default JavaTemurin-1.8.0_452-b09
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/11/testReport/
Max. process+thread count383 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/11/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk approved these changes May 20, 2025
View reviewed changes

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch management is so tedious.

@Apache-HBase

Apache-HBase commented May 20, 2025

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗markdownlint0m 0smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall0m 45smaster passed
+1 💚compile0m 23smaster passed
+1 💚javadoc0m 12smaster passed
-0 ⚠️patch1m 44sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 6sMaven dependency ordering for patch
+1 💚mvninstall0m 52sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 0sThe patch has no ill-formed XML file.
+1 💚javadoc0m 11sthe patch passed
_ Other Tests _
+1 💚unit0m 10shbase-shaded-protobuf in the patch passed.
+1 💚unit0m 48sroot in the patch passed.
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
5m 30s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/12/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR#136
Optional Testsdupname asflicense javac javadoc unit xml compile markdownlint
unameLinux 8e75e723741c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
git revisionmaster / 848f4b3
Default JavaTemurin-1.8.0_452-b09
Test Resultshttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/12/testReport/
Max. process+thread count397 (vs. ulimit of 1000)
modulesC: hbase-shaded-protobuf . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-136/12/console
versionsgit=2.43.0 maven=3.9.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain merged commit ad09819 into apache:masterMay 20, 2025
@NihalJain

NihalJain commented May 20, 2025

Copy link
Copy Markdown
ContributorAuthor

This patch management is so tedious.

Yes, it really is. Let me raise a JIRA to at least change the requirement to rename a patch as @stoty also suggested seems to be not much useful.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukndimiduk approved these changes
@Apache9Apache9Awaiting requested review from Apache9
@pankaj72981pankaj72981Awaiting requested review from pankaj72981
+2 more reviewers
@stotystotystoty approved these changes
@mnpooniamnpooniamnpoonia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NihalJain@Apache-HBase@stoty@ndimiduk@mnpoonia