HBASE-29317 Bump hbase-thirdparty to 4.1.11 by NihalJain · Pull Request #6993 · apache/hbase

NihalJain · 2025-05-15T20:56:45Z

Update allowed_expr to allow org/jspecify/annotation/*.class which is coming from guava due to google/guava@2cc8c5e
Bump maven-shade-plugin to 3.6.0 as we see failure META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66 due to FasterXML/jackson-core@7d8dc09
Add --should-stop=ifError=FLOW as compilerArgs. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details!

NihalJain · 2025-05-15T20:58:24Z

This PR consumes apache/hbase-thirdparty#137 to check for any regression
NOTE: 4.1.11 is not yet released, so we are testing against a SNAPSHOT here!

NihalJain · 2025-05-16T05:38:51Z

Ran one of failing test locally, no issue. Re-triggered the job!

NihalJain · 2025-05-16T18:26:08Z

Ah protobuf change was missing, re-run with https://repository.apache.org/content/repositories/snapshots/org/apache/hbase/thirdparty/hbase-thirdparty/4.1.11-SNAPSHOT/hbase-thirdparty-4.1.11-20250516.182246-5.pom

* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09

… error prone >= 2.36.0. See google/error-prone@e71db1f

NihalJain · 2025-05-29T19:23:49Z

Failures are not related!

Apache-HBase · 2025-05-31T23:32:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 41s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 31s		master passed
+1 💚	compile	8m 3s		master passed
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	8m 15s		the patch passed
-0 ⚠️	javac	8m 15s	/results-compile-javac-root.txt	root generated 489 new + 1250 unchanged - 24 fixed = 1739 total (was 1274)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 1s		No new issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	12m 3s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 52s		The patch does not generate ASF License warnings.
		46m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6993
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile shellcheck shelldocs
uname	Linux e58f074ddd76 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bbedbe4`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	188 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-examples hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/console
versions	git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-06-01T04:34:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s		master passed
+1 💚	compile	2m 10s		master passed
+1 💚	javadoc	2m 46s		master passed
+1 💚	shadedjars	6m 12s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	2m 13s		the patch passed
+1 💚	javac	2m 13s		the patch passed
+1 💚	javadoc	2m 46s		the patch passed
+1 💚	shadedjars	6m 4s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	287m 39s		root in the patch passed.
		324m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6993
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0ddbaee8f2af 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bbedbe4`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/testReport/
Max. process+thread count	8308 (vs. ulimit of 30000)
modules	C: hbase-build-configuration hbase-examples hbase-shaded hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

stoty

+1 LGTM

NihalJain · 2025-06-02T05:45:16Z

Thank you @stoty for the review, I will merge this in next 2 hours.

* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>

* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! Signed-off-by: Istvan Toth <stoty@apache.org> (cherry picked from commit 899e4fc)

* Update allowed_expr to allow `org/jspecify/annotation/*.class` which is coming from guava due to google/guava@2cc8c5e * Bump maven-shade-plugin to 3.6.0 as we see failure `META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_19_0/FastDoubleSwar.class: java.lang.IllegalArgumentException: Unsupported class file major version 66` due to FasterXML/jackson-core@7d8dc09 * Add `--should-stop=ifError=FLOW` as `compilerArgs`. This is required by error prone >= 2.36.0, otherwise compile fails. See google/error-prone@e71db1f for details! But since we do not upgrade to 2.36.0 on branch-2.x we have kept this change just to keep code in sync across branches. * Error Prone 2.31.0 is the latest version which supports running on JDK 11 Signed-off-by: Istvan Toth <stoty@apache.org> Reviewed-by: Aman Poonia <apoonia@salesforce.com>

NihalJain commented May 15, 2025
View reviewed changes

Comment thread...shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh

NihalJain commented May 15, 2025
View reviewed changes

Comment threadhbase-shaded/pom.xml

NihalJain commented May 15, 2025
View reviewed changes

Comment threadpom.xml Outdated

This comment has been minimized.
Sign in to view

NihalJain requested review from Apache9, ndimiduk and stoty May 17, 2025 04:26

NihalJain added 3 commits May 27, 2025 23:18

Add --should-stop=ifError=FLOW as compilerArgs. This is required by…
952495f
… error prone >= 2.36.0. See google/error-prone@e71db1f

Update to use RC1 jars
1d96a8f

NihalJain force-pushed the test_v_4.1.11 branch from 71e9142 to 1d96a8fCompare May 27, 2025 17:53

This comment has been minimized.
Sign in to view

Drop staging repo
bbedbe4

This comment has been minimized.
Sign in to view

stoty approved these changes Jun 2, 2025
View reviewed changes

NihalJain merged commit 899e4fc into apache:masterJun 2, 2025

Uh oh!

Conversation

NihalJain commented May 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NihalJain commented May 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

NihalJain commented May 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented May 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented May 29, 2025

Uh oh!

This comment has been minimized.

Apache-HBase commented May 31, 2025

Uh oh!

Apache-HBase commented Jun 1, 2025

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

NihalJain commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NihalJain commented May 15, 2025•
edited
Loading

NihalJain commented May 15, 2025•
edited
Loading