Skip to content

HBASE-23664 Upgrade JUnit to 4.13 - #1010

Merged
ndimiduk merged 1 commit into
apache:branch-1from
ndimiduk:23664-junit-4.13-branch-1
Jan 10, 2020
Merged

HBASE-23664 Upgrade JUnit to 4.13#1010
ndimiduk merged 1 commit into
apache:branch-1from
ndimiduk:23664-junit-4.13-branch-1

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

Backport of #1004 to branch-1.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be a junit5 issue open. Follow-up?

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Doesn't seem to be a junit5 issue open. Follow-up?

https://issues.apache.org/jira/browse/HBASE-23671

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚mvninstall8m 22sbranch-1 passed
+1 💚compile1m 48sbranch-1 passed with JDK v1.8.0_232
+1 💚compile1m 57sbranch-1 passed with JDK v1.7.0_242
+1 💚shadedjars3m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 13sbranch-1 passed with JDK v1.8.0_232
+1 💚javadoc4m 5sbranch-1 passed with JDK v1.7.0_242
_ Patch Compile Tests _
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile1m 48sthe patch passed with JDK v1.8.0_232
+1 💚javac1m 48sthe patch passed
+1 💚compile1m 56sthe patch passed with JDK v1.7.0_242
+1 💚javac1m 56sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 0sThe patch has 1 ill-formed XML file(s).
+1 💚shadedjars3m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 11sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc2m 5sthe patch passed with JDK v1.8.0_232
+1 💚javadoc4m 7sthe patch passed with JDK v1.7.0_242
_ Other Tests _
-1 ❌unit186m 22sroot in the patch failed.
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
238m 52s
ReasonTests
XMLParsing Error(s):
pom.xml
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.replication.TestReplicationAdminWithClusters
hadoop.hbase.client.TestAdmin1
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.regionserver.TestCompactionState
hadoop.hbase.client.TestAdmin2
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/artifact/out/Dockerfile
GITHUB PR#1010
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 4e1a2e21534f 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1010/out/precommit/personality/provided.sh
git revisionbranch-1 / 6b940ae
Default Java1.7.0_242
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/artifact/out/xml.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/testReport/
Max. process+thread count3896 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/console
versionsgit=1.9.1 maven=3.0.5
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

That's a lot of failures. Kicking the PR job to try again.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚mvninstall8m 43sbranch-1 passed
+1 💚compile1m 42sbranch-1 passed with JDK v1.8.0_232
+1 💚compile1m 49sbranch-1 passed with JDK v1.7.0_242
+1 💚shadedjars2m 49sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 13sbranch-1 passed with JDK v1.8.0_232
+1 💚javadoc3m 46sbranch-1 passed with JDK v1.7.0_242
_ Patch Compile Tests _
+1 💚mvninstall2m 1sthe patch passed
+1 💚compile1m 42sthe patch passed with JDK v1.8.0_232
+1 💚javac1m 42sthe patch passed
+1 💚compile1m 45sthe patch passed with JDK v1.7.0_242
+1 💚javac1m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌xml0m 1sThe patch has 1 ill-formed XML file(s).
+1 💚shadedjars2m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 0sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc2m 7sthe patch passed with JDK v1.8.0_232
+1 💚javadoc3m 48sthe patch passed with JDK v1.7.0_242
_ Other Tests _
-1 ❌unit147m 38sroot in the patch failed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
198m 52s
ReasonTests
XMLParsing Error(s):
pom.xml
Failed junit testshadoop.hbase.client.TestAdmin2
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.regionserver.TestCompactionState
hadoop.hbase.security.token.TestGenerateDelegationToken
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/artifact/out/Dockerfile
GITHUB PR#1010
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 84529f3a5ea7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1010/out/precommit/personality/provided.sh
git revisionbranch-1 / 6b940ae
Default Java1.7.0_242
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
xmlhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/artifact/out/xml.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/testReport/
Max. process+thread count4560 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/console
versionsgit=1.9.1 maven=3.0.5
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 248d80b into apache:branch-1Jan 10, 2020
@ndimiduk
ndimiduk deleted the 23664-junit-4.13-branch-1 branch January 10, 2020 21:24
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 13, 2020
ndimiduk added a commit that referenced this pull request Jan 13, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@saintstack