Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)"

[ndimiduk]

This reverts commit 248d80b.

[ndimiduk]

I can reproduce test failures in TestCompactionState locally. The symptoms are very strange -- it seems the client's thread pool is terminated before the client has finished using it. The test looks clumsy -- it's testing a series of compaction actions (asynchronous and stateful) on the same underlying test cluster.

Reverting upgrade for now.

[ndimiduk]

I believe I understand the problem. See https://issues.apache.org/jira/browse/HBASE-23664?focusedCommentId=17014607&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17014607

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 23s	branch-1 passed
+1 💚	compile	1m 49s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	1m 56s	branch-1 passed with JDK v1.7.0_242
+1 💚	shadedjars	2m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 19s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	4m 2s	branch-1 passed with JDK v1.7.0_242
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	1m 50s	the patch passed with JDK v1.8.0_232
+1 💚	javac	1m 50s	the patch passed
+1 💚	compile	1m 54s	the patch passed with JDK v1.7.0_242
+1 💚	javac	1m 54s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	xml	0m 0s	The patch has 1 ill-formed XML file(s).
+1 💚	shadedjars	3m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	6m 13s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	2m 37s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	4m 44s	the patch passed with JDK v1.7.0_242
		_ Other Tests _
-1 ❌	unit	153m 19s	root in the patch failed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		202m 58s

Reason	Tests
XML	Parsing Error(s):
	pom.xml
Failed junit tests	hadoop.hbase.regionserver.TestEndToEndSplitTransaction

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1031/1/artifact/out/Dockerfile
GITHUB PR	#1031
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux a9775177a969 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1031/out/precommit/personality/provided.sh
git revision	branch-1 / 248d80b
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
xml	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1031/1/artifact/out/xml.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1031/1/artifact/out/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1031/1/testReport/
Max. process+thread count	4243 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1031/1/console
versions	git=1.9.1 maven=3.0.5
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.