Skip to content

HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils - #1036

Merged
HorizonNet merged 3 commits into
apache:masterfrom
ultratendency:HBASE-23686
Jan 19, 2020
Merged

HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils#1036
HorizonNet merged 3 commits into
apache:masterfrom
ultratendency:HBASE-23686

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

Based on the feedback from Sean on #1034.

"local filesystem implementation doesn't support storage policies.", exception);
}
// check for lack of HDFS-7228
if (e instanceof InvocationTargetException) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be two direct checks for RemoteException and UnsupportedOperationException respectively. Now that we're not using reflection it won't be wrapped in InvocationTargetException

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the outer check for the InvocationTargetException.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall6m 27smaster passed
+1 💚compile0m 38smaster passed
+1 💚checkstyle2m 38smaster passed
+1 💚shadedjars4m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
+0 🆗spotbugs0m 48sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 16sbranch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 58sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 38sthe patch passed
+1 💚checkstyle2m 34sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚shadedjars4m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck15m 36sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 35sthe patch passed
+0 🆗findbugs0m 14shbase-checkstyle has no data from findbugs
_ Other Tests _
+1 💚unit0m 14shbase-checkstyle in the patch passed.
+1 💚unit3m 19shbase-common in the patch passed.
+1 💚unit153m 29shbase-server in the patch passed.
+1 💚asflicense1m 0sThe patch does not generate ASF License warnings.
211m 59s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1036/2/artifact/out/Dockerfile
GITHUB PR#1036
Optional Testsdupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
unameLinux bbfc7495a56d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1036/out/precommit/personality/provided.sh
git revisionmaster / 499ff32
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1036/2/testReport/
Max. process+thread count5535 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-common U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1036/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HorizonNet@Apache-HBase@busbey