Skip to content

HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils - #1073

Merged
HorizonNet merged 1 commit into
apache:branch-2from
ultratendency:HBASE-23686_branch-2
Jan 24, 2020
Merged

HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils#1073
HorizonNet merged 1 commit into
apache:branch-2from
ultratendency:HBASE-23686_branch-2

Conversation

@HorizonNet

Copy link
Copy Markdown
Contributor

Backport of #1036 to branch-2.

…emoved reflections in CommonFSUtils
Signed-off-by: Sean Busbey <busbey@apache.org>
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-0 ⚠️test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 19sbranch-2 passed
+1 💚compile0m 38sbranch-2 passed
+1 💚checkstyle2m 15sbranch-2 passed
+1 💚shadedjars4m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sbranch-2 passed
+0 🆗spotbugs0m 48sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 17sbranch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 50sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚checkstyle2m 11sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚shadedjars4m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck15m 22sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 36sthe patch passed
+0 🆗findbugs0m 15shbase-checkstyle has no data from findbugs
_ Other Tests _
+1 💚unit0m 13shbase-checkstyle in the patch passed.
+1 💚unit3m 10shbase-common in the patch passed.
+1 💚unit149m 42shbase-server in the patch passed.
+1 💚asflicense1m 5sThe patch does not generate ASF License warnings.
206m 12s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1073/1/artifact/out/Dockerfile
GITHUB PR#1073
Optional Testsdupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
unameLinux 9bb1710bd3b2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1073/out/precommit/personality/provided.sh
git revisionbranch-2 / f6a2238
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1073/1/testReport/
Max. process+thread count5025 (vs. ulimit of 10000)
modulesC: hbase-checkstyle hbase-common U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1073/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you probably need @busbey sign-off.

@HorizonNet
HorizonNet merged commit bfa4b0c into apache:branch-2Jan 24, 2020
@HorizonNet
HorizonNet deleted the HBASE-23686_branch-2 branch January 24, 2020 19:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@HorizonNet@Apache-HBase@busbey@saintstack