Skip to content

HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest - #1046

Merged
HorizonNet merged 4 commits into
apache:branch-1from
ultratendency:HBASE-23623_branch-1
Jan 23, 2020
Merged

HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest#1046
HorizonNet merged 4 commits into
apache:branch-1from
ultratendency:HBASE-23623_branch-1

Conversation

@HorizonNet

@HorizonNetHorizonNet commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

Backport of #970 to branch-1.

@Apache-HBase

Apache-HBase commented Jan 15, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
+1 💚mvninstall8m 22sbranch-1 passed
+1 💚compile0m 21sbranch-1 passed with JDK v1.8.0_232
+1 💚compile0m 26sbranch-1 passed with JDK v1.7.0_242
+1 💚checkstyle0m 37sbranch-1 passed
+1 💚shadedjars2m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 29sbranch-1 passed with JDK v1.8.0_232
+1 💚javadoc0m 25sbranch-1 passed with JDK v1.7.0_242
+0 🆗spotbugs1m 14sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 12sbranch-1 passed
_ Patch Compile Tests _
+1 💚mvninstall1m 55sthe patch passed
+1 💚compile0m 20sthe patch passed with JDK v1.8.0_232
+1 💚javac0m 20sthe patch passed
+1 💚compile0m 26sthe patch passed with JDK v1.7.0_242
+1 💚javac0m 26sthe patch passed
-1 ❌checkstyle0m 31shbase-rest: The patch generated 1 new + 22 unchanged - 48 fixed = 23 total (was 70)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars2m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck4m 48sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 19sthe patch passed with JDK v1.8.0_232
+1 💚javadoc0m 27sthe patch passed with JDK v1.7.0_242
+1 💚findbugs1m 13sthe patch passed
_ Other Tests _
+1 💚unit14m 31shbase-rest in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
46m 38s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/artifact/out/Dockerfile
GITHUB PR#1046
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux b6b617a3b334 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revisionbranch-1 / 907184d
Default Java1.7.0_242
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/artifact/out/diff-checkstyle-hbase-rest.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/testReport/
Max. process+thread count2058 (vs. ulimit of 10000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

busbey
busbey reviewed Jan 15, 2020
View reviewed changes
Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java Outdated
@@ -1,5 +1,4 @@
/*
*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be doing /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesResource.java Outdated
@@ -1,5 +1,4 @@
/*
*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithLabels.java Outdated
@@ -1,4 +1,4 @@
/*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java Outdated
@@ -1,5 +1,4 @@
/*
*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteHTableRetries.java Outdated
@@ -1,4 +1,4 @@
/*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java Outdated
@@ -1,5 +1,4 @@
/*
*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java Outdated
@@ -1,5 +1,4 @@
/*
*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment threadhbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java Outdated
@@ -1,5 +1,4 @@
/*
*
/**

@busbeybusbeyJan 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

@HorizonNetHorizonNetJan 16, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Apache-HBase

Apache-HBase commented Jan 15, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
-1 ❌mvninstall0m 9sroot in branch-1 failed.
-1 ❌compile0m 7shbase-rest in branch-1 failed with JDK v1.8.0_232.
-1 ❌compile0m 6shbase-rest in branch-1 failed with JDK v1.7.0_242.
-1 ❌checkstyle0m 5sThe patch fails to run checkstyle in hbase-rest
-1 ❌shadedjars0m 6sbranch has 11 errors when building our shaded downstream artifacts.
-1 ❌javadoc0m 6shbase-rest in branch-1 failed with JDK v1.8.0_232.
-1 ❌javadoc0m 8shbase-rest in branch-1 failed with JDK v1.7.0_242.
+0 🆗spotbugs0m 27sUsed deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌findbugs0m 7shbase-rest in branch-1 failed.
_ Patch Compile Tests _
-1 ❌mvninstall0m 7sroot in the patch failed.
-1 ❌compile0m 6shbase-rest in the patch failed with JDK v1.8.0_232.
-1 ❌javac0m 6shbase-rest in the patch failed with JDK v1.8.0_232.
-1 ❌compile0m 7shbase-rest in the patch failed with JDK v1.7.0_242.
-1 ❌javac0m 7shbase-rest in the patch failed with JDK v1.7.0_242.
-1 ❌checkstyle0m 5sThe patch fails to run checkstyle in hbase-rest
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌shadedjars0m 5spatch has 11 errors when building our shaded downstream artifacts.
-1 ❌hadoopcheck0m 6sThe patch causes 11 errors with Hadoop v2.8.5.
-1 ❌hadoopcheck0m 11sThe patch causes 11 errors with Hadoop v2.9.2.
-1 ❌javadoc0m 6shbase-rest in the patch failed with JDK v1.8.0_232.
-1 ❌javadoc0m 7shbase-rest in the patch failed with JDK v1.7.0_242.
-1 ❌findbugs0m 8shbase-rest in the patch failed.
_ Other Tests _
-1 ❌unit0m 7shbase-rest in the patch failed.
+0 🆗asflicense0m 7sASF License check generated no output?
4m 6s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/Dockerfile
GITHUB PR#1046
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 993b0752a80e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revisionbranch-1 / 907184d
Default Java1.7.0_242
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-compile-hbase-rest-jdk1.8.0_232.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-compile-hbase-rest-jdk1.7.0_242.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/maven-branch-checkstyle-hbase-rest.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-shadedjars.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-javadoc-hbase-rest-jdk1.8.0_232.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-javadoc-hbase-rest-jdk1.7.0_242.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-findbugs-hbase-rest.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.8.0_232.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.8.0_232.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.7.0_242.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.7.0_242.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/maven-patch-checkstyle-hbase-rest.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javac-2.9.2.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javadoc-hbase-rest-jdk1.8.0_232.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javadoc-hbase-rest-jdk1.7.0_242.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-findbugs-hbase-rest.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-unit-hbase-rest.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/testReport/
Max. process+thread count46 (vs. ulimit of 10000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/console
versionsgit=1.9.1 maven=3.0.5
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 16, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
+1 💚mvninstall9m 47sbranch-1 passed
+1 💚compile0m 19sbranch-1 passed with JDK v1.8.0_242
+1 💚compile0m 26sbranch-1 passed with JDK v1.7.0_252
+1 💚checkstyle0m 36sbranch-1 passed
+1 💚shadedjars2m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sbranch-1 passed with JDK v1.8.0_242
+1 💚javadoc0m 26sbranch-1 passed with JDK v1.7.0_252
+0 🆗spotbugs1m 15sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 11sbranch-1 passed
_ Patch Compile Tests _
+1 💚mvninstall1m 55sthe patch passed
+1 💚compile0m 21sthe patch passed with JDK v1.8.0_242
+1 💚javac0m 21sthe patch passed
+1 💚compile0m 26sthe patch passed with JDK v1.7.0_252
+1 💚javac0m 26sthe patch passed
+1 💚checkstyle0m 30shbase-rest: The patch generated 0 new + 21 unchanged - 49 fixed = 21 total (was 70)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars2m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 3sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 19sthe patch passed with JDK v1.8.0_242
+1 💚javadoc0m 26sthe patch passed with JDK v1.7.0_252
+1 💚findbugs1m 12sthe patch passed
_ Other Tests _
+1 💚unit14m 5shbase-rest in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
54m 20s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/artifact/out/Dockerfile
GITHUB PR#1046
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 760cad888e64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revisionbranch-1 / 99a328f
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/testReport/
Max. process+thread count2031 (vs. ulimit of 10000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 20, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
+1 💚mvninstall8m 43sbranch-1 passed
+1 💚compile0m 22sbranch-1 passed with JDK v1.8.0_242
+1 💚compile0m 27sbranch-1 passed with JDK v1.7.0_252
+1 💚checkstyle0m 37sbranch-1 passed
+1 💚shadedjars3m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sbranch-1 passed with JDK v1.8.0_242
+1 💚javadoc0m 29sbranch-1 passed with JDK v1.7.0_252
+0 🆗spotbugs1m 17sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 15sbranch-1 passed
-0 ⚠️patch1m 25sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚mvninstall2m 2sthe patch passed
+1 💚compile0m 23sthe patch passed with JDK v1.8.0_242
+1 💚javac0m 23sthe patch passed
+1 💚compile0m 28sthe patch passed with JDK v1.7.0_252
+1 💚javac0m 28sthe patch passed
+1 💚checkstyle0m 31shbase-rest: The patch generated 0 new + 18 unchanged - 33 fixed = 18 total (was 51)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars2m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 12sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 22sthe patch passed with JDK v1.8.0_242
+1 💚javadoc0m 26sthe patch passed with JDK v1.7.0_252
+1 💚findbugs1m 20sthe patch passed
_ Other Tests _
+1 💚unit14m 47shbase-rest in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
48m 44s
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/artifact/out/Dockerfile
GITHUB PR#1046
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 617896b749df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revisionbranch-1 / 2e3273f
Default Java1.7.0_252
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/testReport/
Max. process+thread count2014 (vs. ulimit of 10000)
modulesC: hbase-rest U: hbase-rest
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Jan 22, 2020
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. LGTM.

@HorizonNet
HorizonNet merged commit 02d80b2 into apache:branch-1Jan 23, 2020
@HorizonNet
HorizonNet deleted the HBASE-23623_branch-1 branch January 23, 2020 12:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busbeybusbeybusbey left review comments
@saintstacksaintstacksaintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HorizonNet@Apache-HBase@busbey@saintstack