HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest

[HorizonNet]

No description provided.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 11 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	8m 33s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	shadedjars	6m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	master passed
+0 🆗	spotbugs	1m 12s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 32s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
-1 ❌	checkstyle	0m 22s	hbase-rest: The patch generated 4 new + 2 unchanged - 52 fixed = 6 total (was 54)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	6m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	25m 42s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 28s	the patch passed
+1 💚	findbugs	1m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 35s	hbase-rest in the patch passed.
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		79m 30s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/1/artifact/out/Dockerfile
GITHUB PR	#970
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d8b7c9ac06ea 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-970/out/precommit/personality/provided.sh
git revision	master / 2ca1e46
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/1/artifact/out/diff-checkstyle-hbase-rest.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/1/testReport/
Max. process+thread count	1955 (vs. ulimit of 10000)
modules	C: hbase-rest U: hbase-rest
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 11 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	8m 29s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	checkstyle	0m 21s	master passed
+1 💚	shadedjars	5m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
+0 🆗	spotbugs	1m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 2s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 26s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	checkstyle	0m 16s	hbase-rest: The patch generated 0 new + 2 unchanged - 52 fixed = 2 total (was 54)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 47s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 21s	the patch passed
+1 💚	findbugs	1m 2s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 8s	hbase-rest in the patch passed.
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		59m 38s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/2/artifact/out/Dockerfile
GITHUB PR	#970
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ba99a61996a2 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-970/out/precommit/personality/provided.sh
git revision	master / 2ca1e46
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/2/testReport/
Max. process+thread count	1943 (vs. ulimit of 10000)
modules	C: hbase-rest U: hbase-rest
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-970/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[HorizonNet]

@saintstack I made some additional changes based on the failing build. Could you please take another look at this one?

[saintstack]

LGTM again. Thanks.