Uh oh!
There was an error while loading. Please reload this page.
HBASE-23968 Periodically check whether a system stop is requested in compaction by time. - #1274
Conversation
Apache-HBase
commented
Mar 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 11, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 11, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 11, 2020
🎊 +1 overall
This message was automatically generated. |
saintstack
left a comment
There was a problem hiding this comment.
This is a sweet patch. Nice little bit of cleanup. Left some minor comments below.
Uh oh!
There was an error while loading. Please reload this page.
| * Check periodically to see if a system stop is requested | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class CloseChecker { |
There was a problem hiding this comment.
Does it have to be public? Can it be package local? It is only used in this package?
There was a problem hiding this comment.
I think it would be good to use package local.
However, The package of FaultyMobStoreCompactor is not the same as CloseChecker.
The package of FaultyMobStoreCompactor is org.apache.hadoop.hbase.mob.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| this.lastCloseCheckMillis = currentTime; | ||
| } | ||
| public boolean isClosedBySizeLimit(Store store, long bytesWritten) { |
There was a problem hiding this comment.
s/isClosedBySizeLimit/isSizeLimit/g
Uh oh!
There was an error while loading. Please reload this page.
mwkang
commented
Mar 27, 2020
@saintstack Thank you for your review. I reflected your feedback. |
saintstack
left a comment
There was a problem hiding this comment.
Approved pending QA build. Nice.
| * Check periodically to see if a system stop is requested | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class CloseChecker { |
mwkang
commented
Mar 30, 2020
retest build |
mwkang
commented
Mar 30, 2020
retest this please |
busbey
commented
Mar 30, 2020
I started the qabot again |
mwkang
commented
Mar 30, 2020
@busbey Thank you!! |
Apache-HBase
commented
Mar 30, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 30, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 30, 2020
🎊 +1 overall
This message was automatically generated. |
mwkang
commented
Mar 30, 2020
@saintstack I fixed checkstyle error. But I don't know why unit was failed. |
saintstack
commented
Mar 30, 2020
Hard to tell. It failed making the report. See below. Let me try locally and if good I'll commit. |
saintstack
commented
Mar 30, 2020
Let me retry the run here too. |
Apache-HBase
commented
Mar 31, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2020
🎊 +1 overall
This message was automatically generated. |
mwkang
commented
Mar 31, 2020
@saintstack Thank you! |
Apache-HBase
commented
Mar 31, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 31, 2020
🎊 +1 overall
This message was automatically generated. |
mwkang
commented
Apr 5, 2020
@saintstack May I ask you to confirm it? |
Apache-HBase
commented
Apr 7, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 7, 2020
💔 -1 overall
This message was automatically generated. |
mwkang
commented
Apr 7, 2020
|
mwkang
commented
Apr 7, 2020
The failure of |
Apache-HBase
commented
Apr 7, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 8, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 8, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 8, 2020
🎊 +1 overall
This message was automatically generated. |
@saintstack All test is green. Could you check this PR? |
saintstack
commented
May 4, 2020
Sorry for taking so long to get back to this @mwkang I merged to master. I tried to backport to branch-2 but conflicts. Please put up a new PR and I'll merge it back. You might have to do one for branch-1 too. Thanks. |
mwkang
commented
May 6, 2020
Thanks you. Okay I will. |
The compaction check that the system is stopped when it reaches hbase.hstore.close.check.interval (size) or hbase.hstore.close.check.time.interval (time)