HBASE-20521 change getConf as first sequence instead of jobContext in…

[sanyaa92]

… checkoutspecs 1.4

checkoutspecs to use context configuration if it is null to work in 1.4.x versions, it is merged in 2.x version

[Reidddddd]

Hi,

Thanks for this PR.

The HBase project mainly use The ASF JIRA for tracking issues, would you mind attaching a patch and discussing there?

For how to contribute to HBase, please refer to Get involved for more details.

And feel free to email your questions or doubts to user@hbase.apache.org for help.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1180	Docker mode activated.
		_ Prechecks _
0	findbugs	0	Findbugs executables are not available.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1.4 Compile Tests _
+1	mvninstall	152	branch-1.4 passed
+1	compile	38	branch-1.4 passed with JDK v1.8.0_202
+1	compile	42	branch-1.4 passed with JDK v1.7.0_211
+1	checkstyle	74	branch-1.4 passed
+1	shadedjars	156	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	30	branch-1.4 passed with JDK v1.8.0_202
+1	javadoc	39	branch-1.4 passed with JDK v1.7.0_211
		_ Patch Compile Tests _
+1	mvninstall	107	the patch passed
+1	compile	38	the patch passed with JDK v1.8.0_202
+1	javac	38	the patch passed
+1	compile	46	the patch passed with JDK v1.7.0_211
+1	javac	46	the patch passed
+1	checkstyle	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	159	patch has no errors when building our shaded downstream artifacts.
-1	hadoopcheck	64	The patch causes 26 errors with Hadoop v2.4.1.
-1	hadoopcheck	139	The patch causes 26 errors with Hadoop v2.5.2.
+1	javadoc	28	the patch passed with JDK v1.8.0_202
+1	javadoc	38	the patch passed with JDK v1.7.0_211
		_ Other Tests _
-1	unit	2838	hbase-server in the patch failed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		5488

Reason	Tests
Failed junit tests	hadoop.hbase.mapreduce.TestImportExport
	hadoop.hbase.mapreduce.TestTimeRangeMapRed
	hadoop.hbase.mapreduce.TestCopyTable
	hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
	hadoop.hbase.mapreduce.TestRowCounter
	hadoop.hbase.master.procedure.TestCreateTableProcedure
	hadoop.hbase.master.handler.TestEnableTableHandler
	hadoop.hbase.master.TestOpenedRegionHandler
	hadoop.hbase.master.balancer.TestBalancerStatusTagInJMXMetrics
	hadoop.hbase.mapreduce.TestImportTsv
	hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
	hadoop.hbase.master.TestMasterFailover
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.master.TestMasterBalanceThrottling
	hadoop.hbase.master.TestMasterShutdown
	hadoop.hbase.TestHColumnDescriptorDefaultVersions
	hadoop.hbase.mapreduce.TestCellCounter
	hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster
	hadoop.hbase.master.TestMasterFileSystemWithWALDir
	hadoop.hbase.master.TestRestartCluster
	hadoop.hbase.TestHBaseTestingUtility
	hadoop.hbase.master.procedure.TestModifyTableProcedure
	hadoop.hbase.master.TestMasterMetricsWrapper
	hadoop.hbase.mapreduce.TestTableInputFormatScan2
	hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient
	hadoop.hbase.mapreduce.TestHFileOutputFormat2
	hadoop.hbase.master.TestMasterFailoverBalancerPersistence
	hadoop.hbase.mapreduce.TestTableMapReduce
	hadoop.hbase.master.procedure.TestEnableTableProcedure
	hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure
	hadoop.hbase.mapreduce.TestWALRecordReader
	hadoop.hbase.master.procedure.TestTruncateTableProcedure
	hadoop.hbase.TestAcidGuarantees
	hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner
	hadoop.hbase.master.TestDistributedLogSplitting
	hadoop.hbase.master.TestSplitLogManager
	hadoop.hbase.master.TestAssignmentListener
	hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
	hadoop.hbase.master.TestGetInfoPort
	hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
	hadoop.hbase.master.snapshot.TestSnapshotFileCache
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
	hadoop.hbase.mapreduce.TestHFileOutputFormat
	hadoop.hbase.master.TestRegionPlacement2
	hadoop.hbase.mapreduce.TestMultiTableInputFormat
	hadoop.hbase.mapreduce.TestTableInputFormat
	hadoop.hbase.mapreduce.TestMultithreadedTableMapper
	hadoop.hbase.mapreduce.TestTableRecordReader
	hadoop.hbase.master.cleaner.TestHFileCleaner
	hadoop.hbase.master.TestCatalogJanitorInMemoryStates
	hadoop.hbase.master.cleaner.TestLogsCleaner
	hadoop.hbase.master.handler.TestCreateTableHandler
	hadoop.hbase.master.procedure.TestCreateNamespaceProcedure
	hadoop.hbase.mapreduce.TestImportTSVWithTTLs
	hadoop.hbase.master.TestMasterRestartAfterDisablingTable
	hadoop.hbase.master.procedure.TestServerCrashProcedure
	hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
	hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
	hadoop.hbase.master.TestMaster
	hadoop.hbase.regionserver.TestCacheOnWriteInSchema
	hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
	hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
	hadoop.hbase.mapreduce.TestHRegionPartitioner
	hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
	hadoop.hbase.master.procedure.TestCreateTableProcedure2
	hadoop.hbase.client.TestHTablePool$TestHTableReusablePool
	hadoop.hbase.mapreduce.TestWALPlayer
	hadoop.hbase.mapreduce.TestHashTable
	hadoop.hbase.mapred.TestTableMapReduce
	hadoop.hbase.mapreduce.TestSyncTable
	hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure
	hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
	hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool
	hadoop.hbase.mapreduce.TestHLogRecordReader
	hadoop.hbase.master.TestMasterMetrics
	hadoop.hbase.master.TestMetaShutdownHandler
	hadoop.hbase.master.TestGetLastFlushedSequenceId
	hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
	hadoop.hbase.regionserver.TestHRegion
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
	hadoop.hbase.master.procedure.TestDeleteTableProcedure
	hadoop.hbase.master.TestMasterFileSystem
	hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure
	hadoop.hbase.master.TestDeadServer
	hadoop.hbase.master.TestZKBasedOpenCloseRegion
	hadoop.hbase.master.procedure.TestMasterProcedureEvents
	hadoop.hbase.master.TestTableLockManager
	hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure
	hadoop.hbase.master.procedure.TestDisableTableProcedure
	hadoop.hbase.master.procedure.TestProcedureAdmin
	hadoop.hbase.mapreduce.TestTableInputFormatScan1
	hadoop.hbase.master.TestRollingRestart

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/1/artifact/out/Dockerfile
GITHUB PR	#92
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 0337a282665a 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-1.4 / 06d97dc
maven	version: Apache Maven 3.0.5
Default Java	1.7.0_211
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_202 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_211
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/1/artifact/out/patch-javac-2.4.1.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/1/artifact/out/patch-javac-2.5.2.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/1/testReport/
Max. process+thread count	1079 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	51	Docker mode activated.
		_ Prechecks _
0	findbugs	0	Findbugs executables are not available.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1.4 Compile Tests _
+1	mvninstall	224	branch-1.4 passed
+1	compile	40	branch-1.4 passed with JDK v1.8.0_202
+1	compile	42	branch-1.4 passed with JDK v1.7.0_211
+1	checkstyle	84	branch-1.4 passed
+1	shadedjars	170	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	branch-1.4 passed with JDK v1.8.0_202
+1	javadoc	39	branch-1.4 passed with JDK v1.7.0_211
		_ Patch Compile Tests _
+1	mvninstall	105	the patch passed
+1	compile	44	the patch passed with JDK v1.8.0_202
+1	javac	44	the patch passed
+1	compile	44	the patch passed with JDK v1.7.0_211
+1	javac	44	the patch passed
+1	checkstyle	87	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	169	patch has no errors when building our shaded downstream artifacts.
-1	hadoopcheck	89	The patch causes 26 errors with Hadoop v2.4.1.
-1	hadoopcheck	179	The patch causes 26 errors with Hadoop v2.5.2.
-1	hadoopcheck	282	The patch causes 16 errors with Hadoop v2.6.5.
+1	javadoc	31	the patch passed with JDK v1.8.0_202
+1	javadoc	39	the patch passed with JDK v1.7.0_211
		_ Other Tests _
+1	unit	6563	hbase-server in the patch passed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		8250

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/2/artifact/out/Dockerfile
GITHUB PR	#92
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8fd276b156e2 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-1.4 / 128adc0
maven	version: Apache Maven 3.0.5
Default Java	1.7.0_211
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_202 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_211
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/2/artifact/out/patch-javac-2.4.1.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/2/artifact/out/patch-javac-2.5.2.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/2/artifact/out/patch-javac-2.6.5.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/2/testReport/
Max. process+thread count	4269 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-92/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.