HBASE-8458 Support for batch version of checkAndPut() and checkAndDel… by brfrn169 · Pull Request #1320 · apache/hbase

brfrn169 · 2020-03-21T21:28:05Z

…ete()

saintstack

Looks very nice.

saintstack · 2020-03-25T05:07:10Z

+ */
+ public Builder qualifier(byte[] qualifier) {
+ this.qualifier = Preconditions.checkNotNull(qualifier, "qualifier is null. Consider using" +
+ " an empty byte array, or just do not call this method if you want a null qualifier");


Helpful precondition fail message.
On fail, it comes out ok? Back to the client?

Back to the client. On fail, it will throw NullPointerException.

saintstack · 2020-03-25T05:09:01Z

+ * @param value the expected value
+ * @return the builder object
+ */
+ public Builder ifMatches(CompareOperator compareOp, byte[] value) {


s/ifMatches/ifCompares/?

We already have the same name as this method in Table$CheckAndMutateBuilder and AsyncTable$CheckAndMutateBuilder, so I named this method as the same name.
Table$CheckAndMutateBuilder#ifMatches:
https://github.com/brfrn169/hbase/blob/f66cbe1a40cd9d4cd4abd27c7ac9d1a5168b885f/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L346
AsyncTable$CheckAndMutateBuilder#ifMatches:
https://github.com/brfrn169/hbase/blob/f66cbe1a40cd9d4cd4abd27c7ac9d1a5168b885f/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java#L269

saintstack · 2020-03-25T05:23:04Z

+ regionActionBuilder.addAction(actionBuilder.setMutation(mp).build());
 }
 }



Argh. The old code was hard to decipher.

brfrn169

Thank you for reviewing this! @saintstack @HorizonNet

I will modify this patch and push a new patch.

brfrn169 · 2020-03-27T23:40:51Z

+ */
+ public Builder qualifier(byte[] qualifier) {
+ this.qualifier = Preconditions.checkNotNull(qualifier, "qualifier is null. Consider using" +
+ " an empty byte array, or just do not call this method if you want a null qualifier");


Back to the client. On fail, it will throw NullPointerException.

brfrn169 · 2020-03-28T03:01:21Z

+ * @param value the expected value
+ * @return the builder object
+ */
+ public Builder ifMatches(CompareOperator compareOp, byte[] value) {


We already have the same name as this method in Table$CheckAndMutateBuilder and AsyncTable$CheckAndMutateBuilder, so I named this method as the same name.
Table$CheckAndMutateBuilder#ifMatches:
https://github.com/brfrn169/hbase/blob/f66cbe1a40cd9d4cd4abd27c7ac9d1a5168b885f/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java#L346
AsyncTable$CheckAndMutateBuilder#ifMatches:
https://github.com/brfrn169/hbase/blob/f66cbe1a40cd9d4cd4abd27c7ac9d1a5168b885f/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java#L269

brfrn169 · 2020-03-28T03:12:36Z

+ * @param checkAndMutates The list of rows to apply.
+ * @return A {@link CompletableFuture} that wrapper the result boolean list.
+ */
+ default CompletableFuture<List<Boolean>> checkAndMutateAll(


In AsyncTable, for methods returning List object, we provide 2 pattern methods returning List<CompletableFuture> and CompletableFuture<List>, and the latter's name is the former's name + "All".
For example, we already provide AsyncTable#get and AsyncTable#getAll:
https://github.com/brfrn169/hbase/blob/f66cbe1a40cd9d4cd4abd27c7ac9d1a5168b885f/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java#L452-L471
I did the same for checkAndMutate and checkAndMutateAll.

brfrn169 · 2020-03-29T00:47:43Z

I added a new commit. In this commit, I did the following:

Deprecated the old checkAndMutate methods.
Add new checkAndMutate method with a single CheckAndMutate object.

@saintstack @Apache9 @HorizonNet Could you please take look at this when you get a chance?

brfrn169 · 2020-03-30T13:11:51Z

I fixed some conflicts and added the Javadoc for the deprecation. Also, I re-ran QA.

…ete()

Apache-HBase · 2020-04-10T00:58:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 35s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 12s	master passed
+1 💚	checkstyle	2m 44s	master passed
+1 💚	spotbugs	7m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	checkstyle	0m 11s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 31s	hbase-client: The patch generated 0 new + 130 unchanged - 5 fixed = 130 total (was 135)
-0 ⚠️	checkstyle	1m 6s	hbase-server: The patch generated 1 new + 67 unchanged - 0 fixed = 68 total (was 67)
+1 💚	checkstyle	0m 43s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 15s	The patch passed checkstyle in hbase-rest
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 28s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	hbaseprotoc	2m 53s	the patch passed
+1 💚	spotbugs	9m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 55s	The patch does not generate ASF License warnings.
		57m 17s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1320
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool
uname	Linux e85a80b3102c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c92dd28`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-10T04:15:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 1s	master passed
+1 💚	compile	3m 14s	master passed
+1 💚	shadedjars	5m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 49s	the patch passed
+1 💚	compile	3m 8s	the patch passed
+1 💚	javac	3m 8s	the patch passed
+1 💚	shadedjars	5m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 49s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 0s	hbase-client in the patch passed.
+1 💚	unit	203m 51s	hbase-server in the patch passed.
+1 💚	unit	3m 56s	hbase-thrift in the patch passed.
+1 💚	unit	4m 32s	hbase-rest in the patch passed.
		253m 34s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1320
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d92c1bdeeea3 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c92dd28`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/testReport/
Max. process+thread count	3133 (vs. ulimit of 10000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-10T04:23:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 13s	master passed
+1 💚	compile	4m 3s	master passed
+1 💚	shadedjars	6m 8s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 28s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 21s	hbase-rest in master failed.
-0 ⚠️	javadoc	0m 44s	hbase-server in master failed.
-0 ⚠️	javadoc	0m 59s	hbase-thrift in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 53s	the patch passed
+1 💚	compile	3m 57s	the patch passed
+1 💚	javac	3m 57s	the patch passed
+1 💚	shadedjars	6m 29s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 33s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
-0 ⚠️	javadoc	1m 13s	hbase-thrift in the patch failed.
-0 ⚠️	javadoc	0m 25s	hbase-rest in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 18s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 38s	hbase-client in the patch passed.
+1 💚	unit	203m 16s	hbase-server in the patch passed.
+1 💚	unit	3m 54s	hbase-thrift in the patch passed.
+1 💚	unit	3m 32s	hbase-rest in the patch passed.
		261m 50s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1320
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c2f92bee6c02 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c92dd28`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/testReport/
Max. process+thread count	2728 (vs. ulimit of 10000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-10T05:30:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 6s	master passed
+1 💚	checkstyle	3m 4s	master passed
+1 💚	spotbugs	9m 12s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 49s	the patch passed
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 33s	hbase-client: The patch generated 0 new + 130 unchanged - 5 fixed = 130 total (was 135)
-0 ⚠️	checkstyle	1m 18s	hbase-server: The patch generated 1 new + 67 unchanged - 0 fixed = 68 total (was 67)
+1 💚	checkstyle	0m 46s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 16s	The patch passed checkstyle in hbase-rest
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 50s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	hbaseprotoc	3m 0s	the patch passed
+1 💚	spotbugs	10m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 57s	The patch does not generate ASF License warnings.
		64m 45s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1320
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool
uname	Linux 7bbbfcdfe1b7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ac4e94e`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	83 (vs. ulimit of 10000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-10T07:17:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 50s	master passed
+1 💚	compile	3m 53s	master passed
+1 💚	shadedjars	5m 56s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 28s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 21s	hbase-rest in master failed.
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
-0 ⚠️	javadoc	0m 56s	hbase-thrift in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 42s	the patch passed
+1 💚	compile	4m 11s	the patch passed
+1 💚	javac	4m 11s	the patch passed
+1 💚	shadedjars	5m 55s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 27s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 38s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 57s	hbase-thrift in the patch failed.
-0 ⚠️	javadoc	0m 20s	hbase-rest in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 2s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 11s	hbase-client in the patch passed.
+1 💚	unit	119m 3s	hbase-server in the patch passed.
+1 💚	unit	3m 25s	hbase-thrift in the patch passed.
+1 💚	unit	3m 25s	hbase-rest in the patch passed.
		171m 20s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1320
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8aa6ac579f33 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ac4e94e`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/testReport/
Max. process+thread count	4212 (vs. ulimit of 10000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-10T08:24:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 39s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 56s	master passed
+1 💚	compile	3m 20s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 15s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 26s	the patch passed
+1 💚	compile	3m 15s	the patch passed
+1 💚	javac	3m 15s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 56s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 12s	hbase-client in the patch passed.
+1 💚	unit	188m 13s	hbase-server in the patch passed.
+1 💚	unit	3m 45s	hbase-thrift in the patch passed.
+1 💚	unit	4m 4s	hbase-rest in the patch passed.
		238m 13s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1320
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 94505adcfae0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ac4e94e`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/testReport/
Max. process+thread count	2940 (vs. ulimit of 10000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

brfrn169 · 2020-05-02T13:33:20Z

Closing this. Will create another PR.

This comment has been minimized.
Sign in to view

brfrn169 requested review from Apache9, ndimiduk and saintstack and removed request for Apache9 and ndimiduk March 22, 2020 03:35

HorizonNet reviewed Mar 22, 2020
View reviewed changes

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/CheckAndMutate.java Outdated
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/CheckAndMutate.java Outdated
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java

saintstack reviewed Mar 25, 2020
View reviewed changes

brfrn169 commented Mar 28, 2020
View reviewed changes

brfrn169 force-pushed the HBASE-8458 branch from 027f0e5 to 260a115Compare March 28, 2020 13:18

brfrn169 requested review from HorizonNet and saintstack March 28, 2020 13:23

HorizonNet reviewed Mar 30, 2020
View reviewed changes

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java

brfrn169 force-pushed the HBASE-8458 branch from 10b2886 to 349dbc2Compare March 30, 2020 13:06

brfrn169 requested a review from HorizonNet March 30, 2020 13:06

This comment has been minimized.
Sign in to view

HBASE-8458 Support for batch version of checkAndPut() and checkAndDel…
e2801b5
…ete()

brfrn169 force-pushed the HBASE-8458 branch from af7f4af to e2801b5Compare April 10, 2020 00:00

brfrn169 closed this May 2, 2020

brfrn169 self-assigned this Jul 18, 2020

Uh oh!

Conversation

brfrn169 commented Mar 21, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brfrn169 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brfrn169 commented Mar 29, 2020

Uh oh!

Uh oh!

brfrn169 commented Mar 30, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

Apache-HBase commented Apr 10, 2020

Uh oh!

brfrn169 commented May 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

brfrn169 commented Mar 30, 2020•
edited
Loading